[jira] [Resolved] (CARBONDATA-4010) "Alter table set tblproperties should support long string columns" and bad record handling of long string data for string columns need to be updated in https://gith

2020-10-12 Thread Indhumathi Muthu Murugesh (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Indhumathi Muthu Murugesh resolved CARBONDATA-4010. --- Fix Version/s: 2.1.0 Resolution: Fixed > "Alter

[GitHub] [carbondata] asfgit closed pull request #3959: [CARBONDATA-4010] Doc changes for long strings.

2020-10-12 Thread GitBox
asfgit closed pull request #3959: URL: https://github.com/apache/carbondata/pull/3959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-707504154 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2642/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-707502953 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4394/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-12 Thread GitBox
Indhumathi27 commented on a change in pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#discussion_r503670575 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala ## @@

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-12 Thread GitBox
Indhumathi27 commented on a change in pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#discussion_r503670575 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala ## @@

[GitHub] [carbondata] Indhumathi27 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-12 Thread GitBox
Indhumathi27 commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-707488860 @marchpure If setLastModifiedTime operation do not take effect on S3, in other places also, we need to check and update

[GitHub] [carbondata] marchpure commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-12 Thread GitBox
marchpure commented on pull request #3977: URL: https://github.com/apache/carbondata/pull/3977#issuecomment-707468141 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] asfgit closed pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
asfgit closed pull request #3949: URL: https://github.com/apache/carbondata/pull/3949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
QiangCai commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707463119 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-12 Thread GitBox
QiangCai commented on a change in pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#discussion_r503631339 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForDeleteCommand.scala ## @@ -108,9

[GitHub] [carbondata] QiangCai commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-12 Thread GitBox
QiangCai commented on a change in pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#discussion_r503629383 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -267,9 +266,8 @@ object

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-707316276 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2641/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-707315699 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4393/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3932: [CARBONDATA-3994] Skip Order by for map task if it is sort column and use limit pushdown for array_contains filter

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3932: URL: https://github.com/apache/carbondata/pull/3932#issuecomment-707211367 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2640/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3932: [CARBONDATA-3994] Skip Order by for map task if it is sort column and use limit pushdown for array_contains filter

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3932: URL: https://github.com/apache/carbondata/pull/3932#issuecomment-707209130 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4392/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3917: [CARBONDATA-3978] Clean Files Refactor and support for trash folder in carbondata

2020-10-12 Thread GitBox
vikramahuja1001 commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r503370601 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -1106,23 +1107,55 @@ public static void

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707152498 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4391/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707147440 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2639/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean Files Refactor and support for trash folder in carbondata

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-707122422 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4387/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean Files Refactor and support for trash folder in carbondata

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-707121149 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2635/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [WIP][HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707114968 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2634/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [WIP][HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707108327 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4386/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-707096882 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2637/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3967: [CARBONDATA-4004] [CARBONDATA-4012] Issue with select after update command

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3967: URL: https://github.com/apache/carbondata/pull/3967#issuecomment-707092263 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2633/

[GitHub] [carbondata] asfgit closed pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-12 Thread GitBox
asfgit closed pull request #3978: URL: https://github.com/apache/carbondata/pull/3978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3967: [CARBONDATA-4004] [CARBONDATA-4012] Issue with select after update command

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3967: URL: https://github.com/apache/carbondata/pull/3967#issuecomment-707090745 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4385/

[GitHub] [carbondata] QiangCai commented on pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-12 Thread GitBox
QiangCai commented on pull request #3978: URL: https://github.com/apache/carbondata/pull/3978#issuecomment-707089612 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
QiangCai commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707087877 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707087252 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2638/

[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
QiangCai commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707087176 ok, for testing, it is ok. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-707087260 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4389/

[GitHub] [carbondata] QiangCai commented on pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-10-12 Thread GitBox
QiangCai commented on pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#issuecomment-707073901 merge it. please raise another PR to improve the filter performance. This is an automated message from

[GitHub] [carbondata] marchpure commented on a change in pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-12 Thread GitBox
marchpure commented on a change in pull request #3978: URL: https://github.com/apache/carbondata/pull/3978#discussion_r503242850 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ## @@ -235,14

[GitHub] [carbondata] ajantha-bhat commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
ajantha-bhat commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707085109 @QiangCai : I will check, If I remove, getPositionId() Udf may not work in projection. But it was only test purpose I guess. Shall try to remove?

[GitHub] [carbondata] akashrn5 commented on pull request #3948: [WIP][HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
akashrn5 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707072320 > @akashrn5 : logs were removed as one issue was found. definitely some other issue also there. Added logs and pushed again. yeah

[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
QiangCai commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707084035 @ajantha-bhat can we remove it? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] ajantha-bhat commented on pull request #3932: [CARBONDATA-3994] Skip Order by for map task if it is sort column and use limit pushdown for array_contains filter

2020-10-12 Thread GitBox
ajantha-bhat commented on pull request #3932: URL: https://github.com/apache/carbondata/pull/3932#issuecomment-707071580 @kunal642 : This optimization is only when first sort column is in order by column. so, the data in each task is completely sorted. so applying limit on each task

[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
QiangCai commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707084330 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#issuecomment-707070681 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2631/

[GitHub] [carbondata] ajantha-bhat commented on pull request #3932: [CARBONDATA-3994] Skip Order by for map task if it is sort column and use limit pushdown for array_contains filter

2020-10-12 Thread GitBox
ajantha-bhat commented on pull request #3932: URL: https://github.com/apache/carbondata/pull/3932#issuecomment-707070709 @kumarvishal09 : Agree with you. It has to be the first sort_column only. This is an automated message

[GitHub] [carbondata] asfgit closed pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-12 Thread GitBox
asfgit closed pull request #3924: URL: https://github.com/apache/carbondata/pull/3924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#issuecomment-707069675 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4383/

[GitHub] [carbondata] QiangCai commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-12 Thread GitBox
QiangCai commented on pull request #3924: URL: https://github.com/apache/carbondata/pull/3924#issuecomment-707080395 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-10-12 Thread GitBox
asfgit closed pull request #3953: URL: https://github.com/apache/carbondata/pull/3953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (CARBONDATA-4030) Concurrent SI global sort cannot be success

2020-10-12 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-4030: - Description: when concurrent SI global sort is in progress, one load was removing

[GitHub] [carbondata] asfgit closed pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-12 Thread GitBox
asfgit closed pull request #3976: URL: https://github.com/apache/carbondata/pull/3976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] QiangCai commented on pull request #3976: [CARBONDATA-4026] Fix Thread leakage while Loading

2020-10-12 Thread GitBox
QiangCai commented on pull request #3976: URL: https://github.com/apache/carbondata/pull/3976#issuecomment-707075552 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (CARBONDATA-4030) Concurrent SI global sort cannot be success

2020-10-12 Thread Ajantha Bhat (Jira)
Ajantha Bhat created CARBONDATA-4030: Summary: Concurrent SI global sort cannot be success Key: CARBONDATA-4030 URL: https://issues.apache.org/jira/browse/CARBONDATA-4030 Project: CarbonData

[GitHub] [carbondata] ajantha-bhat commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
ajantha-bhat commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707065386 @QiangCai : It was introduced during secondary index development I guess, you can look up "isPositionIDRequested" in code. They basically use it to decide whether the

[GitHub] [carbondata] ajantha-bhat commented on pull request #3948: [WIP][HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
ajantha-bhat commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707058332 @akashrn5 : logs were removed as one issue was found. definitely some other issue also there. Added logs and pushed again.

[GitHub] [carbondata] akashrn5 commented on pull request #3948: [WIP][HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
akashrn5 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707057298 @ajantha-bhat failed again i think, please check if the same cause or something else This is an automated

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-707057669 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2632/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707052086 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4380/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-707048048 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2629/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean Files Refactor and support for trash folder in carbondata

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-707041413 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4379/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean Files Refactor and support for trash folder in carbondata

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-707039304 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2628/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3978: URL: https://github.com/apache/carbondata/pull/3978#issuecomment-707035119 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2627/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#issuecomment-707031327 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4376/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3978: URL: https://github.com/apache/carbondata/pull/3978#issuecomment-707031326 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4378/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3950: URL: https://github.com/apache/carbondata/pull/3950#issuecomment-707017547 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4382/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3950: URL: https://github.com/apache/carbondata/pull/3950#issuecomment-707016545 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2630/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3935: URL: https://github.com/apache/carbondata/pull/3935#issuecomment-707009914 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2625/

[GitHub] [carbondata] QiangCai commented on pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-10-12 Thread GitBox
QiangCai commented on pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#issuecomment-707009265 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-10-12 Thread GitBox
QiangCai commented on pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#issuecomment-707009405 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3912: [CARBONDATA-3977] Global sort partitions should be determined dynamically

2020-10-12 Thread GitBox
akashrn5 commented on a change in pull request #3912: URL: https://github.com/apache/carbondata/pull/3912#discussion_r503160924 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala ## @@ -227,9 +235,19 @@ object

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3969: URL: https://github.com/apache/carbondata/pull/3969#issuecomment-706997746 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4373/

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3948: [HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
ajantha-bhat edited a comment on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706992959 @Karan980, @marchpure : please check this. @akashrn5 , @QiangCai : Please check and merge this once new build passes.

[GitHub] [carbondata] ajantha-bhat commented on pull request #3948: [HOTFIX] Fix random 11 testcase failure in CI

2020-10-12 Thread GitBox
ajantha-bhat commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706992959 @Karan980, @akashrn5 , @QiangCai : Please check and merge this once new build passes. This is an

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3950: URL: https://github.com/apache/carbondata/pull/3950#issuecomment-706988518 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2624/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#issuecomment-706985772 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4372/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3969: [CARBONDATA-3932] [CARBONDATA-3903] change discovery.uri in presto guide and dml document update

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3969: URL: https://github.com/apache/carbondata/pull/3969#issuecomment-706982841 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2623/

[GitHub] [carbondata] akkio-97 commented on pull request #3967: [CARBONDATA-4004] Issue with select after update command

2020-10-12 Thread GitBox
akkio-97 commented on pull request #3967: URL: https://github.com/apache/carbondata/pull/3967#issuecomment-706982107 Test cases should be written using SDK **update** API to generate carbon files. And currently there is an issue in that when queried either from spark or presto. I have

[GitHub] [carbondata] Karan980 commented on a change in pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
Karan980 commented on a change in pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#discussion_r503140543 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ## @@ -1011,38 +1011,46 @@ object CommonUtil {

[GitHub] [carbondata] Karan980 commented on a change in pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
Karan980 commented on a change in pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#discussion_r503139533 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ## @@ -1011,38 +1011,46 @@ object CommonUtil {

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3950: URL: https://github.com/apache/carbondata/pull/3950#issuecomment-706977245 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4374/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#issuecomment-706972701 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2622/

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be copied to afte

2020-10-12 Thread GitBox
vikramahuja1001 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-706971916 @akashrn5 , pr description is very old, the scope has changed since then, i will update it This is

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-706962594 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2626/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-706960978 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4377/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be co

2020-10-12 Thread GitBox
vikramahuja1001 commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r503116909 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala ## @@ -108,12

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-706959506 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4370/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be co

2020-10-12 Thread GitBox
vikramahuja1001 commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r503115666 ## File path: integration/spark/src/main/scala/org/apache/carbondata/cleanfiles/CleanFilesUtil.scala ## @@ -0,0 +1,259 @@ +/* + * Licensed to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3959: [CARBONDATA-4010] Doc changes for long strings.

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3959: URL: https://github.com/apache/carbondata/pull/3959#issuecomment-706958228 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2620/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be co

2020-10-12 Thread GitBox
vikramahuja1001 commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r503115176 ## File path: core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java ## @@ -192,11 +204,33 @@ private static boolean

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3924: URL: https://github.com/apache/carbondata/pull/3924#issuecomment-706945830 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4369/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
ajantha-bhat commented on a change in pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#discussion_r503099172 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/InsertIntoCarbonTableTestCase.scala ## @@ -67,6

[GitHub] [carbondata] QiangCai commented on a change in pull request #3978: [CARBONDATA-4028] Fix failed to unlock during update

2020-10-12 Thread GitBox
QiangCai commented on a change in pull request #3978: URL: https://github.com/apache/carbondata/pull/3978#discussion_r503098160 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ## @@ -235,14

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
ajantha-bhat commented on a change in pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#discussion_r503097655 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ## @@ -1011,38 +1011,46 @@ object CommonUtil {

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3979: [Carbondata-3954] Fix insertion from ORC table into carbon table when sort scope is global sort

2020-10-12 Thread GitBox
ajantha-bhat commented on a change in pull request #3979: URL: https://github.com/apache/carbondata/pull/3979#discussion_r503096192 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/InsertIntoCarbonTableTestCase.scala ## @@ -67,6

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-706935530 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4371/

[GitHub] [carbondata] QiangCai commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort

2020-10-12 Thread GitBox
QiangCai commented on pull request #3949: URL: https://github.com/apache/carbondata/pull/3949#issuecomment-706934495 why we need table property "isPositionIDRequested"? This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3924: URL: https://github.com/apache/carbondata/pull/3924#issuecomment-706932861 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2619/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3948: [WIP] Analyze random 11 testcase failure in CI

2020-10-12 Thread GitBox
CarbonDataQA1 commented on pull request #3948: URL: https://github.com/apache/carbondata/pull/3948#issuecomment-706928763 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4368/

[jira] [Resolved] (CARBONDATA-4023) Create MV failed on table with geospatial index

2020-10-12 Thread Indhumathi Muthu Murugesh (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Indhumathi Muthu Murugesh resolved CARBONDATA-4023. --- Fix Version/s: 2.1.0 Resolution: Fixed > Create

[jira] [Resolved] (CARBONDATA-3763) wrong insert result during insert stage command

2020-10-12 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3763. -- Fix Version/s: 2.0.0 Resolution: Fixed > wrong insert result during insert

[GitHub] [carbondata] asfgit closed pull request #3966: [CARBONDATA-4023] Create MV failed on table with geospatial index using carbonsession.

2020-10-12 Thread GitBox
asfgit closed pull request #3966: URL: https://github.com/apache/carbondata/pull/3966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (CARBONDATA-3786) presto carbon reader should use tablePath from hive catalog

2020-10-12 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3786. -- Fix Version/s: 2.1.0 Resolution: Fixed

[jira] [Resolved] (CARBONDATA-3788) Fix insert failure during global sort with huge data in new insert flow

2020-10-12 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3788. -- Fix Version/s: 2.1.0 Resolution: Fixed

[jira] [Resolved] (CARBONDATA-3843) Fix Merge index is not created for normal segment on streaming table

2020-10-12 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3843. -- Fix Version/s: 2.1.0 Resolution: Fixed

  1   2   >