[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739619817 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3329/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-06 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-06 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to

[GitHub] [carbondata] QiangCai commented on pull request #4029: refact carbon util

2020-12-06 Thread GitBox
QiangCai commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739614278 please rebase and perfect the title This is an automated message from the Apache Git Service. To respond to

[GitHub] [carbondata] Zhangshunyu commented on pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
Zhangshunyu commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739612930 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Zhangshunyu closed pull request #4040: [WIP][CI TEST]

2020-12-06 Thread GitBox
Zhangshunyu closed pull request #4040: URL: https://github.com/apache/carbondata/pull/4040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] Zhangshunyu commented on pull request #4040: [WIP][CI TEST]

2020-12-06 Thread GitBox
Zhangshunyu commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739609664 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] shenjiayu17 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-06 Thread GitBox
shenjiayu17 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739609378 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739562913 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739547305 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3304/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739547241 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5085/

[GitHub] [carbondata] QiangCai opened a new pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
QiangCai opened a new pull request #4044: URL: https://github.com/apache/carbondata/pull/4044 ### Why is this PR needed? To prevent accidental deletion of data, carbon will introduce trash data management. It will provide buffer time for accidental deletion of data to roll back the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739539209 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] marchpure commented on a change in pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
marchpure commented on a change in pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#discussion_r537069006 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/IUDConcurrencyTestCase.scala ## @@ -0,0 +1,474 @@ +/* + *

[GitHub] [carbondata] marchpure commented on pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
marchpure commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739523754 CI fails. Please fix the CI failures This is an automated message from the Apache Git Service. To respond

[GitHub] [carbondata] marchpure commented on a change in pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
marchpure commented on a change in pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#discussion_r537066618 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -341,8 +341,11 @@ public static boolean

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739523165 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Kejian-Li opened a new pull request #4043: IUD Concurrency Improvement

2020-12-06 Thread GitBox
Kejian-Li opened a new pull request #4043: URL: https://github.com/apache/carbondata/pull/4043 Why is this PR needed? Improve concurrency for Insert/Update/Delete What changes were proposed in this PR? Remove update lock in Update and Delete Command and lock the segments

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739493182 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3302/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739493161 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3326/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739493108 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5059/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739492980 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5083/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739492808 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3325/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739492660 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5082/

[GitHub] [carbondata] Kejian-Li commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

2020-12-06 Thread GitBox
Kejian-Li commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739488366 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739486536 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5058/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739486393 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3301/

[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-06 Thread GitBox
Indhumathi27 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739483872 Retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] QiangCai closed pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-06 Thread GitBox
QiangCai closed pull request #4013: URL: https://github.com/apache/carbondata/pull/4013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-739480246 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3297/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739480247 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-739480248 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3296/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] Added FT for SI and handled missed scenario.

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-739480241 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739480240 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739480239 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3295/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] handled set streaming for SI table or table having SI.

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-739480243 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3290/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4041: [CARBONDATA-4068] handled set long string on MT for column on which SI is already created.

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4041: URL: https://github.com/apache/carbondata/pull/4041#issuecomment-739480242 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5049/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-06 Thread GitBox
CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739480249 This is an automated message from the Apache Git Service. To respond to the message, please log on to

<    1   2