[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r229173916 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -59,11 +60,30 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r229173821 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java --- @@ -0,0 +1,170 @@ +/* + * Licensed to

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2804 @xubo245 : In that case you can implement, String getFirstCarbonFile(path, ExtenstionType) and pass it to existing method. ReadSchemaFromFile() must only read it. It

[GitHub] carbondata issue #2876: [CARBONDATA-3054] Fix Dictionary file cannot be read...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2876 retest this please ---

[GitHub] carbondata issue #2870: [HOTFIX-compatibility] Handle Lazy loading with inve...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2870 @ravipesala : please review ---

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228935418 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1737,4 +1739,95 @@ public void

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228932987 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -90,6 +93,20 @@ public T readNextRow() throws

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228932584 --- Diff: store/CSDK/test/main.cpp --- @@ -220,6 +393,86 @@ bool tryCatchException(JNIEnv *env) { */ bool readFromS3(JNIEnv *env, char

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228932392 --- Diff: store/CSDK/test/main.cpp --- @@ -220,6 +393,86 @@ bool tryCatchException(JNIEnv *env) { */ bool readFromS3(JNIEnv *env, char

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228926855 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/RowBatch.java --- @@ -100,4 +100,25 @@ public int getSize() { counter

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228920818 --- Diff: store/CSDK/test/main.cpp --- @@ -116,6 +118,66 @@ void printResult(JNIEnv *env, CarbonReader reader) { reader.close

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228920786 --- Diff: store/CSDK/test/main.cpp --- @@ -116,6 +118,66 @@ void printResult(JNIEnv *env, CarbonReader reader) { reader.close

[GitHub] carbondata pull request #2876: [CARBONDATA-3054] Fix Dictionary file cannot ...

2018-10-29 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2876 [CARBONDATA-3054] Fix Dictionary file cannot be read in S3a with CarbonDictionaryDecoder.doConsume() codeGen [CARBONDATA-3054] Fix Dictionary file cannot be read in S3a with

[GitHub] carbondata issue #2876: [CARBONDATA-3054] Fix Dictionary file cannot be read...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2876 @ravipesala , @kunal642 : please review ---

[jira] [Created] (CARBONDATA-3054) Dictionary file cannot be read in S3a with CarbonDictionaryDecoder.doConsume() codeGen

2018-10-29 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3054: Summary: Dictionary file cannot be read in S3a with CarbonDictionaryDecoder.doConsume() codeGen Key: CARBONDATA-3054 URL: https://issues.apache.org/jira/browse/CARBONDATA

[GitHub] carbondata pull request #2870: [HOTFIX] Handle Lazy loading with inverted in...

2018-10-29 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2870 [HOTFIX] Handle Lazy loading with inverted index for ColumnarVectorWrapperDirectWithInvertedIndex when the lazy loading with an inverted index, getBlockDataType() was not implemented

[GitHub] carbondata issue #2870: [HOTFIX] Handle Lazy loading with inverted index for...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2870 @kumarvishal09 : please reveiw ---

[GitHub] carbondata issue #2837: [CARBONDATA-3000] Provide C++ interface for writing ...

2018-10-27 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2837 LGTM ---

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228701158 --- Diff: store/CSDK/test/main.cpp --- @@ -210,6 +212,288 @@ bool tryCatchException(JNIEnv *env) { } printf("\nfinished h

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228700968 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228700880 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2826: [CARBONDATA-3023] Alter add column issue with...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2826#discussion_r228542847 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala --- @@ -671,4 +671,20 @@ object

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2792 LGTM ---

[GitHub] carbondata pull request #2826: [CARBONDATA-3023] Alter add column issue with...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2826#discussion_r228500224 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -511,7 +511,7 @@ private

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228480901 --- Diff: store/CSDK/main.cpp --- @@ -99,21 +102,187 @@ bool readFromLocalWithoutProjection(JNIEnv *env) { printf("

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228479559 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/benchmark/SDKReaderBenchmark.java --- @@ -0,0 +1,262 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228477978 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/benchmark/SDKReaderExampleForBigData.java --- @@ -0,0 +1,262

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228468134 --- Diff: store/CSDK/main.cpp --- @@ -484,6 +485,264 @@ bool readPerformanceFromS3(JNIEnv *env, char *argv[]) { reader.close

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228468162 --- Diff: store/CSDK/main.cpp --- @@ -484,6 +485,264 @@ bool readPerformanceFromS3(JNIEnv *env, char *argv[]) { reader.close

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228464096 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -329,6 +344,19 @@ public CarbonWriterBuilder

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228463349 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -329,6 +344,19 @@ public CarbonWriterBuilder

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228459702 --- Diff: store/CSDK/CarbonWriter.cpp --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-26 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228456762 --- Diff: store/CSDK/CarbonWriter.cpp --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2792 @xubo245 : Please update description as readNextCarbonRow is not used and this is not depend on 2738 ---

[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2837#discussion_r228418984 --- Diff: store/CSDK/CarbonWriter.cpp --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2804 @xubo245 : Just reading first file from folder doesn't make sense. This PR is not required as existing API already support all user scenarios. please check my comment for

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r228413841 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -59,11 +60,30 @@ public static Schema

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228411015 --- Diff: store/CSDK/main.cpp --- @@ -55,6 +57,56 @@ JNIEnv *initJVM() { return env; } +/** + * test read Schema from

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228410579 --- Diff: store/CSDK/Schema.cpp --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228410478 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java --- @@ -0,0 +1,233 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228409446 --- Diff: store/CSDK/main.cpp --- @@ -168,9 +220,51 @@ bool readFromS3(JNIEnv *env, char *argv[]) { printf(&qu

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228409346 --- Diff: store/CSDK/main.cpp --- @@ -168,9 +220,51 @@ bool readFromS3(JNIEnv *env, char *argv[]) { printf(&qu

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228409246 --- Diff: store/CSDK/main.cpp --- @@ -168,9 +220,51 @@ bool readFromS3(JNIEnv *env, char *argv[]) { printf(&qu

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228409221 --- Diff: store/CSDK/main.cpp --- @@ -55,6 +57,56 @@ JNIEnv *initJVM() { return env; } +/** + * test read Schema from

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228407125 --- Diff: store/CSDK/CarbonSchemaReader.cpp --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228406995 --- Diff: store/CSDK/CarbonSchemaReader.cpp --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2807: [CARBONDATA-2997] Support read schema from in...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2807#discussion_r228406676 --- Diff: docs/CSDK-guide.md --- @@ -126,12 +126,39 @@ bool readFromS3(JNIEnv *env, char *argv[]) { reader.close(); } -// 3

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228221442 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -90,6 +91,18 @@ public T readNextRow() throws

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228220014 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1723,4 +1723,93 @@ public void

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228214955 --- Diff: store/CSDK/main.cpp --- @@ -224,8 +406,81 @@ bool readFromS3(JNIEnv *env, char *argv[]) { printf("

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228213436 --- Diff: store/CSDK/main.cpp --- @@ -99,21 +102,187 @@ bool readFromLocalWithoutProjection(JNIEnv *env) { printf("

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228209499 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -74,27 +75,41 @@ jobject CarbonReader::withHadoopConf(char *key, char *value) { return

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228206123 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -74,27 +75,41 @@ jobject CarbonReader::withHadoopConf(char *key, char *value) { return

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228202864 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java --- @@ -116,6 +116,20 @@ public void initialize(InputSplit

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228191657 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/benchmark/SDKReaderBenchmark.java --- @@ -0,0 +1,262 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228183334 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/RowBatch.java --- @@ -100,4 +100,24 @@ public int getSize() { counter

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228156985 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1616,7 +1616,6 @@ public boolean accept(File dir

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228130454 --- Diff: store/CSDK/src/CarbonReader.cpp --- @@ -79,21 +78,19 @@ jobject CarbonReader::build() { jmethodID buildID = jniEnv->GetMetho

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228128521 --- Diff: store/CSDK/src/CarbonReader.cpp --- @@ -79,21 +78,19 @@ jobject CarbonReader::build() { jmethodID buildID = jniEnv->GetMetho

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228126086 --- Diff: store/CSDK/src/CarbonReader.h --- @@ -35,6 +40,13 @@ class CarbonReader { */ jobject carbonReaderObject

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228124647 --- Diff: store/CSDK/src/CarbonReader.cpp --- @@ -19,15 +19,14 @@ #include jobject CarbonReader::builder(JNIEnv *env, char *path

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228074939 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -19,15 +19,14 @@ #include jobject CarbonReader::builder(JNIEnv *env, char *path, char

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228056225 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228055673 --- Diff: store/CSDK/main.cpp --- @@ -21,6 +21,7 @@ #include --- End diff -- we just have to create a folder and move this file

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228056749 --- Diff: docs/csdk-guide.md --- @@ -30,106 +30,13 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228055937 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228054034 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -38,9 +37,9 @@ jobject CarbonReader::builder(JNIEnv *env, char *path) { jclass

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228053433 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -19,15 +19,14 @@ #include jobject CarbonReader::builder(JNIEnv *env, char *path, char

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228044190 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228041857 --- Diff: store/CSDK/main.cpp --- @@ -21,6 +21,7 @@ #include --- End diff -- Can we move this to test ? because this is not a

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228040809 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1522,4 +1522,208 @@ public boolean accept(File dir

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228040609 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/RowUtil.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228039418 --- Diff: docs/csdk-guide.md --- @@ -68,20 +68,42 @@ JNIEnv *initJVM() { bool readFromLocalWithoutProjection(JNIEnv *env

[GitHub] carbondata pull request #2814: [WIP][CARBONDATA-3001] configurable page size...

2018-10-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2814#discussion_r227667228 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java --- @@ -221,50 +224,106 @@ public

[GitHub] carbondata issue #2812: [CARBONDATA-3004][32k] Fix bugs in writing dataframe...

2018-10-18 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2812 LGTM ---

[GitHub] carbondata pull request #2814: [WIP][CARBONDATA-3001] configurable page size...

2018-10-15 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2814 [WIP][CARBONDATA-3001] configurable page size in MB NA Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily

[jira] [Updated] (CARBONDATA-3001) Propose configurable page size in MB (via carbon property)

2018-10-11 Thread Ajantha Bhat (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-3001: - Attachment: Propose configurable page size in MB (via carbon property).pdf

[jira] [Created] (CARBONDATA-3001) Propose configurable page size in MB (via carbon property)

2018-10-10 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3001: Summary: Propose configurable page size in MB (via carbon property) Key: CARBONDATA-3001 URL: https://issues.apache.org/jira/browse/CARBONDATA-3001 Project

[GitHub] carbondata issue #2809: [HOTFIX] Fix SDV test case failure after PR #2645

2018-10-10 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2809 @ravipesala , @jackylk : please check ---

[GitHub] carbondata pull request #2809: [HOTFIX] Fix SDV test case failure after PR #...

2018-10-10 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2809 [HOTFIX] Fix SDV test case failure after PR #2645 **Changes: 1) #2645 has blocked the schema for external table. But SDV test cases were not updated. Hence updated the test cases

[GitHub] carbondata pull request #2790: [HOTFIX] carbon reader support open another r...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2790#discussion_r221415694 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -115,11 +115,13 @@ public CarbonReaderBuilder

[GitHub] carbondata issue #2784: [CARBONDATA-2987] Data mismatch after compaction wit...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2784 @ravipesala : PR is ready please check ---

[GitHub] carbondata pull request #2790: [HOTFIX] carbon reader support open another r...

2018-09-28 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2790 [HOTFIX] carbon reader support open another reader without closing previous reader [HOTFIX] carbon reader support open another reader without closing previous reader

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2780 LGTM except for minor test case comment by @KanakaKumar . ---

[GitHub] carbondata pull request #2784: [CARBONDATA-2987] Data mismatch after compact...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2784#discussion_r221261712 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -302,8 +311,19 @@ public boolean

[GitHub] carbondata issue #2784: [CARBONDATA-2987] Data mismatch after compaction wit...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2784 @jackylk : No this issue introduce only in this version (1.5) after adaptive encoding of primitive type changes. Previously column page wrapper was only for complex columns, this

[GitHub] carbondata pull request #2784: [CARBONDATA-2987] Data mismatch after compact...

2018-09-28 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2784 [CARBONDATA-2987] Data mismatch after compaction with measure sort columns problem: Data mismatch after compaction with measure sort columns root cause : In compaction flow

[jira] [Created] (CARBONDATA-2987) Data mismatch after compaction with measure sort columns

2018-09-28 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-2987: Summary: Data mismatch after compaction with measure sort columns Key: CARBONDATA-2987 URL: https://issues.apache.org/jira/browse/CARBONDATA-2987 Project

[GitHub] carbondata issue #2697: [HOTFIX] support "carbon.load.directWriteHdfs.enable...

2018-09-26 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2697 @kunal642 and @KanakaKumar : This PR is ready. please check. ---

[GitHub] carbondata issue #2697: [HOTFIX] support "carbon.load.directWriteHdfs.enable...

2018-09-26 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2697 retest this please ---

[GitHub] carbondata issue #2763: [HOTFIX] fix compile error after merging PR-2749

2018-09-26 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2763 @zzcclp : Also I don't think fixing just this compilation error is enough, because still this module has find-bugs issues also. Example: at DataSummary.java:[lin

[GitHub] carbondata issue #2749: [CARBONDATA-2961] Simplify SDK API interfaces

2018-09-25 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2749 This PR is already merged in master. But PR ID in the master commit log is not proper (mentioned JIRA ID instead of PR ID) Hence PR was not closed automatically. So, manually

[GitHub] carbondata pull request #2749: [CARBONDATA-2961] Simplify SDK API interfaces

2018-09-25 Thread ajantha-bhat
Github user ajantha-bhat closed the pull request at: https://github.com/apache/carbondata/pull/2749 ---

[GitHub] carbondata issue #2763: [HOTFIX] fix compile error after merging PR-2749

2018-09-25 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2763 @zzcclp : Changes are OK. Why this problem is not catching in PR builder and local maven build ? How to find this type of problems ? ---

[GitHub] carbondata issue #2749: [CARBONDATA-2961] Simplify SDK API interfaces

2018-09-24 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2749 @ravipesala: PR is ready. Please check ---

[GitHub] carbondata issue #2739: [CARBONDATA-2954]Fix error when create external tabl...

2018-09-24 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2739 LGTM ---

[GitHub] carbondata issue #2749: [CARBONDATA-2961] Simplify SDK API interfaces

2018-09-24 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2749 retest this please ---

[jira] [Updated] (CARBONDATA-2961) Simplify SDK API interfaces

2018-09-24 Thread Ajantha Bhat (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-2961: - Description: CARBONDATA-2961 Simplify SDK API interfaces problem: current SDK API

[GitHub] carbondata pull request #2747: [CARBONDATA-2960] SDK Reader fix with project...

2018-09-24 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2747#discussion_r219758599 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable

[jira] [Updated] (CARBONDATA-2961) Simplify SDK API interfaces

2018-09-24 Thread Ajantha Bhat (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-2961: - Description: [CARBONDATA-2961] Simplify SDK API interfaces problem: current SDK

<    1   2   3   4   5   6   7   8   9   10   >