[
https://issues.apache.org/jira/browse/CARBONDATA-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ajantha Bhat updated CARBONDATA-2961:
-
Description:
Added:
public CarbonWriterBuilder withThreadSafe(short numOfThreads
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2749#discussion_r219732821
--- Diff: docs/sdk-guide.md ---
@@ -377,91 +366,69 @@ public CarbonWriterBuilder
withLoadOptions(Map options);
public CarbonWriterBuilder
Ajantha Bhat created CARBONDATA-2961:
Summary: Simplify SDK API interfaces
Key: CARBONDATA-2961
URL: https://issues.apache.org/jira/browse/CARBONDATA-2961
Project: CarbonData
Issue Type
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2749
[WIP] simplify SDK API interfaces
[WIP] simplify SDK API interfaces
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2739#discussion_r219531131
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2226,7 +2226,11 @@ public static String
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2733
@chenliang613 : All presto test case failed because of de-serialization
error from antlr jar.
In the pom.xml of presto db master code.
https://github.com/prestodb/presto/blob
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2706
@ravipesala : PR is ready please review
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2706
retest this please
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218474623
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -239,6 +239,7 @@ public void
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218403232
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -239,6 +239,7 @@ public void
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2706
@ravipesala : PR is ready. Please check.
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218047331
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/ReUsableByteArrayDataOutputStream.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r218047291
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/ReUsableByteArrayDataOutputStream.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2722
@zzcclp : LGTM and Thank you.
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2706
@kumarvishal09 @ravipesala : please do in-depth review for this PR. impact
is more.
---
Ajantha Bhat created CARBONDATA-2927:
Summary: Multiple issue fixes for varchar column and complex
columns that grows more than 2MB
Key: CARBONDATA-2927
URL: https://issues.apache.org/jira/browse/CARBONDATA
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2705#discussion_r216634097
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java ---
@@ -36,6 +37,14 @@
private DimensionSpec
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r216555115
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -165,14 +165,15 @@ private static boolean
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2704
@ravipesala : will it be better if we convert schema to lowercase just
after inferring ?
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2705
@ravipesala : please review
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2706
[WIP] multiple issue fixes for varchar column and complex columns, row that
grows more than 2MB
**[WIP] multiple issue fixes for varchar column and complex columns that
grows more than
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2705
[CARBONDATA-2926] fixed ArrayIndexOutOfBoundException with varchar columns
and empty sort_columns
problem:
ArrayIndexOutOfBoundException if varchar column is present before
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2703#discussion_r216413274
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDetailInfo.java
---
@@ -51,7 +51,8 @@
private short
Ajantha Bhat created CARBONDATA-2926:
Summary: ArrayIndexOutOfBoundException if varchar column is
present before dictionary columns along with empty sort_columns.
Key: CARBONDATA-2926
URL: https
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2703#discussion_r216412941
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/TestCreateTableUsingSparkCarbonFileFormat.scala
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2703#discussion_r216412232
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/TestCreateTableUsingSparkCarbonFileFormat.scala
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2697
@KanakaKumar : Please confirm whether changing property has impact on
existing users ?
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2697
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2690
@ravipesala : PR is ready, please review
---
Ajantha Bhat created CARBONDATA-2922:
Summary: support long string columns with spark FileFormat and SDK
with "long_string_columns" TableProperties
Key: CARBONDATA-2922
URL: https://issues.apach
[
https://issues.apache.org/jira/browse/CARBONDATA-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ajantha Bhat closed CARBONDATA-2921.
Resolution: Duplicate
> support long string columns with spark FileFormat and
Ajantha Bhat created CARBONDATA-2921:
Summary: support long string columns with spark FileFormat and SDK
with "long_string_columns" TableProperties
Key: CARBONDATA-2921
URL: https://issues.apach
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2697
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2697
retest this please
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2697#discussion_r216040613
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -225,7 +225,7 @@ protected
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2692
@ravipesala : OK. removed empty lines.
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215861658
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -59,7 +59,6 @@
optionsFinal.put
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215861623
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java
---
@@ -62,6 +62,7 @@
/* Number of
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2690
@ravipesala : As per the discussion, sdk and spark file format uses varchar
instead of string now . so, code changed again. please review again.
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2692
@ravipesala : All comments are handled. please check.
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215634003
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -311,15 +326,15 @@ public CarbonWriterBuilder
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215628732
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -183,7 +184,6
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215628606
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -59,7 +59,8 @@
optionsFinal.put
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2697
@KanakaKumar : please check this. do we need to change property name ? what
if existing user using it ?
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2697
[WIP] support "carbon.load.directWriteHdfs.enabled" for S3
**problem** : Currently for s3, when the above carbon property is set.
index file will not be written in the s3 stor
[
https://issues.apache.org/jira/browse/CARBONDATA-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604297#comment-16604297
]
Ajantha Bhat commented on CARBONDATA-2918:
--
https://github.com/ap
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2692
retest this please
---
Ajantha Bhat created CARBONDATA-2918:
Summary: NPE If SDK sort column is not same case as schema
Key: CARBONDATA-2918
URL: https://issues.apache.org/jira/browse/CARBONDATA-2918
Project: CarbonData
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r214952432
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
---
@@ -59,7 +59,7 @@
optionsFinal.put
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r214951956
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -265,12 +262,20 @@ public CarbonWriterBuilder
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r214945032
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2692
@xuchuanyin : Already gone through all the load options and decided to
support 9 options. This sort scope was a create table property. This we were
not supporting. Now we are supporting
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2652
Handled in #2692, please clcose this PR
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2692
[CARBONDATA-2879] support sort scope for sdk
**problem:**: SDK doesn't support batch sort and no sort as we don't have
any API support for sort scope
**Solution*
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2652#discussion_r214845435
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -259,14 +259,23 @@ public CarbonWriterBuilder
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2652#discussion_r214844517
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -246,8 +246,8 @@ public CarbonWriterBuilder
[
https://issues.apache.org/jira/browse/CARBONDATA-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ajantha Bhat updated CARBONDATA-2913:
-
Attachment: image-2018-09-04-14-19-00-708.png
> BufferOverflowException when
[
https://issues.apache.org/jira/browse/CARBONDATA-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602772#comment-16602772
]
Ajantha Bhat commented on CARBONDATA-2913:
--
!image-2018-09-04-14-19-00
Ajantha Bhat created CARBONDATA-2913:
Summary: BufferOverflowException when use varchar data of length
1000
Key: CARBONDATA-2913
URL: https://issues.apache.org/jira/browse/CARBONDATA-2913
[
https://issues.apache.org/jira/browse/CARBONDATA-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602759#comment-16602759
]
Ajantha Bhat commented on CARBONDATA-
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2690
@ravipesala : please reveiw
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2690
[HOTFIX] support long string columns with spark FileFormat
**problem:** Exception if we try long string column for Spark file format
**Solution:** For Varchar data type
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2675#discussion_r214546428
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
---
@@ -188,13 +197,19 @@ public
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2675#discussion_r214546377
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
---
@@ -140,19 +143,25 @@ public
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2675#discussion_r214546342
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
---
@@ -127,8 +127,11 @@ public
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2672#discussion_r214546012
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -460,27 +461,32 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2672#discussion_r214509623
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -460,27 +461,32 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2672#discussion_r214318648
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepWithNoConverterImpl.java
---
@@ -64,10 +63,13
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2672#discussion_r214314596
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -460,27 +461,29 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2672#discussion_r214314587
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -460,27 +461,29 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2672#discussion_r214313919
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -460,27 +461,29 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2675#discussion_r214306748
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
---
@@ -140,19 +143,25 @@ public
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2664
@jackylk : Query result count is more than actual rows in this scenario as
same sort_temp file is referred in multiple batches. Say If the CSV rows count
is 2million, Query output is more
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2675
@kumarvishal09 , @ravipesala : please review
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2675
[CARBONDATA-2901] Fixed JVM crash in Load scenario when unsafe memory
allocation is failed.
Problem: Jvm crash in Load scenario when unsafe memory allocation is failed.
scenario
Ajantha Bhat created CARBONDATA-2901:
Summary: Problem: Jvm crash in Load scenario when unsafe memory
allocation is failed.
Key: CARBONDATA-2901
URL: https://issues.apache.org/jira/browse/CARBONDATA-2901
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2664
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2664
@xuchuanyin : Sort_column_bounds is used only for localsort. This
configuration is not used for Batch_sort. So I can fill batch ID in range field.
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2664
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2672
@gvramana , @ravipesala please review
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2672
[HOTFIX] improve sdk multi-thread performance
changes in this PR: currently writing rows to each writer iterator doesn't
happen concurrently. This also can be made concurrently.
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2664#discussion_r213594537
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/UnsafeBatchParallelReadMergeSorterImpl.java
---
@@ -62,12
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2664#discussion_r213593256
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/UnsafeBatchParallelReadMergeSorterImpl.java
---
@@ -62,12
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2664
@jackylk , @ravipesala : Please review
---
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2664
[CARBONDATA-2895] Fix Query result mismatch with Batch-sort in save to disk
(sort temp files) scenario.
**probelm:** Query result mismatch with Batch-sort in save to disk (sort
temp
Ajantha Bhat created CARBONDATA-2895:
Summary: [Batch-sort]Query result mismatch with Batch-sort in save
to disk (sort temp files) scenario.
Key: CARBONDATA-2895
URL: https://issues.apache.org/jira/browse
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2653
@ravipesala : PR is ready. Please check
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2653
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2659
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2653
retest this please
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2653
@ravipesala : Fixed all the comments please review
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2653#discussion_r212600140
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -434,4 +477,61 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2653#discussion_r212600099
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -434,4 +477,61 @@ public CarbonLoadModel
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2651#discussion_r212589476
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -272,6 +272,56 @@ public CarbonWriterBuilder
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2653
@ravipesala : PR is ready. please check
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2646
closing this. As we handle this in different way in PR #2653
---
Github user ajantha-bhat closed the pull request at:
https://github.com/apache/carbondata/pull/2646
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2653#discussion_r212542081
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -339,6 +339,28 @@ public CarbonWriter
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2653#discussion_r212542105
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -360,6 +382,33 @@ public CarbonWriter
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2653#discussion_r212540287
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -434,4 +477,61 @@ public CarbonLoadModel
601 - 700 of 1044 matches
Mail list logo
