[GitHub] carbondata pull request #1193: [CARBONDATA-1327] Add carbon sort column exam...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1193#discussion_r129509969 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSortColumnsExample.scala --- @@ -0,0 +1,126

[GitHub] carbondata pull request #1193: [CARBONDATA-1327] Add carbon sort column exam...

2017-07-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1193#discussion_r129508099 --- Diff: docs/ddl-operation-on-carbondata.md --- @@ -101,6 +101,14 @@ The following DDL operations are supported in CarbonData

[GitHub] carbondata issue #1192: [CARBONDATA-940] alter table add/split partition for...

2017-07-23 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1192 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1186: [CARBONDATA-1310]Merge test code for AddColumnTestCa...

2017-07-22 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1186 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1173: [CARBONDATA-1209] add partitionId in show partition ...

2017-07-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1183: [CARBONDATA-1312] fix list partition compare issue

2017-07-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1183 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1186: [CARBONDATA-1310]Merge test code for AddColum...

2017-07-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1186#discussion_r128705965 --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AddColumnTestCases.scala --- @@ -42,91 +43,263

[GitHub] carbondata issue #1186: [CARBONDATA-1310]Merge test code for AddColumnTestCa...

2017-07-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1186 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128560327 --- Diff: integration/spark-common-test/src/test/scala/org/apache/spark/util/SparkUtil4Test.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128558208 --- Diff: integration/spark-common-test/src/test/resources/multi_dir/data.csv --- @@ -0,0 +1,10 @@ +1,name1 +2,name2 --- End diff

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128556528 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/UnsafeSortDataRows.java --- @@ -345,9 +350,12 @@ public

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128555999 --- Diff: docs/useful-tips-on-carbondata.md --- @@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the configurations impacting

[GitHub] carbondata pull request #1186: [WIP]Merge test code for AddColumnTestCases, ...

2017-07-19 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1186#discussion_r128239341 --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AddColumnTestCases.scala --- @@ -42,26 +43,55

[GitHub] carbondata issue #1177: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-18 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1177 @xuchuanyin Thanks for your very good PR. A couple comments: 1. How to enable this feature(how to use), please consider updating the related document accordingly 2. Please

[GitHub] carbondata pull request #1177: [CARBONDATA-1281] Support multiple temp dirs ...

2017-07-18 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1177#discussion_r128147381 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1308,6 +1308,18 @@ public static

[GitHub] carbondata pull request #1184: [CARBONDATA-1314] Fix scalatest issues

2017-07-18 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1184 [CARBONDATA-1314] Fix scalatest issues Fix scalatest issues, as below : Error:(238, 16) can't expand macros compiled by previous versions of Scala assert(false) You can

[GitHub] carbondata issue #1175: [CARBONDATA-1281] Support multiple temp dirs for wri...

2017-07-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1175 @xuchuanyin please squash all commits to one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1154: [CARBONDATA-1285] resolved compilation error in hive...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1154 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1170: [CARBONDATA-1219] Documentation - not supported high...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1170 @sgururajshetty please review it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #791: [CARBONDATA-920] Updated useful-tips-on-carbondata.md

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/791 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1159: [CARBONDATA-1274] Adds example for update and delete...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1159: [CARBONDATA-1274] Adds example for update and delete...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #912: [CARBONDATA-1048] Updated Hive Guide

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/912 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1154: [CARBONDATA-1285] resolved compilation error in hive...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1154 I tested it , got the below log msg : 2017-07-13 14:45:59 WARN ShellBasedUnixGroupsMapping:86 - got exception trying to get groups for user anonymous org.apache.hadoop.util.Shell

[GitHub] carbondata pull request #1154: [CARBONDATA-1285] resolved compilation error ...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1154#discussion_r127138413 --- Diff: integration/hive/pom.xml --- @@ -94,6 +94,21 @@ +org.apache.hive

[GitHub] carbondata issue #994: [CARBONDATA-933]Added Compare Test For BenchMarking O...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/994 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1156: [CARBONDATA-1279] Push down for queries like "%xxx" ...

2017-07-13 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1156 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1154: [CARBONDATA-1285] resolved compilation error in hive...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1154 @anubhav100 i cam compile successfully on current master. so this pr is for fixing compilation issues or HiveExample issues ? --- If your project is set up for it, you can reply

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127114360 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127112410 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127112225 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] Adds example for update and...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r127111519 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,173

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1142 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1159: [CARBONDATA-1274] Adds example for update and delete...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 @mayunSaicmotor In the future, to avoid conflict , please assign JIRA to yourself if you plan to work on this PR. @anubhav100 my side is very appreciating your effort, thanks for your

[GitHub] carbondata issue #1140: [CARBONDATA-1219] Remove high.cardinality.row.count....

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1140 please solve the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #1156: [CARBONDATA-1279] Push down for some select queries ...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1156 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1162#discussion_r126872536 --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

2017-07-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1162#discussion_r126872523 --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/Spark2QueryTest.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed

[GitHub] carbondata issue #1159: [CARBONDATA-1274] added example for update and delet...

2017-07-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1159 @mayunSaicmotor Please change PR title to : Adds example for update and delete with Spark 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] carbondata pull request #1159: [CARBONDATA-1274] added example for update an...

2017-07-11 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1159#discussion_r126856684 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,183

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1142 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1162: [CARBONDATA-1295] Optimize test cases,merge t...

2017-07-11 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1162 [CARBONDATA-1295] Optimize test cases,merge three QueryTest class into one Optimize test cases,merge three QueryTest class into one, and update related code. You can merge this pull

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-10 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1142 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1151: fix doc

2017-07-08 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1151 fix doc fix doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/carbondata patch-3 Alternatively you can review

[GitHub] carbondata pull request #1150: [CARBONDATA-1280] Solve HiveExample dependenc...

2017-07-08 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1150 [CARBONDATA-1280] Solve HiveExample dependency issues and fix spark 1.6 CI Solve HiveExample dependency issues and fix spark 1.6 CI You can merge this pull request into a Git repository

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126274038 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java --- @@ -0,0 +1,288

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126273765 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -111,58 +108,46 @@ private void initialize

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126273657 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -444,9 +444,14 @@ protected Expression

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126070302 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java --- @@ -0,0 +1,288

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126070269 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/DictionaryDecodeReadSupport.java --- @@ -0,0 +1,288

[GitHub] carbondata pull request #1142: [CARBONDATA-1271] Enhanced Performance for Hi...

2017-07-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1142#discussion_r126056257 --- Diff: core/src/main/java/org/apache/carbondata/core/stats/QueryStatisticsRecorderImpl.java --- @@ -101,45 +101,47 @@ public String

[GitHub] carbondata issue #967: [CARBONDATA-1096] resolved bug for timetstamp type sh...

2017-07-06 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/967 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1139: [CARBONDATA-1267] Add short_int case branch in delta...

2017-07-05 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1139 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #962: Only for test ci(vacuous PR-don't merge)

2017-07-05 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/carbondata/pull/962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1129: [CARBONDATA-1259] CompareTest improvement

2017-07-05 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1129 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1129: [CARBONDATA-1259] CompareTest improvement

2017-07-04 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1129 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1127: [CARBONDATA-1255]-updated "ddl-operation-on-carbonda...

2017-07-04 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1127 Please find the mailing list discussion : http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/About-ColumnGroup-feature-td14436.html --- If your project is set up

[GitHub] carbondata issue #1131: [CARBONDATA-1244] Polish docs and comments in presto...

2017-07-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1131 @HoneyQuery Thanks for your good contribution. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1128: [CARBONDATA-980] Fix for Is Not Null in presto

2017-07-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1128 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1127: [CARBONDATA-1255]-updated "ddl-operation-on-carbonda...

2017-07-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1127 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause In Prest...

2017-07-03 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1062 @jatin9896 Thanks for you worked on this PR. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause In Prest...

2017-07-02 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1062 @jatin9896 For this PR, please do the minimal change which only is for fixing this issue. please don't change other part code. --- If your project is set up for it, you can reply

[GitHub] carbondata pull request #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause I...

2017-07-02 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1062#discussion_r125202618 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java --- @@ -142,13 +142,14 @@ private void

[GitHub] carbondata issue #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause In Prest...

2017-07-02 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1062 @jatin9896 i verified your PR, looks ok. can you explain why remove data/timestamp code ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] carbondata pull request #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause I...

2017-07-02 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1062#discussion_r125186117 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSetProvider.java --- @@ -181,29 +182,25 @@ private void

[GitHub] carbondata issue #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause In Prest...

2017-07-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1062 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1062: [CARBONDATA-982] Fixed Bug For NotIn Clause In Prest...

2017-07-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1062 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1017: [CARBONDATA-1105] remove spark.version in submodule

2017-07-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1017 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1017: [CARBONDATA-1105] support spark 2.1.1

2017-06-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1017 @cenyuhai 1.Formally support spark 2.1.1 integration, need have a discussion and vote in dev mailing list. 2.For your PR, please first fix this issue: currently in example

[GitHub] carbondata pull request #1112: [CARBONDATA-1244] Rewrite README.md of presto...

2017-06-29 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1112#discussion_r124933020 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -520,7 +626,7 @@ private boolean

[GitHub] carbondata issue #1119: [CarbonData-1205] change default partition id from M...

2017-06-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1119 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1112: [CARBONDATA-1244] Rewrite README.md of presto integr...

2017-06-29 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1112 @HoneyQuery please squash all commits into one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata pull request #1112: [CARBONDATA-1244] Rewrite README.md of presto...

2017-06-29 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1112#discussion_r124811689 --- Diff: integration/presto/README.md --- @@ -20,14 +20,10 @@ Please follow the below steps to query carbondata in presto

[GitHub] carbondata pull request #1112: [CARBONDATA-1244] Rewrite README.md of presto...

2017-06-29 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1112#discussion_r124811082 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java --- @@ -17,19 +17,22

[GitHub] carbondata issue #1110: [CARBONDATA-1238] Decouple the datatype convert in c...

2017-06-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1110 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1064: [CARBONDATA-<1173>] Stream ingestion - write path fr...

2017-06-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1064 please update some comment format. everything LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata pull request #1064: [CARBONDATA-<1173>] Stream ingestion - write ...

2017-06-26 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1064#discussion_r124168973 --- Diff: core/src/main/java/org/apache/carbondata/core/streaming/CarbonStreamingMetaStoreImpl.java --- @@ -0,0 +1,55 @@ +/* + * Licensed

[GitHub] carbondata issue #1064: [CARBONDATA-<1173>] Stream ingestion - write path fr...

2017-06-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1064 @aniketadnaik can you change the PR title to : [CARBONDATA-1173] Stream ingestion - write path framework --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #1086: [CARBONDATA-1222] Residual files created from Update...

2017-06-24 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1086 Can you list, which residual files were generated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1078: [CARBONDATA-1214]changing the delete syntax as in th...

2017-06-24 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1078 @ravikiran23 please update all documents accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata pull request #1075: [WIP] Datamap implementation for Blocklet.

2017-06-24 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1075#discussion_r123874719 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java --- @@ -0,0 +1,207 @@ +/* + * Licensed

[GitHub] carbondata pull request #1075: [WIP] Datamap implementation for Blocklet.

2017-06-24 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1075#discussion_r123874656 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/AbstractTableDataMap.java --- @@ -26,28 +27,28 @@ * DataMap at the table

[GitHub] carbondata pull request #1090: Update hive-guide.md

2017-06-24 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1090 Update hive-guide.md Correct some invalid steps. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/carbondata patch-2

[GitHub] carbondata issue #1081: [CARBONDATA-1081]adding libthrift dependency

2017-06-23 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1081 @sehriff Two comments: 1. The pull request's JIRA number is wrong([CARBONDATA-1081]), please double check it. 2. The libthrift dependency has been added to format module

[GitHub] carbondata issue #1033: spark2/CarbonSQLCLIDriver.scala storePath is not hdf...

2017-06-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1033 @rusonding can you correct this PR or close it then report a new PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] carbondata issue #1042: [CARBONDATA-1181] Show partitions

2017-06-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1042 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1049: [CARBONDATA-1183] Update CarbonPartitionExample beca...

2017-06-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1049 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1066: [CARBONDATA-1197] Update related docs which s...

2017-06-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1066#discussion_r123413348 --- Diff: docs/installation-guide.md --- @@ -150,7 +150,7 @@ $SPARK_HOME/carbonlib/$CARBON_ASSEMBLY_JAR | Parameter | Description

[GitHub] carbondata issue #1021: [CARBONDATA-1158] Hive integration code optimization

2017-06-21 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1021 @anubhav100 thanks , fix comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata issue #1052: [CARBONDATA-1182] Resolved packaging issue in presto...

2017-06-19 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1052 @geetikagupta16 yes, now i can reproduce it, thanks. Can you compile it based on parent pom.xml, see if can reproduce it also ? --- If your project is set up for it, you can reply

[GitHub] carbondata issue #1060: [CARBONDATA-1191] Remove carbon-spark-shell script

2017-06-19 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1060 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1057: [CARBONDATA-1187]Fixed linking and content issues

2017-06-19 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1057 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1052: [CARBONDATA-1182] Resolved packaging issue in presto...

2017-06-19 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1052 @geetikagupta16 Please verify this issue whether is valid, or not ? i can't reproduce it at my local machine with "mvn package for integration/presto/pom.xml" --- If yo

[GitHub] carbondata issue #1033: spark2/CarbonSQLCLIDriver.scala storePath is not hdf...

2017-06-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1033 @rusonding your PR has problem, please rebase to the latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] carbondata issue #1015: [CARBONDATA-1151] Update useful-tips-on-carbondata.m...

2017-06-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1015 @chenerlu please squash into one commit, and update the commit name "Create useful-tips-on-carbondata.md" --- If your project is set up for it, you can reply to this email and

[GitHub] carbondata issue #1015: [CARBONDATA-1151] Update useful-tips-on-carbondata.m...

2017-06-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1015 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1021: [CARBONDATA-1158] Hive integration code optim...

2017-06-12 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/carbondata/pull/1021 [CARBONDATA-1158] Hive integration code optimization Hive integration code optimization: 1. Remove redundant and unused code. 2. Optimize some code: a) Convert some internal

[GitHub] carbondata issue #959: [CARBONDATA-1053] supported char Type for hive

2017-06-08 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/959 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #959: [CARBONDATA-1053] supported char Type for hive

2017-06-08 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/959 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #975: [Documentation] Single pass condition for high cardin...

2017-06-06 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/975 @QiangCai please review this PR, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

<    2   3   4   5   6   7   8   >