[GitHub] carbondata pull request #1767: [CARBONDATA-1993] Carbon properties default v...

2018-01-30 Thread pawanmalwal
Github user pawanmalwal closed the pull request at: https://github.com/apache/carbondata/pull/1767 ---

[GitHub] carbondata pull request #1767: [CARBONDATA-1993] Carbon properties default v...

2018-01-08 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1767#discussion_r160114212 --- Diff: conf/carbon.properties.template --- @@ -20,7 +20,7 @@ #Mandatory. Carbon Store path carbon.storelocation=hdfs://hacluster/Opt

[GitHub] carbondata pull request #1775: [CARBONDATA-1993] Removed unused carbon prope...

2018-01-08 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1775 [CARBONDATA-1993] Removed unused carbon properties high.cardinality.identify… Removed carbon properties high.cardinality.identify.enable and high.cardinality.threshold Be sure

[GitHub] carbondata pull request #1767: [CARBONDATA-1993] Carbon properties default v...

2018-01-05 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1767 [CARBONDATA-1993] Carbon properties default values fix and correspond… Carbon properties default values fix and corresponding template and document correction. - [X] Any

[GitHub] carbondata issue #1696: [CARBONDATA-1884] SDV test cases for CTAS support to...

2017-12-21 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1696 retest sdv please ---

[GitHub] carbondata pull request #1696: [CARBONDATA-1884] SDV test cases for CTAS sup...

2017-12-20 Thread pawanmalwal
Github user pawanmalwal closed the pull request at: https://github.com/apache/carbondata/pull/1696 ---

[GitHub] carbondata pull request #1696: [CARBONDATA-1884] SDV test cases for CTAS sup...

2017-12-20 Thread pawanmalwal
GitHub user pawanmalwal reopened a pull request: https://github.com/apache/carbondata/pull/1696 [CARBONDATA-1884] SDV test cases for CTAS support to carbondata SDV test cases for CTAS support to carbondata. Be sure to do all of the following checklist to help us

[GitHub] carbondata pull request #1696: [CARBONDATA-1884] SDV test cases for CTAS sup...

2017-12-20 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1696 [CARBONDATA-1884] SDV test cases for CTAS support to carbondata SDV test cases for CTAS support to carbondata. Be sure to do all of the following checklist to help us incorporate

[GitHub] carbondata pull request #1656: [CARBONDATA-1247] Block pruning not working f...

2017-12-14 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1656#discussion_r156907109 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/CastExpressionOptimization.scala --- @@ -82,6 +109,21 @@ object

[GitHub] carbondata pull request #1656: [CARBONDATA-1247] Block pruning not working f...

2017-12-14 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1656#discussion_r156907140 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/CastExpressionOptimization.scala --- @@ -67,6 +68,32 @@ object

[GitHub] carbondata pull request #1656: [CARBONDATA-1247] Block pruning not working f...

2017-12-14 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1656#discussion_r156907084 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/CastExpressionOptimization.scala --- @@ -122,6 +164,13 @@ object

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

2017-12-13 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1281 Duplicate PR - univocity jar changes done in PR https://github.com/apache/carbondata/pull/1532 ---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

2017-12-13 Thread pawanmalwal
Github user pawanmalwal closed the pull request at: https://github.com/apache/carbondata/pull/1281 ---

[GitHub] carbondata pull request #1656: [CARBONDATA-1247] Block pruning not working f...

2017-12-13 Thread pawanmalwal
GitHub user pawanmalwal reopened a pull request: https://github.com/apache/carbondata/pull/1656 [CARBONDATA-1247] Block pruning not working for date type column Block pruning not working for date type column. Root Cause : Type casting of String for DateType is not handled

[GitHub] carbondata pull request #1656: [CARBONDATA-1247] Block pruning not working f...

2017-12-13 Thread pawanmalwal
Github user pawanmalwal closed the pull request at: https://github.com/apache/carbondata/pull/1656 ---

[GitHub] carbondata pull request #1656: [CARBONDATA-1887] Block pruning not working f...

2017-12-13 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1656 [CARBONDATA-1887] Block pruning not working for date type column Block pruning not working for date type column. Root Cause : Type casting of String for DateType is not handled

[GitHub] carbondata pull request #1612: [CARBONDATA-1618] SDV test cases for Table co...

2017-12-05 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1612#discussion_r154995762 --- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/TableCommentAlterTableTestCase.scala

[GitHub] carbondata issue #1612: [CARBONDATA-1618] SDV test cases for Table comment s...

2017-12-05 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1612 retest this please ---

[GitHub] carbondata pull request #1612: [CARBONDATA-1618] SDV test cases for Table co...

2017-12-05 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1612 [CARBONDATA-1618] SDV test cases for Table comment support for alter t… SDV test cases for Table comment support for alter table. Be sure to do all of the following checklist to

[GitHub] carbondata pull request #1371: [WIP][CARBONDATA-1440] Fixed fortify issues

2017-11-28 Thread pawanmalwal
Github user pawanmalwal closed the pull request at: https://github.com/apache/carbondata/pull/1371 ---

[GitHub] carbondata issue #1472: [CARBONDATA-1618]Table comment support for alter tab...

2017-11-08 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1472 @ravipesala I have resolved the conflict. Due to that SDV had failed I guess. ---

[GitHub] carbondata pull request #1472: [CARBONDATA-1618]Table comment support for al...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1472#discussion_r14959 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1374,6 +1374,12 @@ @CarbonProperty

[GitHub] carbondata pull request #1472: [CARBONDATA-1618]Table comment support for al...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1472#discussion_r149593291 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -317,4 +321,84 @@ object AlterTableUtil

[GitHub] carbondata pull request #1472: [CARBONDATA-1618]Table comment support for al...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1472#discussion_r149593267 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -317,4 +321,84 @@ object AlterTableUtil

[GitHub] carbondata pull request #1437: [CARBONDATA-1618] Fix issue of not support ta...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1437#discussion_r149586320 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -79,6 +79,9 @@ // this idenifier is a

[GitHub] carbondata pull request #1472: [WIP][CARBONDATA-1618]Table comment support f...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1472#discussion_r149585944 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableSetCommand.scala --- @@ -0,0 +1,108

[GitHub] carbondata pull request #1472: [WIP][CARBONDATA-1618]Table comment support f...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1472#discussion_r149586000 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDescribeFormattedCommand.scala --- @@ -105,6 +105,10

[GitHub] carbondata pull request #1472: [WIP][CARBONDATA-1618]Table comment support f...

2017-11-07 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1472#discussion_r149585846 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableSetCommand.scala --- @@ -0,0 +1,108

[GitHub] carbondata pull request #1472: [WIP][CARBONDATA-1618]Table comment support f...

2017-11-06 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1472 [WIP][CARBONDATA-1618]Table comment support for alter table Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [X

[GitHub] carbondata pull request #1371: [WIP][CARBONDATA-1440] Fixed fortify issues

2017-09-19 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1371 [WIP][CARBONDATA-1440] Fixed fortify issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/pawanmalwal/carbondata

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

2017-09-19 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1281 retest this please ---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

2017-09-14 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1281 retest this please ---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

2017-09-13 Thread pawanmalwal
GitHub user pawanmalwal reopened a pull request: https://github.com/apache/carbondata/pull/1281 [CARBONDATA-1326] Fixed findbug issue and univocity-parsers jar version to 2.2.1 Updated univocity-parsers jar version from 1.5.6 to 2.2.1 in processing/pom.xml and fixed one findbug

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

2017-09-13 Thread pawanmalwal
Github user pawanmalwal closed the pull request at: https://github.com/apache/carbondata/pull/1281 ---

[GitHub] carbondata issue #1281: [CARBONDATA-1326] Fixed findbug issue and univocity-...

2017-09-06 Thread pawanmalwal
Github user pawanmalwal commented on the issue: https://github.com/apache/carbondata/pull/1281 Yes thats right. This PR also has some code change to avoid 1 more string object creation in the same method and another chanage to update univocity-parsers jar version to 2.2.1 in

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

2017-08-24 Thread pawanmalwal
Github user pawanmalwal commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1281#discussion_r134990100 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java --- @@ -163,17 +163,17 @@ public

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

2017-08-22 Thread pawanmalwal
GitHub user pawanmalwal opened a pull request: https://github.com/apache/carbondata/pull/1281 [CARBONDATA-1326] Fixed findbug issue and univocity-parsers jar version to 2.2.1 Updated univocity-parsers jar version from 1.5.6 to 2.2.1 in processing/pom.xml and fixed one findbug