[GitHub] [carbondata] akashrn5 commented on a change in pull request #4106: [CARBONDATA-4147] Fix re-arrange schema in logical relation on MV partition table having sort column

[GitBox]

akashrn5 commented on a change in pull request #4106:
URL: https://github.com/apache/carbondata/pull/4106#discussion_r595752950



##########
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala
##########
@@ -181,7 +183,13 @@ case class CarbonInsertIntoCommand(databaseNameOp: 
Option[String],
       if (isNotReArranged) {
         // Re-arrange the catalog table schema and output for partition 
relation
         logicalPartitionRelation =
-          getReArrangedSchemaLogicalRelation(reArrangedIndex, 
logicalPartitionRelation)
+          if (carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.isMV) {
+            // For MV partition table, partition columns will be at the end. 
Re-arrange

Review comment:
       as discussed, please add a comment here with example, so reviewers and 
developers will be clear why only for MV we need to handle it separately




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org