[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245787 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245787 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537235165 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537232374 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230866 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -19,13 +19,13 @@ package

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

2020-12-06 Thread GitBox
vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230288 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void