[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2889 LGTM ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2889 ok. I think we do not need to change it now ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2889 @jackylk Do you want to change that to `debug`? Currently it is info level which is not in the scope of this PR since info log may always be logged and that concatenation is unavoidable. --

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2889 In `UnsafeMemoryManager:175`, there is a info log that requires constructing a string ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2889 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1421/ ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2889 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9470/ ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2889 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1206/ ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2889 retest this please ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2889 I think there is no need to add check for info level logs and the debug level logs in those class already have corresponding check. I think current logs in `UnsafeSortMemoryManager`

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2889 There is some frequent info log in `UnsafeSortMemoryManager`, can you also add if check for that ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2889 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1417/ ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2889 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9466/ ---

[GitHub] carbondata issue #2889: [CARBONDATA-3067] Add check for debug to avoid strin...

Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2889 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1202/ ---