[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 @ravipesala Thanks for your solution, PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/978 @watermen Thank you for giving reproduce steps, I can reproduce it. But the fix you have given is not right, This issue happens because of missing `semaphore.acquire()` in `finish` method.

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 @ravipesala You can reproduce this case by add some log and run loading sample.csv testcase(TestDataLoadWithFileName). It's hard to reproducer, so I add sleep in Producer to simulate the time

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/978 @watermen This fix is contradictory to the design of producer and consumer. The producer process the data and puts in holder in sequence and consumer takes the data in the same sequence.

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/978 We need make sure all pages of a blocklet are in the right order to be written to carbon data file. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 @kumarvishal09 It is very hard to write the testcase because this case is happened occasionally. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/978 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] carbondata issue #978: [CARBONDATA-1109] Cover the case when last page is no...

Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/978 @watermen Can u please add a testcase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat