[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1000 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-15 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r122179178 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,124 @@ +/* + *

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r122123190 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,124 @@ +/* + * Licensed

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r122116031 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,124 @@ +/* + *

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r122114396 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,124 @@ +/* + *

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121940029 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java --- @@ -0,0 +1,212 @@ +/* + * Licensed to

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121938987 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,150 @@ +/* + * Licensed

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121937358 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java --- @@ -0,0 +1,212 @@ +/* + * Licensed

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121934452 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,150 @@ +/* + *

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121934356 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,150 @@ +/* + *

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121933673 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,150 @@ +/* + * Licensed

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121932974 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java --- @@ -0,0 +1,150 @@ +/* + *

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121930195 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeColumnPage.java --- @@ -0,0 +1,321 @@ +/* + * Licensed to the

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121930114 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -323,15 +340,8 @@ public double getDouble(int rowId) {

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121928358 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -98,56 +117,54 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121928413 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -98,56 +117,54 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121876896 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -323,15 +340,8 @@ public double getDouble(int rowId) {

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121875823 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -508,7 +567,7 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-14 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121874665 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -98,56 +117,54 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-13 Thread chenerlu
Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121847432 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -508,7 +567,7 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-13 Thread chenerlu
Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121839529 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -98,56 +117,54 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-13 Thread chenerlu
Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121838660 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -98,56 +117,54 @@ public static ColumnPage

[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...

2017-06-13 Thread chenerlu
Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1000#discussion_r121838636 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -98,56 +117,54 @@ public static ColumnPage