[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126876373 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -266,26 +264,22 @@ private static AbsoluteTableIdentifier

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126878337 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -54,6 +53,12 @@ object CommonUtil {

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126875952 --- Diff: format/src/main/thrift/schema.thrift --- @@ -132,9 +132,12 @@ struct SchemaEvolution{ struct PartitionInfo{ 1: required list

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126876084 --- Diff: format/src/main/thrift/schema.thrift --- @@ -132,9 +132,12 @@ struct SchemaEvolution{ struct PartitionInfo{ 1: required list

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126874942 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java --- @@ -43,13 +44,30 @@ private List

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126873687 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java --- @@ -218,7 +218,11 @@

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126876119 --- Diff: format/src/main/thrift/schema.thrift --- @@ -132,9 +132,12 @@ struct SchemaEvolution{ struct PartitionInfo{ 1: required list

[GitHub] carbondata pull request #1125: [CARBONDATA-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126873790 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java --- @@ -218,7 +218,11 @@

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user lionelcao commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126062119 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java --- @@ -43,13 +44,30 @@ private List

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user lionelcao commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126062042 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java --- @@ -43,13 +44,30 @@ private List

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user lionelcao commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r126061892 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -417,18 +441,26 @@ protected Expression

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125954460 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java --- @@ -43,13 +44,30 @@ private List

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125957306 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -274,28 +275,27 @@ private static AbsoluteTableIdentifier

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125954839 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java --- @@ -229,35 +229,37 @@ public static BitSet

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125955225 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java --- @@ -229,35 +229,37 @@ public static BitSet

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125956098 --- Diff: core/src/main/java/org/apache/carbondata/core/util/comparator/Comparator.java --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125957701 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -274,28 +275,27 @@ private static AbsoluteTableIdentifier

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125955474 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java --- @@ -229,35 +229,37 @@ public static BitSet

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125960197 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -327,6 +327,29 @@ private static AbsoluteTableIdentifier

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125958721 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -417,18 +441,26 @@ protected Expression

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125954525 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java --- @@ -43,13 +44,30 @@ private List

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125954219 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java --- @@ -43,13 +44,30 @@ private List

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125428800 --- Diff: format/src/main/thrift/schema.thrift --- @@ -135,6 +135,9 @@ struct PartitionInfo{ 3: optional i32 num_partitions; // number of

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125427623 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -99,10 +98,6 @@ private Map

[GitHub] carbondata pull request #1125: [CarbonData-1250] Change default partition id...

Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125427240 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java --- @@ -219,6 +219,10 @@

[GitHub] carbondata pull request #1125: [CarbonData-1250] change default partition id...

Github user chenerlu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125319466 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/partition/RangePartitioner.java --- @@ -17,16 +17,17 @@ package

[GitHub] carbondata pull request #1125: [CarbonData-1250] change default partition id...

Github user lionelcao commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125304887 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java --- @@ -229,35 +229,37 @@ public static

[GitHub] carbondata pull request #1125: [CarbonData-1250] change default partition id...

Github user lionelcao commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125301153 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java --- @@ -219,6 +219,10 @@

[GitHub] carbondata pull request #1125: [CarbonData-1250] change default partition id...

Github user lionelcao commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1125#discussion_r125301950 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java --- @@ -219,6 +219,10 @@

[GitHub] carbondata pull request #1125: [CarbonData-1250] change default partition id...

GitHub user lionelcao opened a pull request: https://github.com/apache/carbondata/pull/1125 [CarbonData-1250] change default partition id & Add TaskId group in partitionInfo This PR change the default partition id from Max to 0 and add taskId management related code to support