Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1417
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1417#discussion_r147670204
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1862,9 +1863,31 @@ public static TableInfo
convertGsonToTableInfo(
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1417#discussion_r147670083
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
---
@@ -87,13 +88,6 @@
*/
private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1417#discussion_r147664880
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java
---
@@ -42,6 +42,16 @@
baseOffset = memo
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1417#discussion_r147639115
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
---
@@ -87,13 +88,6 @@
*/
priv
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1417#discussion_r147638842
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1862,9 +1863,31 @@ public static TableInfo
convertGsonToTableIn
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1417#discussion_r147632046
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java
---
@@ -42,6 +42,16 @@
baseOffset = m
