[GitHub] carbondata pull request #1613: [CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] ...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1613 ---

[GitHub] carbondata pull request #1613: [CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] ...

2017-12-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1613#discussion_r155249189 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -359,14 +359,24 @@ class

[GitHub] carbondata pull request #1613: [CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] ...

2017-12-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1613#discussion_r155155362 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -493,4 +495,49 @@

[GitHub] carbondata pull request #1613: [CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] ...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1613#discussion_r154977627 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -493,4 +495,49 @@

[GitHub] carbondata pull request #1613: [CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] ...

2017-12-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1613#discussion_r154977110 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala --- @@ -124,19