GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/1653
[CARBONDATA-1893] Data load with multiple QUOTECHAR characters in syntax
should fail
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Do
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r156888264
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r156946110
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithMalformedCarbonCommandException.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r156958685
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -932,6 +958,11 @@ abstract class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157009247
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadOptions.scala
---
@@ -0,0 +1,83 @@
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157009066
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157150591
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/EscapeSequences.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to t
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157150632
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/EscapeSequences.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to t
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151580
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class Carbon
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151611
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class Carbon
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151644
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class Carbon
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151775
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class Carbon
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157152181
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -649,6 +650,25 @@ object CommonUtil {
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157152320
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -649,6 +650,25 @@ object CommonUtil {
Github user dhatchayani commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157153651
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/EscapeSequences.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1653
---
16 matches
Mail list logo
