[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r179098290 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonCountStar.scala --- @@ -76,6 +76,11 @@ case class CarbonCountStar(

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r179032115 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonCountStar.scala --- @@ -76,6 +76,11 @@ case class CarbonCountStar(

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178813379 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -83,28 +85,44 @@ public

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178812558 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java --- @@ -159,6 +162,11 @@ public static void

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178811570 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -224,22 +198,28 @@ protected CarbonTable

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178795222 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -83,28 +85,44 @@ public

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178788948 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -77,6 +77,19 @@ */ private

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178787139 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -143,6 +143,16 @@ private

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178739855 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTableBuilder.java --- @@ -48,23 +48,39 @@ public

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178739559 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java --- @@ -200,6 +216,90 @@ public void

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178739606 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -83,28 +85,59 @@ public

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178739522 --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommitted.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178732017 --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommitted.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178717012 --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommitted.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178715161 --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommitted.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178714736 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java --- @@ -200,6 +216,90 @@ public void

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178594069 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -79,26 +80,27 @@ * * @param segments *

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178571705 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -79,26 +80,27 @@ * * @param segments *

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178518466 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java --- @@ -83,28 +85,59 @@ public

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178517359 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java --- @@ -159,6 +162,11 @@ public static void

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178511046 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -224,22 +198,28 @@ protected CarbonTable

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178505178 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -77,6 +77,19 @@ */ private String

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2131#discussion_r178505075 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -143,6 +143,16 @@ private boolean

[GitHub] carbondata pull request #2131: [WIP] Support unmanaged carbon table read and...

2018-04-02 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2131 [WIP] Support unmanaged carbon table read and write * carbon SDK writer will take the input data and write back the carbondata and carbonindex files in the path specified. This output