[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186685351 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -133,6 +133,10 @@ return distributables; }

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186685606 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -302,9 +302,20 @@ public boolean isScanR

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186685739 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -302,9 +302,20 @@ public boolean isScanR

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186685941 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -302,9 +302,20 @@ public boolean isScanR

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186686363 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/AbstractDataMapJob.java --- @@ -36,7 +36,7 @@ } @Override public Li

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186694178 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -302,9 +302,20 @@ public boolean isScan

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186694695 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/AbstractDataMapJob.java --- @@ -36,7 +36,7 @@ } @Override public L

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186723292 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java --- @@ -100,14 +103,18 @@ private static FilterResolver

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186724944 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java --- @@ -100,14 +103,18 @@ private static FilterResolve

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186743361 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/AbstractDataMapJob.java --- @@ -36,7 +36,7 @@ } @Override public

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-08 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r186744138 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java --- @@ -109,4 +109,8 @@ public DataMa

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r189220225 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java --- @@ -100,14 +103,18 @@ private static FilterResol

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-18 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r189267374 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java --- @@ -100,14 +103,18 @@ private static FilterResolve

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r189423352 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DistributableDataMapFormat.java --- @@ -158,7 +166,11 @@ public float getProgress()

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2269 ---