Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2313
---
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189249739
--- Diff:
store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java
---
@@ -100,8 +100,9 @@ public ShutdownResponse
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189249203
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/store/LocalCarbonStore.java ---
@@ -102,6 +107,11 @@
while
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189248204
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java
---
@@ -115,23 +115,26 @@ public void
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189247616
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -77,13 +77,15 @@ private static void
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189247073
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -348,32 +348,37 @@ public boolean
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189247138
--- Diff:
integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java
---
@@ -144,14 +145,10 @@
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246968
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -60,7 +60,11 @@
*/
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246946
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -98,9 +98,11 @@
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246927
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonDictionaryMetadataReaderImpl.java
---
@@ -128,6 +131,9 @@ public
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246882
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -282,12 +282,15 @@ private
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246901
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -152,14 +152,15 @@ public synchronized boolean
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246763
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/SnappyCompressor.java
---
@@ -135,52 +136,52 @@ public String
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246853
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java
---
@@ -89,15 +89,19 @@
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246720
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/measure/AbstractMeasureChunkReaderV2V3Format.java
---
@@ -103,11
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189246746
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189239307
--- Diff:
store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java
---
@@ -100,8 +100,9 @@ public ShutdownResponse
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189239156
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/store/LocalCarbonStore.java ---
@@ -102,6 +107,11 @@
while
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189180538
--- Diff:
integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java
---
@@ -144,14 +145,10 @@
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189175211
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java
---
@@ -115,23 +115,26 @@ public void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189174422
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -77,13 +77,15 @@ private static void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189166315
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -348,32 +348,37 @@ public boolean
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189165438
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -60,7 +60,11 @@
*/
private
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188992675
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -98,9 +98,11 @@
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188972300
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonDictionaryMetadataReaderImpl.java
---
@@ -128,6 +131,9 @@ public
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188969041
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalType.java
---
@@ -44,4 +44,35 @@ public int getScale() {
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188965798
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/ArrayType.java
---
@@ -31,6 +31,31 @@ public boolean isComplexType() {
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188960024
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -152,14 +152,15 @@ public synchronized boolean
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188906834
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -282,12 +282,15 @@ private void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r12558
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java
---
@@ -89,15 +89,19 @@ public
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188845326
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/SnappyCompressor.java
---
@@ -135,52 +136,52 @@ public String getName()
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188844850
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@ -49,6
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188844399
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/measure/AbstractMeasureChunkReaderV2V3Format.java
---
@@ -103,11
GitHub user sraghunandan opened a pull request:
https://github.com/apache/carbondata/pull/2313
[CARBONDATA-2489] Coverity scan fixes
https://scan4.coverity.com/reports.htm#v29367/p11911
Be sure to do all of the following checklist to help us incorporate
your
34 matches
Mail list logo
