Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2397
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r199041537
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java
---
@@ -144,8 +144,8 @@
* If the sort memory i
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r199041131
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java
---
@@ -88,6 +88,10 @@ pub
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r197690211
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java
---
@@ -88,6 +88,10 @@ publ
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r197688967
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithUnsafeMemory.scala
---
Github user ndwangsen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r197688936
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java
---
@@ -144,8 +144,8 @@
* If the sort memory
GitHub user ndwangsen reopened a pull request:
https://github.com/apache/carbondata/pull/2397
[CARBONDATA-2644][Dataload]ADD carbon.load.sortMemory.spill.percentage
parameter invalid value check
Be sure to do all of the following checklist to help us incorporate
your contribut
