[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2403 ---

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-07-01 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199379934 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapWriter.java --- @@ -69,6 +86,27 @@ indexBloomFilters

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-07-01 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199379374 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/DirectDictionaryFieldConverterImpl.java --- @@ -65,16 +65

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-07-01 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199377946 --- Diff: datamap/bloom/pom.xml --- @@ -23,6 +23,18 @@ carbondata-core ${project.version} + + org.apa

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-30 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199325848 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/DirectDictionaryFieldConverterImpl.java --- @@ -65,16 +65,22

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-30 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199325844 --- Diff: datamap/bloom/pom.xml --- @@ -23,6 +23,18 @@ carbondata-core ${project.version} + + org.apache

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-30 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199325781 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapWriter.java --- @@ -69,6 +86,27 @@ indexBloomFilters = n

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-28 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199041852 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapBuilder.java --- @@ -42,6 +42,8 @@ boolean bloomCompre

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-28 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199041785 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -187,21 +310,18 @@ public static String g

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-28 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2403#discussion_r199041719 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -175,6 +297,7 @@ public boolean isScanReq

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-23 Thread xuchuanyin
GitHub user xuchuanyin reopened a pull request: https://github.com/apache/carbondata/pull/2403 [CARBONDATA-2633][BloomDataMap] Fix bugs in bloomfilter for dictionary/sort/date/TimeStamp column In carbondata, for dictionary column, carbon convert literal value to dict value,

[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

2018-06-23 Thread xuchuanyin
Github user xuchuanyin closed the pull request at: https://github.com/apache/carbondata/pull/2403 ---