Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2451
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200894716
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -136,14 +136,33
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200894679
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -136,14 +136,33
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200277149
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
---
@@ -521,6 +521,7 @@ public void write(DataO
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200277263
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -116,14 +116,33
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200247028
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
---
@@ -521,6 +521,7 @@ public void write(Dat
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200250993
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -116,14 +116,3
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2451#discussion_r200255313
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -116,14 +116,3
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2451
[CARBONDATA-2585][CARBONDATA-2586]Fix local dictionary support for preagg
and set localdict info in column schema
**Changes**
This PR fixes local dictionary support for preaggregate and se
