Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228694154
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -125,13 +117,24 @@ private synchronized
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228694135
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -125,13 +117,24 @@ private synchronized
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228694119
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -77,21 +77,12 @@
if (takenSize <
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228692401
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -125,13 +117,24 @@ private synchronized MemoryBlock
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228692328
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -125,13 +117,24 @@ private synchronized MemoryBlock
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228692174
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -77,21 +77,12 @@
if (takenSize <
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227339904
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -124,8 +116,21 @@ private synchronized
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227239817
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ComplexColumnPage.java
---
@@ -73,8 +73,9 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227246688
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -292,7 +300,7 @@ private void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227241237
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -125,46 +126,48 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227246446
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -124,8 +116,21 @@ private synchronized
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227235905
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -168,13 +169,16 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r227238938
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -168,13 +169,16 @@ public
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/2841
[WIP] Unsafe fallback to heap and unsafe query fix
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
14 matches
Mail list logo