[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-26 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2846#discussion_r228693240 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -733,4 +733,12 @@ public static double toXorDouble(byte[] value,

[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-26 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2846#discussion_r228693211 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -90,6 +90,8 @@ class CarbonScanRDD[T

[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-26 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2846#discussion_r228693219 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/CastColumnTestCase.scala --- @@ -224,7 +

[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-26 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2846#discussion_r228435215 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/CastColumnTestCase.scala --- @@ -224,7 +224

[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-26 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2846#discussion_r228435867 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -90,6 +90,8 @@ class CarbonScanRDD[T: C

[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-26 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2846#discussion_r228434488 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -733,4 +733,12 @@ public static double toXorDouble(byte[] value, in

[GitHub] carbondata pull request #2846: [WIP] Added direct fill

2018-10-22 Thread kumarvishal09
GitHub user kumarvishal09 opened a pull request: https://github.com/apache/carbondata/pull/2846 [WIP] Added direct fill Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? -