[GitHub] carbondata pull request #2851: [CARBONDATA-3040][BloomDataMap] Add checking ...

2018-10-24 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2851#discussion_r228010573 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/DataMapEvents.scala --- @@ -60,7 +60,8 @@ case class

[GitHub] carbondata pull request #2851: [CARBONDATA-3040][BloomDataMap] Add checking ...

2018-10-24 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2851#discussion_r228010750 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomIndexFileStore.java --- @@ -70,27 +73,37 @@ public boolean

[GitHub] carbondata pull request #2851: [CARBONDATA-3040][BloomDataMap] Add checking ...

2018-10-24 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2851#discussion_r228009613 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala --- @@ -48,8 +48,14 @@ class

[GitHub] carbondata pull request #2851: [CARBONDATA-3040][BloomDataMap] Add checking ...

2018-10-24 Thread kevinjmh
GitHub user kevinjmh opened a pull request: https://github.com/apache/carbondata/pull/2851 [CARBONDATA-3040][BloomDataMap] Add checking before merging bloom index *Scene* There is a bug which causes query failure when we create two bloom datamaps on same table with data.