[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-07 Thread NamanRastogi
Github user NamanRastogi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2996#discussion_r245669672 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -165,15 +167,

[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-02 Thread kevinjmh
Github user kevinjmh commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2996#discussion_r244906592 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -165,15 +167,22 @

[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-02 Thread kevinjmh
Github user kevinjmh commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2996#discussion_r244906489 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -165,15 +167,22 @

[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2018-12-19 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2996#discussion_r242847958 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -165,15 +167,2

[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2018-12-18 Thread NamanRastogi
GitHub user NamanRastogi opened a pull request: https://github.com/apache/carbondata/pull/2996 [WIP] Fix Rename-Fail & Datamap-creation-Fail Fixed negative scenarios: 1. Alter Table Rename Table Fail 2. Create Preagregate-Datamap Fail ### Alter Table Rename Table Fai