Github user anubhav100 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/607
@ravipesala can you review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/607
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/948/
---
If your project is set up for it, you can reply to this email and
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/609
Build Failed with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/947/
---
If your project is set up for it, you can reply to this email and
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/607
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/946/
---
If your project is set up for it, you can reply to this email and
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/607
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/945/
---
If your project is set up for it, you can reply to this email and
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887927
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
---
@@
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887862
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorWithBucketingStepImpl.java
---
@@
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887832
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java
---
@@ -135,6 +135,7 @@
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887780
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorStepImpl.java
---
@@ -93,6 +93,7
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/584
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/605
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102876851
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102876673
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataFileFooterConverterV3.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102876604
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -471,6 +472,33 @@ public static int
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102876253
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -0,0 +1,232 @@
+/*
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102875973
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102875453
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1151,6 +1139,68 @@
public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/609#discussion_r102875150
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -835,26 +834,23 @@
/**
*
[
https://issues.apache.org/jira/browse/CARBONDATA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré resolved CARBONDATA-723.
-
Resolution: Fixed
> Update team page marking PPMC member
>
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/605
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/609
Build Failed with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/943/
---
If your project is set up for it, you can reply to this email and
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/609
[CARBONDATA-726] Added code for V3 format Writer and Reader
**1. Added code to support V3 Format Writer
2. Added Code to support V3 format Reader**
**Note**
1.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/605
Build Failed with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/942/
---
If your project is set up for it, you can reply to this email and
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/605
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/940/
---
If your project is set up for it, you can reply to this email and
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693979
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java
---
@@ -104,23 +129,12
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693282
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -83,9 +81,12 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693310
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java
---
@@ -36,17 +36,76 @@
/**
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692785
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -42,38 +38,40 @@
private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692767
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKeyType.java
---
@@ -0,0 +1,38 @@
+/*
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692740
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java
---
@@ -16,12 +16,12 @@
*/
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692574
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692467
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682365
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -86,7 +78,11 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682570
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682394
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -16,57 +16,59 @@
*/
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682192
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -44,7 +40,7 @@
38 matches
Mail list logo
