Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/788
https://issues.apache.org/jira/browse/CARBONDATA-924
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user manishgupta88 reopened a pull request:
https://github.com/apache/incubator-carbondata/pull/788
[CARBONDATA-914] Clear BTree and Dictionary instances from LRU cache on
table drop
Changes includes:
1. Support cleaning of BTree and dictionary instances when a table is
Github user manishgupta88 closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/777
@kunal642 In AlterTableCommands.scala move all the lock acquiring logic
inside try block
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/788
[CARBONDATA-914] Clear BTree and Dictionary instances from LRU cache on
table drop
After drop table dictionary and BTree instances are not getting cleared
from driver memory
GitHub user manishgupta88 reopened a pull request:
https://github.com/apache/incubator-carbondata/pull/781
[CARBONDATA-900] Is null query on a newly added measure column is not
returning proper results
Analysis: When is null query is executed on newly added measure column
Github user manishgupta88 closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/781
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/781
[CARBONDATA-900] Is null query on a newly added measure column is not
returning proper results
Analysis: When is null query is executed on newly added measure column
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/727
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/727
@kunal642 change column name to column ID for every check in the revert
methods
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/703
@ravipesala fixed review comments...kindly review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/703#discussion_r110108215
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/merger/CarbonCompactionUtil.java
---
@@ -351,4 +351,33
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/735
[CARBONDATA-870] Folders and files not getting cleaned up created locally
during data load operation
Changes done:
1. Clean up of folders created locally during data load
Github user manishgupta88 closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user manishgupta88 reopened a pull request:
https://github.com/apache/incubator-carbondata/pull/733
[CARBONDATA-863] Support creation and deletion of dictionary files through
RDD during alter add and drop
Changes done:
1. Support creation and deletion of dictionary files
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/733
[CARBONDATA-863] Support creation and deletion of dictionary files through
RDD during alter add and drop
Changes done:
1. Support creation and deletion of dictionary files
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/703
[CARBONDATA-780] Alter table support for compaction through sort step
Alter table need to support compaction process where complete data need to
be sorted again and then written
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/683
[CARBONDATA-803] Incorrect results returned by not equal to filter on
dictionary column with numeric data type
Problem: Whenever a not equal to filter is applied on dictionary
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/683
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/676
[CARBONDATA-797] Data loss for BigInt datatype if data contains long max
and min values
When data contains long max and min values for a measure column with bigInt
datatype
Github user manishgupta88 closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/662
[CARBONDATA-786] FIxed Data mismatch if the data data is loaded across
blocklet groups
There is a issue in min/max calculation of blocklet groups, that is why the
data scan is
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/641
@gvramana ...Fixed test cases failure in spark1.6.2. Please refer the below
link
http://136.243.101.176:8080/job/ManualApacheCarbonPRBuilder2.1/112/
For spark-2.1
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/641
@gvramana ...Handled all review comments and all the test cases are
passing. Please refer the below link.
kindly review and merge
---
If your project is set up for it, you
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/641
[WIP] Alter table support for carbondata
As part of this PR following features will be supported.
1. Support alter table result preparation.
2. Support reading data
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/562
[CARBONDATA-668] Dataloads fail when no. of column in load query is
greater than the no. of column in create table
Problem: Dataloads fail when no. of column in load query is
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/526
@ravipesala Added test case. Please review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/526
[CARBONDATA-629] Issue with database name case sensitivity
**Analysis:** When database name is provided in any DDL/DML command, the
database name is interpreted and used in the
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94942075
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -199,6 +199,16
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94937615
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/TableSegmentUniqueIdentifier.java
---
@@ -101,10 +102,17
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94937003
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/SegmentTaskIndexStore.java
---
@@ -185,15 +210,25 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94584912
--- Diff:
core/src/main/java/org/apache/carbondata/common/iudprocessor/cache/DeleteDeltaDataCache.java
---
@@ -0,0 +1,29 @@
+package
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94584731
--- Diff:
core/src/main/java/org/apache/carbondata/common/iudprocessor/cache/BlockletLevelDeleteDeltaDataCache.java
---
@@ -0,0 +1,29
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/492
Please handle the below things in general.
1. Add apache license to newly added files.
2. Remove the author name as class level comment.
3. Add a basic comment for
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/482#discussion_r94582561
--- Diff:
core/src/main/java/org/apache/carbondata/scan/filter/resolver/RowLevelRangeFilterResolverImpl.java
---
@@ -187,7 +185,11
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/454#discussion_r94302586
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ---
@@ -148,7 +177,11 @@ private boolean
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/454#discussion_r94302315
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ---
@@ -121,15 +141,24 @@ private void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/454#discussion_r94295193
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/BlockIndexStore.java
---
@@ -244,124 +222,96 @@ public static
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/457
@Jay357089 this is how spark behaves. If a task fails on one node it
will submit the same task on the other node considering that there could be
some problem with the node
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/457
@Jay357089 ..I agree with @eason-lyx ...If data load fails on one node then
the job will be resubmitted to the same node again. If you kill the executor
then spark will submit
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/459
@foryou2030 As a suggestion whenever you make any changes in the parsing
behavior of data in the load flow without kettle, please validate the same
behavior for load using the
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/362
@jackylk ...Handled review comment. Please review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/362
@jackylk ...Handled all review comments. Kindly review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/362
[CARBONDATA-459] Block distribution is wrong in case of dynamic
allocation=true
Problem: Block distribution is wrong in case of dynamic allocation=true
Analysis: In
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/357
@Zhangshunyu ...LGMTonly thing is you can put some comments with
example for better understanding like what can be tablePath and derived
formattedTablePath.
---
If your
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/337#discussion_r9114
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ---
@@ -84,14 +84,13 @@ public static CacheProvider
46 matches
Mail list logo
