[GitHub] incubator-carbondata pull request #805: [WIP] Cast Push Down Optimization

2017-04-16 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/incubator-carbondata/pull/805 [WIP] Cast Push Down Optimization Problem : With Filter Expression with Casts, PushDown to Carbon layer was not happening. Analysis : Cast Expressions are handled in Spark

[GitHub] incubator-carbondata issue #723: [CARBONDATA-845] Insert Select Into Same Ta...

2017-04-04 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/incubator-carbondata/pull/723 @ravipesala Insert Select from same table is allowed both in Hive and Parquet. Spark-5746 introduced this behavior as they are deleting the source table data first before inserting

[GitHub] incubator-carbondata pull request #723: [CARBONDATA-845] Insert Select Into ...

2017-04-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/723#discussion_r109635229 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonPreInsertionCasts.scala --- @@ -0,0 +1,62 @@ +/* --- End

[GitHub] incubator-carbondata pull request #723: [CARBONDATA-845] Insert Select Into ...

2017-04-03 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/incubator-carbondata/pull/723 [CARBONDATA-845] Insert Select Into Same Table Problem : Insert Select Implementation in current Spark-2.1 prohibits to read and write into same table. Analysis : This

[GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...

2017-03-20 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/670#discussion_r107077934 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -0,0 +1,557

[GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...

2017-03-20 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/670#discussion_r107077907 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -0,0 +1,557

[GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...

2017-03-20 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/670#discussion_r107077923 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -0,0 +1,557

[GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...

2017-03-20 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/670#discussion_r107077246 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -0,0 +1,557

[GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...

2017-03-20 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/670#discussion_r106858685 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/BinaryExpression.java --- @@ -38,4 +38,17 @@ public Expression

[GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...

2017-03-18 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/incubator-carbondata/pull/670 [CARBONDATA-792] Range Filter Optimization Problem : LessThan and GreaterThan Expression are merged into a single RANGE expression. Analysis : If LessThan and GreaterThan

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-03-05 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/604#discussion_r104346516 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -235,121 +238,141 @@ class

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-03-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/604#discussion_r104145103 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputSplitTaskInfo.java --- @@ -0,0 +1,129

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-03-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/604#discussion_r104145140 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputSplitTaskInfo.java --- @@ -0,0 +1,129

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-03-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/604#discussion_r104144870 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputSplitTaskInfo.java --- @@ -0,0 +1,129

[GitHub] incubator-carbondata issue #604: [CARBONDATA-691] After Compaction records c...

2017-03-03 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/incubator-carbondata/pull/604 @jackylk : This problem will get reproduce in a multi node system where a single Load will create multiple carbon data file is by multiple tasks. I have tested the code changes in a

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-03-03 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/604#discussion_r104141178 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -255,77 +256,75 @@ class

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-02-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/604#discussion_r103379976 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputSplitTaskInfo.java --- @@ -0,0 +1,129 @@ +/* --- End

[GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...

2017-02-17 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/incubator-carbondata/pull/604 [CARBONDATA-691] After Compaction records count are mismatched. **Problem** : After Compaction record count mismatches with actual count. **Analysis** :The Partitioning

[GitHub] incubator-carbondata pull request #509: [CARBONDATA-440] IUD TestCase Fix fo...

2017-01-09 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/incubator-carbondata/pull/509 [CARBONDATA-440] IUD TestCase Fix for spark 1.6 Fixing the test case failure of "Delete" query when an alias is used with the table. There was a parser issue where th

[GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...

2017-01-06 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/492#discussion_r94932320 --- Diff: core/src/test/java/org/apache/carbondata/core/load/LoadMetadataDetailsUnitTest.java --- @@ -102,28 +98,29 @@ assertEquals

[GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...

2017-01-06 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/492#discussion_r94932078 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -358,66 +372,176 @@ private Expression

[GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...

2017-01-06 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/492#discussion_r94931905 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonInputMapperTest.java --- @@ -57,58 +57,58 @@ } @Test

[GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...

2017-01-06 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/492#discussion_r94927699 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java --- @@ -407,10 +407,10 @@ public static void