Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1354/
---
If your project is set up for it, you can reply to this email and
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Failed with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1352/
---
If your project is set up for it, you can reply to this email and
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@watermen
You are right, the fileName actually is a path parameter.
Agree to change fileName to carbonDataFileTempPath, please modify it in
your PR.
---
If your
Github user watermen commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@chenliang613
`fileName` is like below, used on executor as temp dir. Actual it is a path.
```
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@watermen
Thanks for your contribution, everything looks good.
Only one comment, in AbstractFactDataWriter.java, there are two
parameters(fileName,
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1348/
---
If your project is set up for it, you can reply to this email and
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user watermen commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@chenliang613 Thanks for your review, plz review it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1345/
---
If your project is set up for it, you can reply to this email and
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1336/
---
If your project is set up for it, you can reply to this email and
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Sephiroth-Lin commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1332/
---
If your project is set up for it, you can reply to this email and
Github user watermen commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@QiangCai Store fileName insteads of filePath in carbonindex now. Please
review it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
Build Success with Spark 1.6.2, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1331/
---
If your project is set up for it, you can reply to this email and
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@watermen
It is unnecessary to store carbondata file path in carbonindex file.
During btree building, just use carbondata file name to sort
tableblockinfos.
please check
19 matches
Mail list logo
