[GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...

2017-04-10 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/659#discussion_r110810313 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/SegmentTaskIndexStore.java --- @@ -338,14 +339,28 @@ private synchronized

[GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...

2017-03-27 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/659#discussion_r108146058 --- Diff: core/src/test/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndexTest.java --- @@ -58,7 +58,9 @@ @Mock

[GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...

2017-03-27 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/659#discussion_r108113194 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndex.java --- @@ -16,30 +16,52 @@ */ package

[GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...

2017-03-25 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/659#discussion_r108033699 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndex.java --- @@ -16,30 +16,52 @@ */ package