venkata swamybabu budumuru created CLOUDSTACK-4586: ------------------------------------------------------
Summary: CIDR validation is not happening for Authorizing egress rule command Key: CLOUDSTACK-4586 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4586 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.2.1 Reporter: venkata swamybabu budumuru Fix For: 4.2.1 Here is the marvin failure snippet integration.component.test_egress_rules.TestInvalidParametersForEgress.test_invalid_parameters Swamys-MacBook-Air:component swamy$ nosetests --with-marvin --marvin-config=/Users/swamy/hudson/scripts/demo.cfg --load test_egress_rules.py -a tags=swamy Test invalid parameters for egress rules ... FAIL ====================================================================== FAIL: Test invalid parameters for egress rules ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/swamy/incubator-cloudstack/test/integration/component/test_egress_rules.py", line 2098, in test_invalid_parameters domainid=self.account.domainid AssertionError: Exception not raised -------------------- >> begin captured logging << -------------------- test_invalid_parameters (integration.component.test_egress_rules.TestInvalidParametersForEgress): DEBUG: Created security group with ID: c872aced-5f69-453d-a676-5323b43ed539 test_invalid_parameters (integration.component.test_egress_rules.TestInvalidParametersForEgress): DEBUG: Authorizing egress rule for sec group ID: c872aced-5f69-453d-a676-5323b43ed539 with invalid port test_invalid_parameters (integration.component.test_egress_rules.TestInvalidParametersForEgress): DEBUG: Authorizing egress rule for sec group ID: c872aced-5f69-453d-a676-5323b43ed539 with invalid cidr --------------------- >> end captured logging << --------------------- ---------------------------------------------------------------------- Ran 1 test in 12.973s FAILED (failures=1) Here are the list of params passed to the API: "sg_invalid_cidr": { "name": 'SSH', "protocol": 'TCP', "startport": 22, "endport": 22, "cidrlist": '0.0.0.10' }, Snippet from management server logs: 2013-08-31 23:23:37,915 DEBUG [cloud.api.ApiServlet] (catalina-exec-22:null) ===END=== 10.101.255.126 -- GET signature=wWuDyStudYe2DYuqfKGowUEgcyk%3D&apiKey=BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=queryAsyncJobResult&response=json&jobid=2693054d-b5cb-472e-9100-d18a92cbf294 2013-08-31 23:23:39,001 DEBUG [cloud.api.ApiServlet] (catalina-exec-16:null) ===START=== 10.101.255.126 -- GET account=test-TestAuthorizeIngressRule-ODEG8D&domainid=6fdbc1ec-11e2-11e3-9e2f-4290361b938f&protocol=TCP&endport=22&cidrlist=0.0.0.10&securitygroupid=64ccf96c-7411-4a02-a907-6b94bc79a1fb&apiKey=BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=authorizeSecurityGroupEgress&signature=41Ngeocn%2Bli8D0tRPvXSvdpg0oA%3D&startport=22&response=json 2013-08-31 23:23:39,027 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Executor-129:job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Executing org.apache.cloudstack.api.command.user.securitygroup.AuthorizeSecurityGroupEgressCmd for job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ] 2013-08-31 23:23:39,031 DEBUG [cloud.async.AsyncJobManagerImpl] (catalina-exec-16:null) submit async job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ], details: AsyncJobVO {id:1125, userId: 2, accountId: 2, sessionKey: null, instanceType: SecurityGroup, instanceId: 302, cmd: org.apache.cloudstack.api.command.user.securitygroup.AuthorizeSecurityGroupEgressCmd, cmdOriginator: null, cmdInfo: {"protocol":"TCP","cmdEventType":"SG.AUTH.EGRESS","ctxUserId":"2","securitygroupid":"64ccf96c-7411-4a02-a907-6b94bc79a1fb","httpmethod":"GET","startport":"22","domainid":"6fdbc1ec-11e2-11e3-9e2f-4290361b938f","endport":"22","apiKey":"BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ","response":"json","account":"test-TestAuthorizeIngressRule-ODEG8D","cidrlist":"0.0.0.10","ctxAccountId":"2","ctxStartEventId":"4281","signature":"41Ngeocn+li8D0tRPvXSvdpg0oA\u003d"}, cmdVersion: 0, callbackType: 0, callbackAddress: null, status: 0, processStatus: 0, resultCode: 0, result: null, initMsid: 73187150500751, completeMsid: null, lastUpdated: null, lastPolled: null, created: null} 2013-08-31 23:23:39,033 DEBUG [cloud.api.ApiServlet] (catalina-exec-16:null) ===END=== 10.101.255.126 -- GET account=test-TestAuthorizeIngressRule-ODEG8D&domainid=6fdbc1ec-11e2-11e3-9e2f-4290361b938f&protocol=TCP&endport=22&cidrlist=0.0.0.10&securitygroupid=64ccf96c-7411-4a02-a907-6b94bc79a1fb&apiKey=BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=authorizeSecurityGroupEgress&signature=41Ngeocn%2Bli8D0tRPvXSvdpg0oA%3D&startport=22&response=json 2013-08-31 23:23:39,056 DEBUG [network.security.SecurityGroupManagerImpl] (Job-Executor-129:job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Added 1 rules to security group SSH 2013-08-31 23:23:39,071 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Executor-129:job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Complete async job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ], jobStatus: 1, resultCode: 0, result: org.apache.cloudstack.api.response.SecurityGroupResponse@6cbd7086 2013-08-31 23:23:39,093 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Executor-129:job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Done executing org.apache.cloudstack.api.command.user.securitygroup.AuthorizeSecurityGroupEgressCmd for job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ] 2013-08-31 23:23:39,995 DEBUG [cloud.api.ApiServlet] (catalina-exec-18:null) ===START=== 10.101.255.126 -- GET signature=SrC9Y8DfcLWvu6b5LoBbbArsaN0%3D&apiKey=BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=queryAsyncJobResult&response=json&jobid=509996f5-1167-4c7b-a69d-b796ea446d91 2013-08-31 23:23:40,004 DEBUG [cloud.async.AsyncJobManagerImpl] (catalina-exec-18:null) Async job-1125 = [ 509996f5-1167-4c7b-a69d-b796ea446d91 ] completed 2013-08-31 23:23:40,007 DEBUG [cloud.api.ApiServlet] (catalina-exec-18:null) ===END=== 10.101.255.126 -- GET signature=SrC9Y8DfcLWvu6b5LoBbbArsaN0%3D&apiKey=BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=queryAsyncJobResult&response=json&jobid=509996f5-1167-4c7b-a69d-b796ea446d91 2013-08-31 23:23:40,844 DEBUG [cloud.storage.StorageManagerImpl] (StorageManager-Scavenger-3:null) Storage pool garbage collector found 0 templates to clean up in storage pool: PS0 2013-08-31 23:23:40,847 DEBUG [cloud.storage.StorageManagerImpl] (StorageManager-Scavenger-3:null) Storage pool garbage collector found 0 templates to clean up in storage pool: PS1 2013-08-31 23:23:40,850 DEBUG [cloud.storage.StorageManagerImpl] (StorageManager-Scavenger-3:null) Secondary storage garbage collector found 0 templates to cleanup on template_store_ref for store: nfs://nfs1-ccp.citrix.com:/home/common/automation/SC_QA_AUTO5/secondary1 2013-08-31 23:23:40,851 DEBUG [cloud.storage.StorageManagerImpl] (StorageManager-Scavenger-3:null) Secondary storage garbage collector found 0 snapshots to cleanup on snapshot_store_ref for store: nfs://nfs1-ccp.citrix.com:/home/common/automation/SC_QA_AUTO5/secondary1 2013-08-31 23:23:40,852 DEBUG [cloud.storage.StorageManagerImpl] (StorageManager-Scavenger-3:null) Secondary storage garbage collector found 0 volumes to cleanup on volume_store_ref for store: nfs://nfs1-ccp.citrix.com:/home/common/automation/SC_QA_AUTO5/secondary1 2013-08-31 23:23:41,022 DEBUG [cloud.api.ApiServlet] (catalina-exec-5:null) ===START=== 10.101.255.126 -- GET signature=hPbLa6LtbvGqPhXKeByWzgrkGTM%3D&apiKey=BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=deleteAccount&id=054ca01e-b508-42ae-ad64-1fc42cb25a72&response=json -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira