[jira] [Comment Edited] (DBUTILS-128) Can't execute subquery when use parameters

2016-05-08 Thread inthink (JIRA)
[ https://issues.apache.org/jira/browse/DBUTILS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273563#comment-15273563 ] inthink edited comment on DBUTILS-128 at 5/9/16 6:58 AM: - *After

[jira] [Updated] (CSV-181) Make CSVPrinter.print(Object) GC-free

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CSV-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CSV-181: - Attachment: csv-181-gg.diff Attached WIP and I am discussing this with [~rem...@yahoo.com] from our Log4j te

[jira] [Created] (CSV-181) Make CSVPrinter.print(Object) GC-free

2016-05-08 Thread Gary Gregory (JIRA)
Gary Gregory created CSV-181: Summary: Make CSVPrinter.print(Object) GC-free Key: CSV-181 URL: https://issues.apache.org/jira/browse/CSV-181 Project: Commons CSV Issue Type: Improvement

[jira] [Created] (JCS-162) memory region properties documentation incorrect

2016-05-08 Thread Ryan Fong (JIRA)
Ryan Fong created JCS-162: - Summary: memory region properties documentation incorrect Key: JCS-162 URL: https://issues.apache.org/jira/browse/JCS-162 Project: Commons JCS Issue Type: Documentation

[jira] [Updated] (JCS-161) dynamic regions leak memory upon dispose due to ShrinkerTask

2016-05-08 Thread Ryan Fong (JIRA)
[ https://issues.apache.org/jira/browse/JCS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Fong updated JCS-161: -- Attachment: commons-jcs-core.patch I'm attaching a patch file as a suggestion to fix the problem I reported. The C

[jira] [Commented] (LANG-1226) StringUtils#normalizeSpace does not trim the string anymore

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275795#comment-15275795 ] Gary Gregory commented on LANG-1226: Ugh, my initial impression is that I'd like to hav

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that generate strings between a min and max length

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275791#comment-15275791 ] Gary Gregory commented on LANG-1224: [~pascalschumacher]: If you want to create your pa

[jira] [Comment Edited] (IO-508) Veracode static scan still shows 1 very high OS Command injection in commons-io-2.4.jar

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275788#comment-15275788 ] Gary Gregory edited comment on IO-508 at 5/8/16 11:29 PM: -- We just re

[jira] [Commented] (IO-508) Veracode static scan still shows 1 very high OS Command injection in commons-io-2.4.jar

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275788#comment-15275788 ] Gary Gregory commented on IO-508: - We just released verison 2.5. Can you check there please?

[jira] [Updated] (IO-508) Veracode static scan still shows 1 very high OS Command injection in commons-io-2.4.jar

2016-05-08 Thread I-Min Mau (JIRA)
[ https://issues.apache.org/jira/browse/IO-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] I-Min Mau updated IO-508: - Environment: Windows (was: Linux) > Veracode static scan still shows 1 very high OS Command injection in > commons-

[jira] [Updated] (IO-508) Veracode static scan still shows 1 very high OS Command injection in commons-io-2.4.jar

2016-05-08 Thread I-Min Mau (JIRA)
[ https://issues.apache.org/jira/browse/IO-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] I-Min Mau updated IO-508: - Description: I cloned IO-474 because we specifically upgraded the commons-io jar in our application recently to 2.4 j

[jira] [Created] (IO-508) Veracode static scan still shows 1 very high OS Command injection in commons-io-2.4.jar

2016-05-08 Thread I-Min Mau (JIRA)
I-Min Mau created IO-508: Summary: Veracode static scan still shows 1 very high OS Command injection in commons-io-2.4.jar Key: IO-508 URL: https://issues.apache.org/jira/browse/IO-508 Project: Commons IO

[jira] [Commented] (LANG-1184) StringUtils#normalizeSpace no longer normalizes unicode non-breaking spaces (\u00A0)

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275657#comment-15275657 ] ASF GitHub Bot commented on LANG-1184: -- Github user garydgregory commented on the pull

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that generate strings between a min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275658#comment-15275658 ] Pascal Schumacher commented on LANG-1224: - I'm hoping the author will update the pu

[GitHub] commons-lang pull request: LANG-1184: StringUtils#normalizeSpace n...

2016-05-08 Thread garydgregory
Github user garydgregory commented on the pull request: https://github.com/apache/commons-lang/pull/113#issuecomment-217737900 Yes, let's add a new method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (LANG-1184) StringUtils#normalizeSpace no longer normalizes unicode non-breaking spaces (\u00A0)

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275656#comment-15275656 ] Pascal Schumacher commented on LANG-1184: - I the "non-trimming" part of the issue a

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that generate strings between a min and max length

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275655#comment-15275655 ] Gary Gregory commented on LANG-1224: Who will update the PR? Is this change OK with you

[jira] [Updated] (LANG-1184) StringUtils#normalizeSpace no longer normalizes unicode non-breaking spaces (\u00A0)

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1184: Summary: StringUtils#normalizeSpace no longer normalizes unicode non-breaking spaces (\u00A0)

[jira] [Updated] (LANG-1184) StringUtils#normalizeSpace no longer normalizes unicode non-breaking spaces (\u00A0) and does not trim control chars at the end any more

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1184: Description: This works with 3.3.2, but fails with 3.4 {code:java}assertEquals("a b", String

[jira] [Updated] (LANG-1226) StringUtils#normalizeSpace does not trim the string anymore

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1226: Description: These work with 3.3.2, but fail with 3.4: {code} assertEquals("b", StringUtils.

[jira] [Created] (LANG-1226) StringUtils#normalizeSpace does not trim the string anymore

2016-05-08 Thread Pascal Schumacher (JIRA)
Pascal Schumacher created LANG-1226: --- Summary: StringUtils#normalizeSpace does not trim the string anymore Key: LANG-1226 URL: https://issues.apache.org/jira/browse/LANG-1226 Project: Commons Lang

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that generate strings between a min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275647#comment-15275647 ] Pascal Schumacher commented on LANG-1224: - Hi Garry, I used the commit comment of

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that generate strings between a min and max length

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275646#comment-15275646 ] ASF GitHub Bot commented on LANG-1224: -- Github user PascalSchumacher commented on the

[GitHub] commons-lang pull request: random length strings within range

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/101#issuecomment-217736263 To quote Gary Gregory from https://issues.apache.org/jira/browse/LANG-1224 >It seems really confusing that some new APIs would use an inclusive max

[jira] [Updated] (LANG-1224) Extend RandomStringUtils with methods that generate strings between min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Summary: Extend RandomStringUtils with methods that generate strings between min and max leng

[jira] [Updated] (LANG-1224) Extend RandomStringUtils with methods that generate strings between a min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Summary: Extend RandomStringUtils with methods that generate strings between a min and max le

[jira] [Issue Comment Deleted] (LANG-1224) Extend RandomStringUtils with methods that generate strings between an inclusive min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Comment: was deleted (was: Hi Gary, sorry for the confusion. I just copied the comment of t

[jira] [Commented] (CONFIGURATION-624) Support Commons Configuration as PropertySource in Spring

2016-05-08 Thread Dennis Kieselhorst (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275642#comment-15275642 ] Dennis Kieselhorst commented on CONFIGURATION-624: -- Ok sun-checks

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that generate strings between an inclusive min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275641#comment-15275641 ] Pascal Schumacher commented on LANG-1224: - Hi Gary, sorry for the confusion. I ju

[jira] [Updated] (LANG-1224) Extend RandomStringUtils with methods that generate strings between an inclusive min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Summary: Extend RandomStringUtils with methods that generate strings between an inclusive min

[jira] [Updated] (LANG-1224) Extend RandomStringUtils with methods that generates strings between an inclusive min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Summary: Extend RandomStringUtils with methods that generates strings between an inclusive mi

[GitHub] commons-lang pull request: random length strings within range

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/101#discussion_r62435581 --- Diff: src/main/java/org/apache/commons/lang3/RandomStringUtils.java --- @@ -81,6 +81,20 @@ public static String random(final int count) {

[jira] [Updated] (LANG-1224) Extend RandomStringUtils with methods that generate Strings with an inclusive min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Summary: Extend RandomStringUtils with methods that generate Strings with an inclusive min an

[jira] [Updated] (LANG-1224) Extend RandomStringUtils with methods that generate String with an inclusive min and max length

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1224: Summary: Extend RandomStringUtils with methods that generate String with an inclusive min and

[jira] [Commented] (LANG-1218) EqualsBuilder.append(Object,Object) is too big to be inlined, which prevents whole builder to be scalarized

2016-05-08 Thread Ruslan Cheremin (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275629#comment-15275629 ] Ruslan Cheremin commented on LANG-1218: --- Thank you! > EqualsBuilder.append(Object,Ob

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that take an inclusive min and max range

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275626#comment-15275626 ] Gary Gregory commented on LANG-1224: It seems _really_ confusing that some new APIs wou

[jira] [Commented] (LANG-1218) EqualsBuilder.append(Object,Object) is too big to be inlined, which prevents whole builder to be scalarized

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275621#comment-15275621 ] ASF GitHub Bot commented on LANG-1218: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (LANG-1218) EqualsBuilder.append(Object,Object) is too big to be inlined, which prevents whole builder to be scalarized

2016-05-08 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LANG-1218. Resolution: Fixed Fix Version/s: 3.5 In Git master. > EqualsBuilder.append(Object,Object) is

[GitHub] commons-lang pull request: LANG-1218 EqualsBuilder.append is too l...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (CONFIGURATION-624) Support Commons Configuration as PropertySource in Spring

2016-05-08 Thread Oliver Heger (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275616#comment-15275616 ] Oliver Heger commented on CONFIGURATION-624: Hm, don't know what a plai

[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/121#issuecomment-217722238 @NickManley Thanks for the pull request. It would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira/browse

[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/122#issuecomment-217722232 @NickManley Thanks for the pull request. It would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira/browse

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/25#issuecomment-217721641 @thiagoh I guess this can be closed, as it is superseded by https://github.com/apache/commons-lang/pull/136 ? --- If your project is set up for it, you ca

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/24#issuecomment-217721614 @thiagoh I guess this can be closed as it is superseded by https://github.com/apache/commons-lang/issues/137 ? --- If your project is set up for it, you c

[jira] [Commented] (LANG-1155) New method for StringUtils - unwrap a string token

2016-05-08 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275599#comment-15275599 ] Pascal Schumacher commented on LANG-1155: - I guess this is a duplicate of [https:/

[jira] [Commented] (LANG-1014) Adding unwrap and unwrapFull methods to StringUtils

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275598#comment-15275598 ] ASF GitHub Bot commented on LANG-1014: -- Github user PascalSchumacher commented on the

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/136#issuecomment-217721352 Jira: https://issues.apache.org/jira/browse/LANG-1014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/137#issuecomment-217721209 JIRA https://issues.apache.org/jira/browse/LANG-1013 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Commented] (LANG-1013) Adding to StringUtils truncate method and test cases

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275597#comment-15275597 ] ASF GitHub Bot commented on LANG-1013: -- Github user PascalSchumacher commented on the

[GitHub] commons-lang pull request: random length strings within range

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/101#issuecomment-217720683 I still think these methods should be added to commons-lang. They are a very useful extensions of RandomStringUtils feature set. I created https:/

[jira] [Commented] (LANG-1224) Extend RandomStringUtils with methods that take an inclusive min and max range

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275596#comment-15275596 ] ASF GitHub Bot commented on LANG-1224: -- Github user PascalSchumacher commented on the

[jira] [Created] (LANG-1225) RandomStringUtils add #randomGraph and #randomPrint which match corresponding regular expression class

2016-05-08 Thread Pascal Schumacher (JIRA)
Pascal Schumacher created LANG-1225: --- Summary: RandomStringUtils add #randomGraph and #randomPrint which match corresponding regular expression class Key: LANG-1225 URL: https://issues.apache.org/jira/browse/LAN

[jira] [Created] (LANG-1224) Extend RandomStringUtils with methods that take an inclusive min and max range

2016-05-08 Thread Pascal Schumacher (JIRA)
Pascal Schumacher created LANG-1224: --- Summary: Extend RandomStringUtils with methods that take an inclusive min and max range Key: LANG-1224 URL: https://issues.apache.org/jira/browse/LANG-1224 Proj

[jira] [Closed] (BEANUTILS-488) Commons-collections v 3.2.1 dependency is not security compliant. Upgrade to 3.2.2

2016-05-08 Thread Akhil (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhil closed BEANUTILS-488. --- Resolution: Duplicate > Commons-collections v 3.2.1 dependency is not security compliant. Upgrade to > 3.2

[jira] [Created] (BEANUTILS-488) Commons-collections v 3.2.1 dependency is not security compliant. Upgrade to 3.2.2

2016-05-08 Thread Akhil (JIRA)
Akhil created BEANUTILS-488: --- Summary: Commons-collections v 3.2.1 dependency is not security compliant. Upgrade to 3.2.2 Key: BEANUTILS-488 URL: https://issues.apache.org/jira/browse/BEANUTILS-488 Project:

[jira] [Commented] (CRYPTO-54) US Export classification & ECCN registration for encryption

2016-05-08 Thread Benedikt Ritter (JIRA)
[ https://issues.apache.org/jira/browse/CRYPTO-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275584#comment-15275584 ] Benedikt Ritter commented on CRYPTO-54: --- Discussion on the mailing list indicates, th

[jira] [Commented] (LANG-1205) NumberUtils.createNumber() behaves inconsistently with NumberUtils.isNumber()

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275579#comment-15275579 ] ASF GitHub Bot commented on LANG-1205: -- Github user PascalSchumacher commented on the

[GitHub] commons-lang pull request: Add tests for some missed branches in S...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/135#issuecomment-217714266 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] commons-lang pull request: [LANG-1205] NumberUtils.createNumber() ...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/130#issuecomment-217714251 Thanks! :+1: Commit has been merged: https://github.com/apache/commons-lang/commit/b877fb9abef4a19eec9cc7329acbd433648b8f7b --- If your project is set up

[GitHub] commons-lang pull request: Fix indexOfIgnoreCase javadoc and provi...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] commons-lang pull request: Formatting ArrayUtils

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (LANG-1205) NumberUtils.createNumber() behaves inconsistently with NumberUtils.isNumber()

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275578#comment-15275578 ] ASF GitHub Bot commented on LANG-1205: -- Github user asfgit closed the pull request at:

[GitHub] commons-lang pull request: Add tests for some missed branches in S...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] commons-lang pull request: [LANG-1205] NumberUtils.createNumber() ...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] commons-lang pull request: modify note at line 1230

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (LANG-781) Null-Check to variable Object parameters - ObjectUtils.isAnyNull

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275574#comment-15275574 ] ASF GitHub Bot commented on LANG-781: - Github user PascalSchumacher commented on the pul

[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/108#issuecomment-217712963 @vanta It would be nice if you could update the pull request according to garys comments. Thanks! --- If your project is set up for it, you can

[GitHub] commons-lang pull request: Fix some typos in Javadoc

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] commons-lang pull request: Fix some typos in Javadoc

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/134#issuecomment-217709083 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/137#discussion_r62429807 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -460,6 +460,108 @@ public static String trimToEmpty(final String str) {

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/136#discussion_r62429812 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -8471,4 +8471,384 @@ public static String wrap(final String str, final

[jira] [Commented] (VALIDATOR-394) General Modulus Ten Check Digit Implementation

2016-05-08 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275528#comment-15275528 ] Sebb commented on VALIDATOR-394: Good idea. However postitionWeight should really be c

[jira] [Commented] (LANG-1218) EqualsBuilder.append(Object,Object) is too big to be inlined, which prevents whole builder to be scalarized

2016-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275525#comment-15275525 ] ASF GitHub Bot commented on LANG-1218: -- GitHub user marschall opened a pull request:

[GitHub] commons-lang pull request: LANG-1218 EqualsBuilder.append is too l...

2016-05-08 Thread marschall
GitHub user marschall opened a pull request: https://github.com/apache/commons-lang/pull/138 LANG-1218 EqualsBuilder.append is too large EqualsBuilder.append(Object, Object) is 327 bytes which is 2 bytes above the default inline limit of 325 of HotSpot (MaxInlineSize). Micro

[jira] [Commented] (CONFIGURATION-624) Support Commons Configuration as PropertySource in Spring

2016-05-08 Thread Dennis Kieselhorst (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275520#comment-15275520 ] Dennis Kieselhorst commented on CONFIGURATION-624: -- Thanks for the