[jira] [Commented] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378138#comment-16378138 ] ASF GitHub Bot commented on CLI-282: Github user deepy commented on the issue: https

[jira] [Commented] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378140#comment-16378140 ] ASF GitHub Bot commented on CLI-282: Github user deepy closed the pull request at: h

[jira] [Commented] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378139#comment-16378139 ] ASF GitHub Bot commented on CLI-282: Github user deepy commented on the issue: https

[jira] [Commented] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378141#comment-16378141 ] ASF GitHub Bot commented on CLI-282: Github user deepy closed the pull request at: h

[jira] [Closed] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread Alex Nordlund (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Nordlund closed CLI-282. - (y) > TypeHandler should throw ParseException for an unsupported class > ---

[jira] [Closed] (LOGGING-162) org.apache.commons.discovery.DiscoveryException

2018-02-26 Thread Vijendra Kulhade (JIRA)
[ https://issues.apache.org/jira/browse/LOGGING-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijendra Kulhade closed LOGGING-162. Resolution: Not A Problem > org.apache.commons.discovery.DiscoveryException > -

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377330#comment-16377330 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 Maybe there should be a commons-examples project with the src for examples? The java doc examples could come from there ---

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377325#comment-16377325 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 To do try with resources we would have to have do nothing default returns right? ---

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377320#comment-16377320 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 Sorry @garydgregory I understood you to mean it would be optional. So, the context of the creation of this idea is I did it for an environment where we have optional available 'ca

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377279#comment-16377279 ] ASF GitHub Bot commented on LANG-1373: -- Github user garydgregory commented on the issu

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/311 WRT "Try on the overall watch would have to behave differently, as it would both close the watch and stop the root timing..." I am not saying you would always use a try-with-resou

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377271#comment-16377271 ] ASF GitHub Bot commented on LANG-1373: -- Github user garydgregory commented on the issu

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/311 I hope we do not advocate running code like the fragment you just quoted. This is the same kind of issue we finally resolved in Apache Log4 2 where you no longer need to write code like:

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377263#comment-16377263 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 Try on the overall watch would have to behave differently, as it would both close the watch and stop the root timing... ---

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377261#comment-16377261 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 ```java Optional watchOptional = state.context.getWatch(); watchOptional.ifPresent((sw) -> sw.startTiming("lambda", "LAMBDA")); Object result = apply(localState);

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377252#comment-16377252 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 That doesn't mean I don't want to re-visit the idea ---

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377230#comment-16377230 ] ASF GitHub Bot commented on LANG-1373: -- Github user ottobackwards commented on the iss

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/commons-lang/pull/311 I did think of that at the start. There were two issues for me: 1. I didn't want to expose the internal node to the caller and complicate the interface 2. In my scenario ( a

[jira] [Commented] (DAEMON-381) StopTimeout not working

2018-02-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/DAEMON-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377225#comment-16377225 ] Gary Gregory commented on DAEMON-381: - Hi [~dwebb], Thank you for your report. Would

[jira] [Commented] (TEXT-120) StringEscapeUtils UnescapeJson does not unescape

2018-02-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377217#comment-16377217 ] Gary Gregory commented on TEXT-120: --- Hello [~Robles], A patch would be most welcome, even

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377209#comment-16377209 ] ASF GitHub Bot commented on LANG-1373: -- Github user kinow commented on the issue:

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/311 Well, no, but I quite like your example. Will give it a try to see how it would look like without looking at the code (mobile right now), my only concern would be using try-with-resource when we

[jira] [Resolved] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved CLI-282. -- Resolution: Fixed Fix Version/s: 1.5 Hi [~deepy], In git master, please verify the code and close t

[jira] [Updated] (CLI-282) TypeHandler should throw ParseException for an unsupported class

2018-02-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated CLI-282: - Summary: TypeHandler should throw ParseException for an unsupported class (was: TypeHandler should throw Par

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377187#comment-16377187 ] ASF GitHub Bot commented on LANG-1373: -- Github user garydgregory commented on the issu

[GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...

2018-02-26 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/311 Hi All: Have you considered allowing the timer to be used in a try-with-resources statement such that ``` StackWatch watch = new StackWatch<>("OuterFunction"); wa

[jira] [Commented] (LANG-1381) ToStringBuilder Works Inconsistently With HashMap

2018-02-26 Thread Brian Schack (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377084#comment-16377084 ] Brian Schack commented on LANG-1381: Dear Mr. Kruse, Thank you for taking this issue s

[jira] [Updated] (TEXT-120) StringEscapeUtils UnescapeJson does not unescape

2018-02-26 Thread Pedro (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pedro updated TEXT-120: --- Description: Here's a unit test to show how the escape/unescape cycle doesn't return expected String.   {code:java} @T

[jira] [Updated] (TEXT-120) StringEscapeUtils UnescapeJson does not unescape

2018-02-26 Thread Pedro (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pedro updated TEXT-120: --- Description: Here's a unit test to show how the escape/unescape cycle doesn't return expected String.   {code:java} //

[jira] [Created] (TEXT-120) StringEscapeUtils UnescapeJson does not unescape

2018-02-26 Thread Pedro (JIRA)
Pedro created TEXT-120: -- Summary: StringEscapeUtils UnescapeJson does not unescape Key: TEXT-120 URL: https://issues.apache.org/jira/browse/TEXT-120 Project: Commons Text Issue Type: Bug Affects Ver

[jira] [Closed] (COLLECTIONS-676) Modify IteratorUtils.pushbackIterator signature to return PushbackIterator

2018-02-26 Thread Matthew Knight (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Knight closed COLLECTIONS-676. -- Verified changes in git master. > Modify IteratorUtils.pushbackIterator signature to r

[jira] [Closed] (COLLECTIONS-675) Modify IteratorUtils.peekingIterator signature to return PeekingIterator

2018-02-26 Thread Matthew Knight (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Knight closed COLLECTIONS-675. -- Verified changes in git master. > Modify IteratorUtils.peekingIterator signature to re

[jira] [Closed] (COLLECTIONS-677) Modify IteratorUtils.objectGraphIterator signature to return ObjectGraphIterator

2018-02-26 Thread Matthew Knight (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Knight closed COLLECTIONS-677. -- Resolution: Not A Problem ObjectGraphIterator has no public methods that are unique

[jira] [Commented] (COLLECTIONS-677) Modify IteratorUtils.objectGraphIterator signature to return ObjectGraphIterator

2018-02-26 Thread Matthew Knight (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376843#comment-16376843 ] Matthew Knight commented on COLLECTIONS-677: You're right.  This isn't ne

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376841#comment-16376841 ] Otto Fowler commented on LANG-1373: --- [~kinow], I *think* so.  We *may* take [~erans] last

[jira] [Commented] (CLI-282) TypeHandler should throw ParseException

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376809#comment-16376809 ] ASF GitHub Bot commented on CLI-282: GitHub user deepy opened a pull request: https:

[jira] [Commented] (CLI-282) TypeHandler should throw ParseException

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CLI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376808#comment-16376808 ] ASF GitHub Bot commented on CLI-282: GitHub user deepy opened a pull request: https:

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376801#comment-16376801 ] Bruno P. Kinoshita commented on LANG-1373: -- [~ottobackwards] I assume everything i

[jira] [Deleted] (FILEUPLOAD-289) rererer

2018-02-26 Thread Jochen Wiedmann (JIRA)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Wiedmann deleted FILEUPLOAD-289: --- > rererer > --- > > Key: FILEUPLOAD-289 > URL: ht

[jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack

2018-02-26 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376700#comment-16376700 ] Gilles commented on LANG-1373: -- bq. when I do just {@code } I get errors doing mvn clean site

[jira] [Commented] (LANG-1380) FastDateParser too strict on abbreviated short month symbols

2018-02-26 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376691#comment-16376691 ] Gilles commented on LANG-1380: -- If the problem/issue/fix is not well-defined, you might want t

[jira] [Comment Edited] (LANG-1380) FastDateParser too strict on abbreviated short month symbols

2018-02-26 Thread Markus Jelsma (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376671#comment-16376671 ] Markus Jelsma edited comment on LANG-1380 at 2/26/18 11:02 AM: --

[jira] [Commented] (LANG-1380) FastDateParser too strict on abbreviated short month symbols

2018-02-26 Thread Markus Jelsma (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376671#comment-16376671 ] Markus Jelsma commented on LANG-1380: - Hello Gilles, I was thinking to be more lenien

[jira] [Created] (CLI-282) TypeHandler should throw ParseException

2018-02-26 Thread Alex Nordlund (JIRA)
Alex Nordlund created CLI-282: - Summary: TypeHandler should throw ParseException Key: CLI-282 URL: https://issues.apache.org/jira/browse/CLI-282 Project: Commons CLI Issue Type: Bug Affects V