[GitHub] commons-lang issue #334: Code refactoring and cleaning

2018-06-23 Thread stokito
Github user stokito commented on the issue: https://github.com/apache/commons-lang/pull/334 I checked and everything is ok in terms of backward compatibility. But the commit 7f8571a506c7081bae0cf27bd93295e0344160bf "flips the order of conditional expressions and 'if' statements whose

[GitHub] commons-lang issue #278: Lang-1345 Enhance non-empty strings

2018-06-23 Thread stokito
Github user stokito commented on the issue: https://github.com/apache/commons-lang/pull/278 For me is not clear importance of the new methods. I can't remember situations when I needed for something like this. And even if I need something like this I'll write the function myself and I

[GitHub] commons-lang issue #318: clean code

2018-06-23 Thread stokito
Github user stokito commented on the issue: https://github.com/apache/commons-lang/pull/318 Changes are ok ---

[jira] [Created] (LANG-1400) StringUtils: Add method for masking strings

2018-06-23 Thread Sergey Ponomarev (JIRA)
Sergey Ponomarev created LANG-1400: -- Summary: StringUtils: Add method for masking strings Key: LANG-1400 URL: https://issues.apache.org/jira/browse/LANG-1400 Project: Commons Lang Issue Type

[GitHub] commons-lang pull request #335: LANG-1400: Add StringUtils.mask() function

2018-06-23 Thread stokito
GitHub user stokito opened a pull request: https://github.com/apache/commons-lang/pull/335 LANG-1400: Add StringUtils.mask() function My alternative implementation for #332 See https://issues.apache.org/jira/browse/LANG-1400 for details You can merge this pull request into a Git

[jira] [Commented] (LANG-1400) StringUtils: Add method for masking strings

2018-06-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521296#comment-16521296 ] ASF GitHub Bot commented on LANG-1400: -- GitHub user stokito opened a pull request:

[jira] [Updated] (LANG-1400) StringUtils: Add method for masking strings

2018-06-23 Thread Sergey Ponomarev (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Ponomarev updated LANG-1400: --- Description: It would be great to have a function which allows to mask the original str by re

[GitHub] commons-lang issue #332: Add methods allowing masking of Strings

2018-06-23 Thread stokito
Github user stokito commented on the issue: https://github.com/apache/commons-lang/pull/332 Hi @greenman18523 thank for your contribution - from my experience this is "must have" functionality for Commons Lang library because in almost all bit projects what I saw was their home grown

[jira] [Commented] (LANG-1400) StringUtils: Add method for masking strings

2018-06-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521300#comment-16521300 ] ASF GitHub Bot commented on LANG-1400: -- Github user stokito commented on the issue:

[jira] [Updated] (LANG-1400) StringUtils: Add method for masking strings

2018-06-23 Thread Sergey Ponomarev (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Ponomarev updated LANG-1400: --- Description: It would be great to have a function which allows to mask the original str by re

[jira] [Updated] (LANG-1400) StringUtils: Add method for masking strings

2018-06-23 Thread Sergey Ponomarev (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Ponomarev updated LANG-1400: --- Description: It would be great to have a function which allows to mask the original str by re

[jira] [Commented] (LANG-967) Code should never catch and ignore all Throwables

2018-06-23 Thread Sergey Ponomarev (JIRA)
[ https://issues.apache.org/jira/browse/LANG-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521312#comment-16521312 ] Sergey Ponomarev commented on LANG-967: --- As it was mentioned you shouldn't catch Thro

[GitHub] commons-lang issue #318: clean code

2018-06-23 Thread JiangYongKang
Github user JiangYongKang commented on the issue: https://github.com/apache/commons-lang/pull/318 @stokito thinks ---

[GitHub] commons-lang issue #318: clean code

2018-06-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/318 @JiangYongKang, thanks for your contribution. Even though the behaviour is the same, in my opinion, the other code is easier to read, and fewer code doesn't necessarily mean better or mor

[GitHub] commons-lang issue #334: Code refactoring and cleaning

2018-06-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/334 Thanks @PascalSchumacher for confirming it's actually backward compatible (#TodayILearned - and hopefully will remember it). @ingvarc , I agree on @aaabramov regarding the `+1`. When I re