[jira] [Comment Edited] (LANG-1420) TypeUtils.isAssignable returns wrong result for GenericArrayType and ParameterizedType comparison

2018-12-07 Thread Rostislav Krasny (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713451#comment-16713451 ] Rostislav Krasny edited comment on LANG-1420 at 12/8/18 1:04 AM: ---

[jira] [Commented] (LANG-1420) TypeUtils.isAssignable returns wrong result for GenericArrayType and ParameterizedType comparison

2018-12-07 Thread Rostislav Krasny (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713451#comment-16713451 ] Rostislav Krasny commented on LANG-1420: Adding following check into the {{isAssig

[jira] [Commented] (LANG-1410) StringsUtil.isBlank check null first

2018-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713434#comment-16713434 ] ASF GitHub Bot commented on LANG-1410: -- GitHub user rosti-il opened a pull request:

[jira] [Commented] (LANG-1410) StringsUtil.isBlank check null first

2018-12-07 Thread Rostislav Krasny (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713438#comment-16713438 ] Rostislav Krasny commented on LANG-1410: Hi [~s...@apache.org], I made a PR with

[GitHub] commons-lang pull request #392: LANG-1410: eliminate one unnecessary local i...

2018-12-07 Thread rosti-il
GitHub user rosti-il opened a pull request: https://github.com/apache/commons-lang/pull/392 LANG-1410: eliminate one unnecessary local int variable and add more tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/rosti-il/commo

[jira] [Commented] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713385#comment-16713385 ] Otto Fowler commented on VFS-685: - If we wanted to say, look at reviewing a couple of in q p

[jira] [Commented] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713330#comment-16713330 ] Otto Fowler commented on VFS-685: - What would be great is if we could land this and the othe

[jira] [Commented] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713329#comment-16713329 ] Otto Fowler commented on VFS-685: - Of course it should be.  Not all providers will be submit

[jira] [Commented] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713304#comment-16713304 ] Gary Gregory commented on VFS-685: -- So should this PR still be merged? If so, the new non-

[jira] [Commented] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713205#comment-16713205 ] Otto Fowler commented on VFS-685: - Understood.   I wrote a provider for zookeeper, origina

[jira] [Commented] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713202#comment-16713202 ] Bernd Eckenfels commented on VFS-685: - Just a FYI, I have an provider which runs the who

[jira] [Created] (VFS-685) Test classes should be public so test suits can be extended

2018-12-07 Thread Otto Fowler (JIRA)
Otto Fowler created VFS-685: --- Summary: Test classes should be public so test suits can be extended Key: VFS-685 URL: https://issues.apache.org/jira/browse/VFS-685 Project: Commons VFS Issue Type:

[jira] [Commented] (VFS-398) FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712806#comment-16712806 ] Otto Fowler commented on VFS-398: - Nevermind, i was able to bring changes over from apache/V

[jira] [Commented] (NUMBERS-56) Wrong dimension check?

2018-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712804#comment-16712804 ] ASF GitHub Bot commented on NUMBERS-56: --- GitHub user stevebosman opened a pull requ

[jira] [Resolved] (VALIDATOR-450) EmailValidator : Support new official TLDs

2018-12-07 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-450. Resolution: Implemented The list of TLDs is always changing, so the code now allows the list to be over

[jira] [Commented] (VFS-398) FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712758#comment-16712758 ] Otto Fowler commented on VFS-398: - Actually, [~garydgregory], what is this patch?  It is a p

[jira] [Commented] (VFS-398) FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name

2018-12-07 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/VFS-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712748#comment-16712748 ] Otto Fowler commented on VFS-398: - {noformat} ~/src/apache/forks/commons-vfs   VFS-398  g

[jira] [Resolved] (DAEMON-395) Fix hash links on download page

2018-12-07 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/DAEMON-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved DAEMON-395. - Resolution: Fixed > Fix hash links on download page > --- > > Key: DA

[jira] [Commented] (DAEMON-395) Fix hash links on download page

2018-12-07 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/DAEMON-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712741#comment-16712741 ] Sebb commented on DAEMON-395: - Fixed the source: URL: http://svn.apache.org/viewvc?rev=18483