[GitHub] [commons-statistics] UditArora2000 commented on issue #4: A small Mode function

2019-05-04 Thread GitBox
UditArora2000 commented on issue #4: A small Mode function URL: https://github.com/apache/commons-statistics/pull/4#issuecomment-489397119 Sorry everyone. I hadn't opened Github for some time. I totally agree in the point of not creating an extra variable. I have read the Contributing.md bu

[GitHub] [commons-collections] coveralls edited a comment on issue #70: Add removeIf

2019-05-04 Thread GitBox
coveralls edited a comment on issue #70: Add removeIf URL: https://github.com/apache/commons-collections/pull/70#issuecomment-489336420 [![Coverage Status](https://coveralls.io/builds/23193858/badge)](https://coveralls.io/builds/23193858) Coverage increased (+0.03%) to 87.859% w

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf URL: https://github.com/apache/commons-collections/pull/70#discussion_r280995075 ## File path: src/main/java/org/apache/commons/collections4/bag/UnmodifiableBag.java ## @@ -128,6 +129,11 @@ public boolean

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf URL: https://github.com/apache/commons-collections/pull/70#discussion_r280995093 ## File path: src/main/java/org/apache/commons/collections4/bag/UnmodifiableBag.java ## @@ -128,6 +129,11 @@ public boolean

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf URL: https://github.com/apache/commons-collections/pull/70#discussion_r280995075 ## File path: src/main/java/org/apache/commons/collections4/bag/UnmodifiableBag.java ## @@ -128,6 +129,11 @@ public boolean

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf URL: https://github.com/apache/commons-collections/pull/70#discussion_r280994957 ## File path: src/main/java/org/apache/commons/collections4/collection/CompositeCollection.java ## @@ -313,6 +315,27 @@ pub

[GitHub] [commons-collections] morningmemo commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280988303 ## File path: src/main/java/org/apache/commons/collections4/collection/Co

[GitHub] [commons-collections] coveralls edited a comment on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
coveralls edited a comment on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#issuecomment-489336420 [![Coverage Status](https://coveralls.io/builds/23190095/badge)](https://coveralls.io/bui

[GitHub] [commons-collections] morningmemo commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280988303 ## File path: src/main/java/org/apache/commons/collections4/collection/Co

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986492 ## File path: src/main/java/org/apache/commons/collections4/collection/C

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986401 ## File path: src/main/java/org/apache/commons/collections4/set/Composite

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986537 ## File path: src/main/java/org/apache/commons/collections4/collection/I

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986556 ## File path: src/main/java/org/apache/commons/collections4/collection/U

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986584 ## File path: src/main/java/org/apache/commons/collections4/set/ListOrde

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986559 ## File path: src/main/java/org/apache/commons/collections4/collection/U

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986533 ## File path: src/main/java/org/apache/commons/collections4/collection/I

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986558 ## File path: src/main/java/org/apache/commons/collections4/collection/U

[GitHub] [commons-collections] garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
garydgregory commented on a change in pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#discussion_r280986569 ## File path: src/main/java/org/apache/commons/collections4/set/Composite

[GitHub] [commons-collections] morningmemo edited a comment on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo edited a comment on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#issuecomment-489338726 > -1 > > * Does not compile: https://travis-ci.org/apache/commons-collections/builds

[GitHub] [commons-collections] morningmemo commented on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo commented on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#issuecomment-489338726 > -1 > > * Does not compile: https://travis-ci.org/apache/commons-collections/builds/523391

[GitHub] [commons-collections] morningmemo closed pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo closed pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70 This is an automated message from the Apache Git Servic

[GitHub] [commons-collections] coveralls commented on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
coveralls commented on issue #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70#issuecomment-489336420 [![Coverage Status](https://coveralls.io/builds/23189274/badge)](https://coveralls.io/builds/231

[GitHub] [commons-collections] morningmemo opened a new pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo opened a new pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70 - Add removeIf to SynchronizedCollection - Add mac store files to gitignore

[GitHub] [commons-collections] morningmemo closed pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo closed pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70 This is an automated message from the Apache Git Servic

[GitHub] [commons-collections] morningmemo opened a new pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore

2019-05-04 Thread GitBox
morningmemo opened a new pull request #70: Add removeIf to SynchronizedCollection, Add mac store files to gitignore URL: https://github.com/apache/commons-collections/pull/70 - Add removeIf to SynchronizedCollection - Add mac store files to gitignore

[jira] [Commented] (IMAGING-221) updateExifMetadataLossless restructures meta data (and problems with Maker Notes)

2019-05-04 Thread Joakim Knudsen (JIRA)
[ https://issues.apache.org/jira/browse/IMAGING-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833054#comment-16833054 ] Joakim Knudsen commented on IMAGING-221: Yes, I'll post it tomorrow :-) > up

[jira] [Commented] (NET-660) Next and Previous IP Address in SubnetUtils.SubnetInfo

2019-05-04 Thread Nagabhushan S N (JIRA)
[ https://issues.apache.org/jira/browse/NET-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833052#comment-16833052 ] Nagabhushan S N commented on NET-660: - Like I mentioned, it'll be useful to have these.

[GitHub] [commons-codec] tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64.

2019-05-04 Thread GitBox
tmousaw-ptc commented on issue #19: CODEC-134: Update commons-codec to reject decoding any impossible string encoding for Base32 and Base64. URL: https://github.com/apache/commons-codec/pull/19#issuecomment-489318791 @aherbert - That may be a valid concern, but that code existed before this

[jira] [Commented] (NET-660) Next and Previous IP Address in SubnetUtils.SubnetInfo

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833043#comment-16833043 ] Sebb commented on NET-660: -- what is the use-case for these methods? > Next and Previous IP Address

[jira] [Resolved] (NET-664) SubnetUtils invalid address "1.1.125.52/32"

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-664. -- Resolution: Invalid See:   http://commons.apache.org/proper/commons-net/javadocs/api-3.6/org/apache/commons/net/util/Sub

[jira] [Commented] (NET-665) Support for multiple FTPFileFilters

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833040#comment-16833040 ] Sebb commented on NET-665: -- Patches (with unit tests and documentation) welcome > Support for mult

[jira] [Commented] (IMAGING-221) updateExifMetadataLossless restructures meta data (and problems with Maker Notes)

2019-05-04 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/IMAGING-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833037#comment-16833037 ] Bruno P. Kinoshita commented on IMAGING-221: [~joakimk] could you share the

[jira] [Resolved] (NET-646) ALLO FTP Command for files >2GB

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-646. -- Resolution: Fixed {color:#22}commit 39f8fa7a1e8386edc05d924932733e{color}{color:#22}a2f9b5fc6a{color} {color:#222

[jira] [Resolved] (NET-659) Java Doc FTPClient setControlKeepAliveTimeout() wrong comment

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-659. -- Resolution: Invalid The setControlKeepAliveTimeout parameter is in seconds (it is multiplied by 1000 before being stored

[jira] [Resolved] (NET-662) A question for variable naming

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-662. -- Resolution: Fixed The naming convention is largely historic.   Private vars mostly have a __ prefix and protected have _

[jira] [Resolved] (NET-667) FTP doesn't support size command

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-667. -- Resolution: Duplicate > FTP doesn't support size command > > > Key: NET-6

[jira] [Commented] (NET-667) FTP doesn't support size command

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833025#comment-16833025 ] Sebb commented on NET-667: -- Note that you should be able to use: http://commons.apache.org/proper/

[jira] [Commented] (NET-668) Commons net 3.5 and 3.6 have different implementation for uploading files over TFTP

2019-05-04 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/NET-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833015#comment-16833015 ] Sebb commented on NET-668: -- In what way is the functionality broken? It's not clear if the break o

[GitHub] [commons-net] sebbASF commented on issue #25: NET-405 Support for IPv6 in SubnetUtils

2019-05-04 Thread GitBox
sebbASF commented on issue #25: NET-405 Support for IPv6 in SubnetUtils URL: https://github.com/apache/commons-net/pull/25#issuecomment-489305669 The PR was against trunk The trunk branch was deleted as all Commons projects use maser rather than trunk. That automatically closed all PR

[GitHub] [commons-net] Umoxfo commented on a change in pull request #25: NET-405 Support for IPv6 in SubnetUtils

2019-05-04 Thread GitBox
Umoxfo commented on a change in pull request #25: NET-405 Support for IPv6 in SubnetUtils URL: https://github.com/apache/commons-net/pull/25#discussion_r280973373 ## File path: src/test/java/org/apache/commons/net/SubnetUtilsTest.java ## @@ -375,4 +375,52 @@ public void te