[GitHub] [commons-collections] dota17 opened a new pull request #107: Remove the parentheses in the error message in CircularFifoQueue

2019-10-31 Thread GitBox
dota17 opened a new pull request #107: Remove the parentheses in the error message in CircularFifoQueue URL: https://github.com/apache/commons-collections/pull/107 This is an automated message from the Apache Git Service.

[GitHub] [commons-collections] dota17 opened a new pull request #106: Add test cases for ArrayListValuedHashMapTest

2019-10-31 Thread GitBox
dota17 opened a new pull request #106: Add test cases for ArrayListValuedHashMapTest URL: https://github.com/apache/commons-collections/pull/106 Add test cases for ArrayListValuedHashMapTest to cover ArrayListValuedHashMap and AbstractListValuedMap

[GitHub] [commons-collections] dota17 opened a new pull request #105: Add three test cases in UnmodifiableQueueTest

2019-10-31 Thread GitBox
dota17 opened a new pull request #105: Add three test cases in UnmodifiableQueueTest URL: https://github.com/apache/commons-collections/pull/105 I modified the #101 PR. This is an automated message from the Apache Git

[GitHub] [commons-collections] dota17 closed pull request #101: Add three test cases in CircularFifoQueueTest

2019-10-31 Thread GitBox
dota17 closed pull request #101: Add three test cases in CircularFifoQueueTest URL: https://github.com/apache/commons-collections/pull/101 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (LANG-1498) Add support of lambda value evaluation for defaulting methods #416

2019-10-31 Thread Gary D. Gregory (Jira)
Gary D. Gregory created LANG-1498: - Summary: Add support of lambda value evaluation for defaulting methods #416 Key: LANG-1498 URL: https://issues.apache.org/jira/browse/LANG-1498 Project: Commons

[GitHub] [commons-collections] dota17 commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest

2019-10-31 Thread GitBox
dota17 commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest URL: https://github.com/apache/commons-collections/pull/101#discussion_r341419854 ## File path: src/test/java/org/apache/commons/collections4/queue/CircularFifoQueueTest.java

[GitHub] [commons-imaging] kinow commented on issue #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
kinow commented on issue #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#issuecomment-548580908 Thanks @christoffer-rydberg, Travis build is happy. Just need to find spare time + :coffee: to have a play, but everything looks

[GitHub] [commons-imaging] coveralls commented on issue #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
coveralls commented on issue #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#issuecomment-548580917 [![Coverage Status](https://coveralls.io/builds/26688391/badge)](https://coveralls.io/builds/26688391) Coverage increased

[GitHub] [commons-imaging] christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341378065 ## File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java

[GitHub] [commons-imaging] kinow commented on a change in pull request #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
kinow commented on a change in pull request #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341375144 ## File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java ## @@ -485,24

[GitHub] [commons-imaging] christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341373033 ## File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java

[GitHub] [commons-lang] coveralls edited a comment on issue #416: Add support of lazy default value evaluation for defaulting methods

2019-10-31 Thread GitBox
coveralls edited a comment on issue #416: Add support of lazy default value evaluation for defaulting methods URL: https://github.com/apache/commons-lang/pull/416#issuecomment-481641411 [![Coverage

[GitHub] [commons-io] Stzx commented on issue #81: Create issue

2019-10-31 Thread GitBox
Stzx commented on issue #81: Create issue URL: https://github.com/apache/commons-io/pull/81#issuecomment-548433988 It seems that you need a JIRA ticket. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (IO-554) FileUtils.copyToFile(InputStream source, File destination) should not close input stream

2019-10-31 Thread Thomas Mortagne (Jira)
[ https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964116#comment-16964116 ] Thomas Mortagne commented on IO-554: A release would definitely be nice, this is starting to be pretty

[jira] [Commented] (COLLECTIONS-728) BloomFilter contribution

2019-10-31 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964093#comment-16964093 ] Gilles Sadowski commented on COLLECTIONS-728: - bq. Yep, this was just a new look at a

[GitHub] [commons-collections] garydgregory commented on a change in pull request #91: Add drain method to CollectionUtils

2019-10-31 Thread GitBox
garydgregory commented on a change in pull request #91: Add drain method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/91#discussion_r341148939 ## File path: src/main/java/org/apache/commons/collections4/CollectionUtils.java ## @@ -1825,13

[GitHub] [commons-collections] garydgregory commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest

2019-10-31 Thread GitBox
garydgregory commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest URL: https://github.com/apache/commons-collections/pull/101#discussion_r341147017 ## File path: src/test/java/org/apache/commons/collections4/queue/CircularFifoQueueTest.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest

2019-10-31 Thread GitBox
garydgregory commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest URL: https://github.com/apache/commons-collections/pull/101#discussion_r341145906 ## File path: src/test/java/org/apache/commons/collections4/queue/CircularFifoQueueTest.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest

2019-10-31 Thread GitBox
garydgregory commented on a change in pull request #101: Add three test cases in CircularFifoQueueTest URL: https://github.com/apache/commons-collections/pull/101#discussion_r341146921 ## File path: src/test/java/org/apache/commons/collections4/queue/CircularFifoQueueTest.java

[GitHub] [commons-collections] garydgregory merged pull request #100: Add a test case AbstractMultiValuedMapTest testToString()

2019-10-31 Thread GitBox
garydgregory merged pull request #100: Add a test case AbstractMultiValuedMapTest testToString() URL: https://github.com/apache/commons-collections/pull/100 This is an automated message from the Apache Git Service. To

[GitHub] [commons-io] kinow commented on issue #64: Two small tweaks.

2019-10-31 Thread GitBox
kinow commented on issue #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#issuecomment-548311160 Thanks @wilx ! Build passing on Travis. @garydgregory I haven't looked at commons-io in a while. Would you be able to have another look at this PR and double check if

[GitHub] [commons-io] coveralls commented on issue #64: Two small tweaks.

2019-10-31 Thread GitBox
coveralls commented on issue #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#issuecomment-548310956 [![Coverage Status](https://coveralls.io/builds/26671018/badge)](https://coveralls.io/builds/26671018) Coverage remained the same at 89.41% when pulling

[GitHub] [commons-io] kinow commented on issue #64: Two small tweaks.

2019-10-31 Thread GitBox
kinow commented on issue #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#issuecomment-548282985 @wilx could you rebase your code on `master`, please? I had a look at Travis, and the build appears to be passing there, while failing for this PR. Hopefully something

[GitHub] [commons-io] kinow commented on a change in pull request #64: Two small tweaks.

2019-10-31 Thread GitBox
kinow commented on a change in pull request #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#discussion_r341030615 ## File path: src/main/java/org/apache/commons/io/FilenameUtils.java ## @@ -1385,11 +1386,11 @@ public static boolean

[GitHub] [commons-io] kinow commented on a change in pull request #64: Two small tweaks.

2019-10-31 Thread GitBox
kinow commented on a change in pull request #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#discussion_r257450883 ## File path: src/main/java/org/apache/commons/io/TaggedIOException.java ## @@ -129,7 +129,7 @@ public Serializable getTag() { *

[GitHub] [commons-io] kinow commented on a change in pull request #64: Two small tweaks.

2019-10-31 Thread GitBox
kinow commented on a change in pull request #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#discussion_r257450883 ## File path: src/main/java/org/apache/commons/io/TaggedIOException.java ## @@ -129,7 +129,7 @@ public Serializable getTag() { *

[GitHub] [commons-io] kinow commented on a change in pull request #64: Two small tweaks.

2019-10-31 Thread GitBox
kinow commented on a change in pull request #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#discussion_r257450883 ## File path: src/main/java/org/apache/commons/io/TaggedIOException.java ## @@ -129,7 +129,7 @@ public Serializable getTag() { *

[jira] [Commented] (JEXL-307) Variable redeclaration option

2019-10-31 Thread Dmitri Blinov (Jira)
[ https://issues.apache.org/jira/browse/JEXL-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963775#comment-16963775 ] Dmitri Blinov commented on JEXL-307: The following test case fails with NPE on the second parsing

[GitHub] [commons-collections] dota17 opened a new pull request #104: Update test cases

2019-10-31 Thread GitBox
dota17 opened a new pull request #104: Update test cases URL: https://github.com/apache/commons-collections/pull/104 1.Add three test cases in HashSetValuedHashMapTest 2.Update a test case in AbstractMultiValuedMapTest 3.Update a test case in TransformedMultiValuedMapTest

[GitHub] [commons-collections] dota17 opened a new pull request #103: Add junit for getWithNull and subList in the LazyListTest.

2019-10-31 Thread GitBox
dota17 opened a new pull request #103: Add junit for getWithNull and subList in the LazyListTest. URL: https://github.com/apache/commons-collections/pull/103 This is an automated message from the Apache Git Service. To

[GitHub] [commons-imaging] christoffer-rydberg commented on issue #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
christoffer-rydberg commented on issue #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#issuecomment-548253123 Thanks, I'll push an update to fix the mentioned issues.

[GitHub] [commons-imaging] kinow commented on a change in pull request #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
kinow commented on a change in pull request #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#discussion_r340994801 ## File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java ## @@ -492,17

[GitHub] [commons-imaging] christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF

2019-10-31 Thread GitBox
christoffer-rydberg commented on a change in pull request #55: Add support to read multiple images from GIF URL: https://github.com/apache/commons-imaging/pull/55#discussion_r340994486 ## File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java

[jira] [Commented] (COLLECTIONS-551) Move Iterable related methods from CollectionUtils to IterableUtils

2019-10-31 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963731#comment-16963731 ] Chen commented on COLLECTIONS-551: -- hi [~ggregory],I found that two pr of gonmarques in 2015 ( fix

[GitHub] [commons-collections] dota17 opened a new pull request #102: Add test cases in UnmodifiableMultiValuedMapTest

2019-10-31 Thread GitBox
dota17 opened a new pull request #102: Add test cases in UnmodifiableMultiValuedMapTest URL: https://github.com/apache/commons-collections/pull/102 This is an automated message from the Apache Git Service. To respond to the