[jira] [Work logged] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?focusedWorklogId=337988=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337988 ] ASF GitHub Bot logged work on COLLECTIONS-714: -- Author: ASF

[GitHub] [commons-collections] dota17 commented on a change in pull request #99: [COLLECTIONS-714] Throw exception when put \u0000 to trie

2019-11-03 Thread GitBox
dota17 commented on a change in pull request #99: [COLLECTIONS-714] Throw exception when put \u to trie URL: https://github.com/apache/commons-collections/pull/99#discussion_r341914871 ## File path:

[jira] [Work logged] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?focusedWorklogId=337987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337987 ] ASF GitHub Bot logged work on COLLECTIONS-714: -- Author: ASF

[GitHub] [commons-collections] dota17 commented on a change in pull request #99: [COLLECTIONS-714] Throw exception when put \u0000 to trie

2019-11-03 Thread GitBox
dota17 commented on a change in pull request #99: [COLLECTIONS-714] Throw exception when put \u to trie URL: https://github.com/apache/commons-collections/pull/99#discussion_r341914871 ## File path:

[jira] [Commented] (COLLECTIONS-546) Implement expiring queue like already exist PassiveExpiringMap

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966423#comment-16966423 ] Chen commented on COLLECTIONS-546: -- Hello, [~Suryakanth], [~tn],  Has this feature been

[jira] [Commented] (COLLECTIONS-520) Add a CopyOnWrite implementation of Map

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966381#comment-16966381 ] Chen commented on COLLECTIONS-520: -- So does this feature need to be implemented? > Add a

[jira] [Commented] (COLLECTIONS-585) When use commons collection 3.2.2, show "JavaSE not found"

2019-11-03 Thread Chen Guoping (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966380#comment-16966380 ] Chen Guoping commented on COLLECTIONS-585: -- Hi,neal zhang11. Can you close the issue?

[jira] [Commented] (COLLECTIONS-486) Update/Augment Sorted(Map|Set) implementations with Navigable(Map|Set)

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966378#comment-16966378 ] Chen commented on COLLECTIONS-486: -- Hi, [~tn]: Is it time to implement this ? > Update/Augment

[jira] [Comment Edited] (COLLECTIONS-533) Add a MultiValuedLinkedHashMap to preserve insertion order

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966366#comment-16966366 ] Chen edited comment on COLLECTIONS-533 at 11/4/19 2:23 AM: --- Hi,

[jira] [Comment Edited] (COLLECTIONS-663) Unexpected ConcurrentModificationException when altering Collection of a MultiValuedMap

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965277#comment-16965277 ] Chen edited comment on COLLECTIONS-663 at 11/4/19 2:21 AM: --- Hi,[~ggregory]

[jira] [Comment Edited] (COLLECTIONS-663) Unexpected ConcurrentModificationException when altering Collection of a MultiValuedMap

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965269#comment-16965269 ] Chen edited comment on COLLECTIONS-663 at 11/4/19 2:21 AM: --- Hello,

[jira] [Commented] (COLLECTIONS-533) Add a MultiValuedLinkedHashMap to preserve insertion order

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966366#comment-16966366 ] Chen commented on COLLECTIONS-533: -- Hi, [~dipanjan21] [~tn]  Now it is version 4.3. Has this

[jira] [Comment Edited] (COLLECTIONS-663) Unexpected ConcurrentModificationException when altering Collection of a MultiValuedMap

2019-11-03 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965277#comment-16965277 ] Chen edited comment on COLLECTIONS-663 at 11/4/19 2:16 AM: --- Hi,@Gary

[GitHub] [commons-compress] PeterAlfreadLee commented on issue #83: COMPRESS-342 random access of 7z files

2019-11-03 Thread GitBox
PeterAlfreadLee commented on issue #83: COMPRESS-342 random access of 7z files URL: https://github.com/apache/commons-compress/pull/83#issuecomment-549202064 @bodewig Sure. Thank you so much. I'll look into it and push my code today.

[jira] [Work logged] (COMPRESS-342) random access of 7z files

2019-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-342?focusedWorklogId=337895=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337895 ] ASF GitHub Bot logged work on COMPRESS-342: --- Author: ASF GitHub Bot

[GitHub] [commons-collections] garydgregory merged pull request #102: Add test cases in UnmodifiableMultiValuedMapTest

2019-11-03 Thread GitBox
garydgregory merged pull request #102: Add test cases in UnmodifiableMultiValuedMapTest URL: https://github.com/apache/commons-collections/pull/102 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-collections] garydgregory merged pull request #106: Add test cases to ArrayListValuedHashMapTest

2019-11-03 Thread GitBox
garydgregory merged pull request #106: Add test cases to ArrayListValuedHashMapTest URL: https://github.com/apache/commons-collections/pull/106 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-collections] garydgregory merged pull request #103: Add junit for getWithNull and subList in the LazyListTest.

2019-11-03 Thread GitBox
garydgregory merged pull request #103: Add junit for getWithNull and subList in the LazyListTest. URL: https://github.com/apache/commons-collections/pull/103 This is an automated message from the Apache Git Service. To

[GitHub] [commons-lang] garydgregory commented on a change in pull request #477: Lang 1463: StringUtils abbreviate returns String of length greater than maxWidth

2019-11-03 Thread GitBox
garydgregory commented on a change in pull request #477: Lang 1463: StringUtils abbreviate returns String of length greater than maxWidth URL: https://github.com/apache/commons-lang/pull/477#discussion_r341881451 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[jira] [Closed] (CONFIGURATION-768) XMLConfiguration#write does not indent XML elements.

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed CONFIGURATION-768. - Fix Version/s: 2.7 Resolution: Fixed In git master. >

[jira] [Updated] (CONFIGURATION-768) XMLConfiguration#write does not indent XML elements.

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CONFIGURATION-768: -- Issue Type: Bug (was: New Feature) > XMLConfiguration#write does not

[jira] [Created] (CONFIGURATION-768) XMLConfiguration#write does not indent XML elements.

2019-11-03 Thread Gary D. Gregory (Jira)
Gary D. Gregory created CONFIGURATION-768: - Summary: XMLConfiguration#write does not indent XML elements. Key: CONFIGURATION-768 URL: https://issues.apache.org/jira/browse/CONFIGURATION-768

[jira] [Closed] (CONFIGURATION-767) NullPointerException in XMLConfiguration#createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed CONFIGURATION-767. - > NullPointerException in XMLConfiguration#createTransformer() when no >

[jira] [Updated] (CONFIGURATION-767) NullPointerException in XMLConfiguration#createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CONFIGURATION-767: -- Description: You get a {{NullPointerException}} in

[jira] [Updated] (CONFIGURATION-767) NullPointerException in XMLConfiguration#createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CONFIGURATION-767: -- Description: You get a {{NullPointerException}} in

[jira] [Updated] (CONFIGURATION-767) NullPointerException in XMLConfiguration#createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CONFIGURATION-767: -- Description: You get a {{NullPointerException}} in

[jira] [Updated] (CONFIGURATION-767) NullPointerException in XMLConfiguration#createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CONFIGURATION-767: -- Summary: NullPointerException in XMLConfiguration#createTransformer()

[jira] [Created] (CONFIGURATION-767) NullPointerException in XMLConfiguration.createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
Gary D. Gregory created CONFIGURATION-767: - Summary: NullPointerException in XMLConfiguration.createTransformer() when no FileLocator is set Key: CONFIGURATION-767 URL:

[jira] [Updated] (CONFIGURATION-767) NullPointerException in XMLConfiguration.createTransformer() when no FileLocator is set

2019-11-03 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CONFIGURATION-767: -- Issue Type: Bug (was: New Feature) > NullPointerException in

[jira] [Reopened] (JEXL-307) Variable redeclaration option

2019-11-03 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro reopened JEXL-307: Latest test resists a little :). Trying to implement lexical stacks to restore symbol values in frame.

[GitHub] [commons-codec] garydgregory commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
garydgregory commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341867828 ## File path: src/test/java/org/apache/commons/codec/digest/MurmurHash3Test.java ## @@ -224,4 +224,68 @@ public void

[GitHub] [commons-codec] coveralls edited a comment on issue #27: Murmur3fix

2019-11-03 Thread GitBox
coveralls edited a comment on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-549122650 [![Coverage Status](https://coveralls.io/builds/26732092/badge)](https://coveralls.io/builds/26732092) Coverage remained the same at 92.779% when

[GitHub] [commons-codec] Claudenw commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
Claudenw commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341862805 ## File path: src/test/java/org/apache/commons/codec/digest/MurmurHash3Test.java ## @@ -224,4 +224,68 @@ public void

[GitHub] [commons-codec] Claudenw commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
Claudenw commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341862722 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -602,15 +613,19 @@ public final void add(final

[GitHub] [commons-codec] Claudenw commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
Claudenw commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341862707 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -393,7 +401,7 @@ public static long hash64(final

[GitHub] [commons-collections] aherbert commented on issue #83: WIP: Initial bloom filter code contribution

2019-11-03 Thread GitBox
aherbert commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-549148859 Are you timing using System.currentTimeMillis()? The data.csv contains only integer values and the times for the fast methods are

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-11-03 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-549147466 I built a test suite to see how fast the various options are. I used the GeoNames database as a datasource and built hashed the

[GitHub] [commons-codec] aherbert commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
aherbert commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341853086 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -393,7 +401,7 @@ public static long hash64(final

[GitHub] [commons-codec] aherbert commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
aherbert commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341852924 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -207,20 +211,24 @@ public static int hash32(final

[GitHub] [commons-codec] aherbert commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
aherbert commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341853923 ## File path: src/test/java/org/apache/commons/codec/digest/MurmurHash3Test.java ## @@ -224,4 +224,68 @@ public void

[GitHub] [commons-codec] aherbert commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
aherbert commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341852816 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -72,6 +75,7 @@ private static final int M =

[GitHub] [commons-codec] aherbert commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
aherbert commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341853959 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -407,22 +415,25 @@ public static long hash64(final

[GitHub] [commons-codec] aherbert commented on a change in pull request #27: Murmur3fix

2019-11-03 Thread GitBox
aherbert commented on a change in pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#discussion_r341853359 ## File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java ## @@ -602,15 +613,19 @@ public final void add(final

[GitHub] [commons-codec] melloware commented on issue #27: Murmur3fix

2019-11-03 Thread GitBox
melloware commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-549140225 I got the original implementation from Apache Hive assuming it was correct. See:

[GitHub] [commons-codec] melloware edited a comment on issue #27: Murmur3fix

2019-11-03 Thread GitBox
melloware edited a comment on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-549140225 I got the original implementation from Apache Hive assuming it was correct. See:

[jira] [Work logged] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?focusedWorklogId=337824=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337824 ] ASF GitHub Bot logged work on COLLECTIONS-714: -- Author: ASF

[GitHub] [commons-collections] melloware commented on a change in pull request #99: [COLLECTIONS-714] Throw exception when put \u0000 to trie

2019-11-03 Thread GitBox
melloware commented on a change in pull request #99: [COLLECTIONS-714] Throw exception when put \u to trie URL: https://github.com/apache/commons-collections/pull/99#discussion_r341851667 ## File path:

[GitHub] [commons-codec] coveralls edited a comment on issue #27: Murmur3fix

2019-11-03 Thread GitBox
coveralls edited a comment on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-549122650 [![Coverage Status](https://coveralls.io/builds/26729641/badge)](https://coveralls.io/builds/26729641) Coverage remained the same at 92.779% when

[jira] [Comment Edited] (CODEC-264) murmur3.hash64() does not account for unsigned in arguments

2019-11-03 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965662#comment-16965662 ] Claude Warren edited comment on CODEC-264 at 11/3/19 12:51 PM: --- Made 0xff

[jira] [Commented] (CODEC-264) murmur3.hash64() does not account for unsigned in arguments

2019-11-03 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965662#comment-16965662 ] Claude Warren commented on CODEC-264: - Made 0xff and 0xL static final vars and replace

[jira] [Commented] (CODEC-264) murmur3.hash64() does not account for unsigned in arguments

2019-11-03 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965649#comment-16965649 ] Gilles Sadowski commented on CODEC-264: --- Another nit: no magic numbers (in new code at least). If

[jira] [Commented] (CODEC-264) murmur3.hash64() does not account for unsigned in arguments

2019-11-03 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965646#comment-16965646 ] Gilles Sadowski commented on CODEC-264: --- If the changes could break existing applications (as you

[jira] [Commented] (CODEC-264) murmur3.hash64() does not account for unsigned in arguments

2019-11-03 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965645#comment-16965645 ] Gilles Sadowski commented on CODEC-264: --- There are formatting issues in the PR (alignment, tab). It

[GitHub] [commons-codec] coveralls commented on issue #27: Murmur3fix

2019-11-03 Thread GitBox
coveralls commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-549122650 [![Coverage Status](https://coveralls.io/builds/26728586/badge)](https://coveralls.io/builds/26728586) Coverage decreased (-0.07%) to 92.71% when pulling

[jira] [Commented] (CODEC-264) murmur3.hash64() does not account for unsigned in arguments

2019-11-03 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965640#comment-16965640 ] Claude Warren commented on CODEC-264: - The pull request to fix this issue > murmur3.hash64() does not

[GitHub] [commons-codec] Claudenw opened a new pull request #27: Murmur3fix

2019-11-03 Thread GitBox
Claudenw opened a new pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27 fix for CODEC-264 Fix for both 32 and 128 bit hashes. Additional test cases added including comments re: source of tests.

[jira] [Commented] (COLLECTIONS-728) BloomFilter contribution

2019-11-03 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965626#comment-16965626 ] Claude Warren commented on COLLECTIONS-728: --- Updated PR with following notes: I added