[jira] [Work logged] (LANG-1527) NumberUtils.createBigDecimal has a redundant argument check

2020-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1527?focusedWorklogId=403277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403277 ] ASF GitHub Bot logged work on LANG-1527: Author: ASF GitHub Bot

[GitHub] [commons-lang] Prodigysov opened a new pull request #504: LANG-1527: Remove an redundant argument check in NumberUtils

2020-03-13 Thread GitBox
Prodigysov opened a new pull request #504: LANG-1527: Remove an redundant argument check in NumberUtils URL: https://github.com/apache/commons-lang/pull/504 See [JIRA issue LANG-1527](https://issues.apache.org/jira/projects/LANG/issues/LANG-1527). -

[jira] [Created] (LANG-1527) NumberUtils.createBigDecimal has a redundant argument check

2020-03-13 Thread Pengyu Nie (Jira)
Pengyu Nie created LANG-1527: Summary: NumberUtils.createBigDecimal has a redundant argument check Key: LANG-1527 URL: https://issues.apache.org/jira/browse/LANG-1527 Project: Commons Lang Issue

[GitHub] [commons-collections] Claudenw commented on issue #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on issue #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#issuecomment-598966422 I think that if the javadoc changes are made: `log -> ln` and the lower limit on bits is dropped to 1 We can release merge this. -

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392521338 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -81,34 +83,36 @@

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392521338 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -81,34 +83,36 @@

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392518270 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -43,30 +43,32 @@ *

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392518270 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -43,30 +43,32 @@ *

[GitHub] [commons-collections] coveralls edited a comment on issue #140: Bloomfilter updates2

2020-03-13 Thread GitBox
coveralls edited a comment on issue #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#issuecomment-596978875 [![Coverage Status](https://coveralls.io/builds/29330923/badge)](https://coveralls.io/builds/29330923) Coverage increased (+0.04%) to

[jira] [Comment Edited] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Chen Tao (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058812#comment-17058812 ] Chen Tao edited comment on MATH-1524 at 3/13/20, 3:05 PM: -- I supp

[jira] [Commented] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Chen Tao (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058812#comment-17058812 ] Chen Tao commented on MATH-1524: I support Alex's design, the "ClusterPredictor" interface

[jira] [Commented] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058758#comment-17058758 ] Gilles Sadowski commented on MATH-1524: --- bq. This would be a change to the entire Cl

[jira] [Comment Edited] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058725#comment-17058725 ] Alex Herbert edited comment on MATH-1524 at 3/13/20, 1:46 PM: --

[jira] [Comment Edited] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058725#comment-17058725 ] Alex Herbert edited comment on MATH-1524 at 3/13/20, 1:45 PM: --

[jira] [Commented] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058725#comment-17058725 ] Alex Herbert commented on MATH-1524: {quote}Is the distance between a point and a clus

[jira] [Work logged] (MATH-1525) The "EmptyClusterStrategy" in KMeansPlusPlusClusterer should be move out as a Interface

2020-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MATH-1525?focusedWorklogId=402811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402811 ] ASF GitHub Bot logged work on MATH-1525: Author: ASF GitHub Bot

[GitHub] [commons-math] chentao106 opened a new pull request #126: #MATH-1525 Move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer

2020-03-13 Thread GitBox
chentao106 opened a new pull request #126: #MATH-1525 Move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer URL: https://github.com/apache/commons-math/pull/126 Move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer, it will reused by MiniBatchKMeansClusterer. ---

[jira] [Commented] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058706#comment-17058706 ] Gilles Sadowski commented on MATH-1524: --- {quote}It is the fastest method {quote} Que

[jira] [Commented] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Chen Tao (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058593#comment-17058593 ] Chen Tao commented on MATH-1524: {quote}Is the distance between a point and a cluster alwa

[jira] [Commented] (MATH-1524) "chooseInitialCenters" should move out from KMeansPlusPlusClusterer

2020-03-13 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058582#comment-17058582 ] Gilles Sadowski commented on MATH-1524: --- Is the distance between a point and a clust

[GitHub] [commons-collections] aherbert commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
aherbert commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392117139 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -81,34 +83,36 @@

[GitHub] [commons-collections] aherbert commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
aherbert commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392111047 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -81,34 +83,36 @@

[GitHub] [commons-collections] aherbert commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
aherbert commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392107680 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -43,30 +43,32 @@ *

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392095314 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -312,32 +402,18 @@ p

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392095157 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -43,30 +43,32 @@ *

[GitHub] [commons-collections] Claudenw commented on a change in pull request #140: Bloomfilter updates2

2020-03-13 Thread GitBox
Claudenw commented on a change in pull request #140: Bloomfilter updates2 URL: https://github.com/apache/commons-collections/pull/140#discussion_r392085172 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java ## @@ -81,34 +83,36 @@

[jira] [Comment Edited] (CSV-259) printWithEscapes gets StringIndexOutOfBoundsException when value is Reader

2020-03-13 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/CSV-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058485#comment-17058485 ] Chen edited comment on CSV-259 at 3/13/20, 8:00 AM: I found that the met

[GitHub] [commons-csv] dota17 opened a new pull request #61: fix isssue csv-259

2020-03-13 Thread GitBox
dota17 opened a new pull request #61: fix isssue csv-259 URL: https://github.com/apache/commons-csv/pull/61 fix isssue csv-259 [https://issues.apache.org/jira/browse/CSV-259](url) printWithEscapes gets StringIndexOutOfBoundsException when value is Reader -

[jira] [Commented] (CSV-259) printWithEscapes gets StringIndexOutOfBoundsException when value is Reader

2020-03-13 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/CSV-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058485#comment-17058485 ] Chen commented on CSV-259: -- I found that the method  {code:java} //代码占位符 printWithQuotes {code}   {

[jira] [Updated] (CSV-259) printWithEscapes gets StringIndexOutOfBoundsException when value is Reader

2020-03-13 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/CSV-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen updated CSV-259: - Description: {code:java} //代码占位符 @Test public void testPrintWithEscapeReader() throws IOException { final StringWriter s

[jira] [Created] (CSV-259) printWithEscapes gets StringIndexOutOfBoundsException when value is Reader

2020-03-13 Thread Chen (Jira)
Chen created CSV-259: Summary: printWithEscapes gets StringIndexOutOfBoundsException when value is Reader Key: CSV-259 URL: https://issues.apache.org/jira/browse/CSV-259 Project: Commons CSV Issue Type: