[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439363
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636646635
> > I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in one go?
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439360
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
kinow commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636643768
> I'd find it reasonable to consider your changes in batches of, say, ten
apiece. (That would make it possible to carefully inspect one by one.) But that
many in one go? Defini
[
https://issues.apache.org/jira/browse/LANG-1406?focusedWorklogId=439356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439356
]
ASF GitHub Bot logged work on LANG-1406:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1406?focusedWorklogId=439357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439357
]
ASF GitHub Bot logged work on LANG-1406:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1406?focusedWorklogId=439358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439358
]
ASF GitHub Bot logged work on LANG-1406:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1406?focusedWorklogId=439355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439355
]
ASF GitHub Bot logged work on LANG-1406:
Author: ASF GitHub Bot
kinow commented on pull request #340:
URL: https://github.com/apache/commons-lang/pull/340#issuecomment-636642377
Oh, actually the issue has been closed in #423! Closing the PR, but thanks
for your contribution @HiuKwok !
T
kinow commented on pull request #381:
URL: https://github.com/apache/commons-lang/pull/381#issuecomment-636642239
Oh, actually the issue has been closed in #423! Closing the PR, but thanks
for your contribution @drajakumar !
kinow closed pull request #340:
URL: https://github.com/apache/commons-lang/pull/340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kinow closed pull request #381:
URL: https://github.com/apache/commons-lang/pull/381
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/LANG-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120773#comment-17120773
]
Bruno P. Kinoshita commented on LANG-1326:
--
Oh, that is a good point I think. [~p
[
https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=439349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439349
]
ASF GitHub Bot logged work on LANG-1490:
Author: ASF GitHub Bot
kinow commented on a change in pull request #457:
URL: https://github.com/apache/commons-lang/pull/457#discussion_r433050850
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffView.java
##
@@ -0,0 +1,64 @@
+package org.apache.commons.lang3.builder;
Review comment
kinow commented on pull request #530:
URL: https://github.com/apache/commons-lang/pull/530#issuecomment-636621642
BTW, @TranNgocKhoa if you could rebase it, the build should pass. There were
checkstyle issues on master until recently.
--
[
https://issues.apache.org/jira/browse/LANG-1542?focusedWorklogId=439345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439345
]
ASF GitHub Bot logged work on LANG-1542:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1542?focusedWorklogId=439344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439344
]
ASF GitHub Bot logged work on LANG-1542:
Author: ASF GitHub Bot
kinow commented on pull request #530:
URL: https://github.com/apache/commons-lang/pull/530#issuecomment-636620127
Will leave it to @garydgregory to do the final review as he had requested
changes before :+1:
This is an auto
[
https://issues.apache.org/jira/browse/COMPRESS-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Lee updated COMPRESS-529:
---
Assignee: Peter Lee
> Tar decompression fails with runtime exceptions
> ---
[
https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120702#comment-17120702
]
Matt Juntunen commented on GEOMETRY-95:
---
bq. Did you remove the "uv-sphere" implem
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439297
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439298
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
XenoAmess edited a comment on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583
also want to split StringUtils.startswith, endwith, prependIfMissing...
now the call flow is like this:
1. user call startsWith(final CharSequence str, final Cha
XenoAmess commented on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583
also want to split StringUtils.startswith, endwith, prependIfMissing...
now the call flow is like this:
1. user call startsWith(final CharSequence str, final CharSequen
[
https://issues.apache.org/jira/browse/LANG-1549?focusedWorklogId=439296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439296
]
ASF GitHub Bot logged work on LANG-1549:
Author: ASF GitHub Bot
coveralls commented on pull request #535:
URL: https://github.com/apache/commons-lang/pull/535#issuecomment-636537530
[](https://coveralls.io/builds/31147261)
Coverage decreased (-0.03%) to 95.01% when pulling
**2def8
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439292
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
coveralls commented on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146
[](https://coveralls.io/builds/31146797)
Coverage decreased (-0.008%) to 95.033% when pulling
**52e
garydgregory commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636531069
Just wait. I have a query on the legal mailing list to check to see if we
can reuse the Infinispan version of its concurrent weak key hash map, and since
it is co-aut
garydgregory commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636530486
@jochenw glad it worked for you.
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439290
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
coveralls commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636529000
[](https://coveralls.io/builds/31146722)
Coverage decreased (-0.004%) to 95.036% when pulling
**62f
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636524987
my bad.
I found the reason why it can't pass, it is my mistake.
Now we can use `org.apache.commons.logging.impl.WeakHashtable ` to replace
`FastWeakHashMap`.
We
asfgit closed pull request #532:
URL: https://github.com/apache/commons-lang/pull/532
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jochenw commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636522760
Thanks, Gary, that helped.
One more thing, though: I do not feel responsible for this one:
[INFO] There is 1 error reported by Checkstyle 8.32 with src/site/reso
[
https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120633#comment-17120633
]
Gilles Sadowski commented on GEOMETRY-95:
-
bq. "icosphere"
Did you remove the "
[
https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439281
]
ASF GitHub Bot logged work on LANG-1547:
Author: ASF GitHub Bot
XenoAmess commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636512322
the performance refines I said has being splited to [LANG-1548] and
[LANG-1549]
This is an automated messa
JIN XU created LANG-1549:
Summary: implement TODO in CharSequenceUtils.lastIndexOf : remake
it.
Key: LANG-1549
URL: https://issues.apache.org/jira/browse/LANG-1549
Project: Commons Lang
Issue Type:
JIN XU created LANG-1548:
Summary: split regionMatches for better performance
Key: LANG-1548
URL: https://issues.apache.org/jira/browse/LANG-1548
Project: Commons Lang
Issue Type: Improvement
XenoAmess opened a new pull request #535:
URL: https://github.com/apache/commons-lang/pull/535
Hi.
If this change is accectable then I will start CharSequenceUtils.indexOf
using same way.
Though, need there be more tests about this function?
-
coveralls edited a comment on pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#issuecomment-616146181
[](https://coveralls.io/builds/31145020)
Coverage increased (+0.1%) to 93.982% when pulling
*
XenoAmess commented on pull request #48:
URL: https://github.com/apache/commons-codec/pull/48#issuecomment-636498741
> I wonder if we need both openjdk11 and oraclejdk11 ?
I thought it must be a reason to contain both in original travis-ci scripts,
so I didn't remove any of them.
-
XenoAmess edited a comment on pull request #48:
URL: https://github.com/apache/commons-codec/pull/48#issuecomment-636498741
> I wonder if we need both openjdk11 and oraclejdk11 ?
I thought there must be a reason to contain both in original travis-ci
scripts, so I didn't remove any of
[
https://issues.apache.org/jira/browse/LANG-1542?focusedWorklogId=439260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439260
]
ASF GitHub Bot logged work on LANG-1542:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #530:
URL: https://github.com/apache/commons-lang/pull/530#issuecomment-629603951
[](https://coveralls.io/builds/31144338)
Coverage increased (+0.0009%) to 95.092% when pullin
[
https://issues.apache.org/jira/browse/GEOMETRY-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120577#comment-17120577
]
Matt Juntunen commented on GEOMETRY-95:
---
I just added a PR containing the update {
darkma773r opened a new pull request #78:
URL: https://github.com/apache/commons-geometry/pull/78
- Improving Sphere.toTree()
- Removing use of HyperplaneSubset.Builder interface to improve performance
and numerical robustness
- Other updates to improve robustness with large BSP trees
garydgregory commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636481961
Do this:
```
git config core.autocrlf input
git checkout release
git checkout master
mvn checkstyle:check
```
-
XenoAmess edited a comment on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636474232
also here is some guy contributed a concurrent weak hash map too :
https://issues.apache.org/jira/browse/HARMONY-6434?jql=text%20~%20%22concurrent%20weak%20hash%20
[
https://issues.apache.org/jira/browse/COLLECTIONS-700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated COLLECTIONS-700:
Assignee: Gary D. Gregory
> Add a ConcurrentWeakHashMap
>
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636474232
also here is some guy contributed a concurrent weak hash map too :
https://issues.apache.org/jira/browse/HARMONY-6434?jql=text%20~%20%22concurrent%20weak%20hash%20map%22
XenoAmess edited a comment on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636470709
> IIRC I think someone contributed a concurrent weak hash map either in this
component or in commons-collections, there should be a JIRA ticket... AFK ATM...
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636470709
> IIRC I think someone contributed a concurrent weak hash map either in this
component or in commons-collections, there should be a JIRA ticket... AFK ATM...
well
garydgregory commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636466018
IIRC I think someone contributed a concurrent weak hash map either in this
component or in commons-collections, there should be a JIRA ticket... AFK ATM...
-
XenoAmess edited a comment on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636465013
> If your app does not need synchronization, you can use the map in "fast"
mode.
@garydgregory
Thanks. usually we need synchronization, and even when I
XenoAmess edited a comment on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636465013
> If your app does not need synchronization, you can use the map in "fast"
mode.
@garydgregory
Thanks. usually we need synchronization, and even when I
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636465013
> If your app does not need synchronization, you can use the map in "fast"
mode.
Thanks. usually we need synchronization, and even when I need weak reference
I wi
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636464477
@garydgregory is org.apache.commons.logging.impl.WeakHashtable a better
replacement of WeakFastHashMap in this cases?
--
garydgregory commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636463974
If your app does not need synchronization, you can use the map in "fast"
mode.
This is an automated
[
https://issues.apache.org/jira/browse/IO-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-669.
Fix Version/s: 2.7.1
Resolution: Fixed
Please review and close.
> fix code smells; fix typos
[
https://issues.apache.org/jira/browse/IO-669?focusedWorklogId=439224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439224
]
ASF GitHub Bot logged work on IO-669:
-
Author: ASF GitHub Bot
Cre
garydgregory merged pull request #115:
URL: https://github.com/apache/commons-io/pull/115
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
XenoAmess closed pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636462475
> -1. Do you understand the difference between a weak and strong reference
in a map? Do you you know what will happen if you install this change in an
application that k
[
https://issues.apache.org/jira/browse/COMPRESS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Bodewig resolved COMPRESS-532.
-
Fix Version/s: 1.21
Resolution: Fixed
fixed with commit 6bbc7cb1
> Decompressio
[
https://issues.apache.org/jira/browse/COMPRESS-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Bodewig resolved COMPRESS-531.
-
Fix Version/s: 1.21
Resolution: Fixed
> Tar decompression fails with NullPointer
[
https://issues.apache.org/jira/browse/COMPRESS-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120514#comment-17120514
]
Stefan Bodewig commented on COMPRESS-531:
-
Thanks to the fix of COMPRESS-530 th
melloware commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636458210
@garydgregory I am having a hard time resyncing my fork all the sudden. I am
getting this error "! refs/heads/master:refs/heads/master [remote rejected]
(refusing to all
[
https://issues.apache.org/jira/browse/COMPRESS-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120508#comment-17120508
]
Stefan Bodewig commented on COMPRESS-528:
-
I'm not sure your expectation is cor
garydgregory commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636457473
-1. Do you understand the difference between a weak and strong reference in
a map? Do you you know what will happen if you install this change in an
application that
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636457266
> Looks like you have some merge conflicts?
Sorry for that. will fix it immediately.
> Also I think this will resolve BEANUTILS-509: #21
I had no expe
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636457321
detailed output of Jprofile is attached at link :
https://issues.apache.org/jira/browse/BEANUTILS-539
T
[
https://issues.apache.org/jira/browse/COMPRESS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Bodewig resolved COMPRESS-530.
-
Fix Version/s: 1.21
Resolution: Fixed
> Tar decompression fails with NegativeArr
[
https://issues.apache.org/jira/browse/COMPRESS-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120506#comment-17120506
]
Stefan Bodewig commented on COMPRESS-529:
-
At least the two of us share the sam
melloware commented on pull request #23:
URL: https://github.com/apache/commons-beanutils/pull/23#issuecomment-636456327
Closing this PR. Will create a new one
This is an automated message from the Apache Git Service.
To res
melloware closed pull request #23:
URL: https://github.com/apache/commons-beanutils/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
melloware commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636456188
Looks like you have some merge conflicts?
Also I think this will resolve BEANUTILS-509:
https://github.com/apache/commons-beanutils/pull/21
-
jochenw commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636442299
Hi,
could someone please advise me, what I am doing wring here? Trying to pull
this in:
git clone https://gitbox.apache.org/repos/asf/commons-lang.git
XenoAmess commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636434614
> > > I got a build error when update my pull request today. What should I
do?
> > > Link: #530
> >
> >
> > your build passed, but check style failed.
> > a
XenoAmess opened a new pull request #534:
URL: https://github.com/apache/commons-lang/pull/534
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
TranNgocKhoa commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636433876
> > I got a build error when update my pull request today. What should I do?
> > Link: #530
>
> your build passed, but check style failed.
> and check style f
XenoAmess commented on pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27#issuecomment-636433256
feel free to ask for changes about this test, I will help to run it.
Then we decide whether change usage of WeakHashMap to CuncurrentHashMap, or
remain what it looks l
[
https://issues.apache.org/jira/browse/BEANUTILS-539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU updated BEANUTILS-539:
-
Description:
Hi.
throughtout my performance test (using Jprofiler), I found out WeakHashMap is
far s
XenoAmess opened a new pull request #27:
URL: https://github.com/apache/commons-beanutils/pull/27
throughtout my performance test (using Jprofiler), I found out WeakHashMap
is far slower than ConcurrentHashMap.
add tests to show how slow it is.
please run it using Jprofiler or other t
[
https://issues.apache.org/jira/browse/BEANUTILS-539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU updated BEANUTILS-539:
-
Description:
Hi.
throughtout my performance test (using Jprofiler), I found out WeakHashMap is
far s
XenoAmess commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636432421
> I got a build error when update my pull request today. What should I do?
> Link: #530
your build passed, but check style failed.
and check style failed because
[
https://issues.apache.org/jira/browse/EMAIL-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120440#comment-17120440
]
JIN XU commented on EMAIL-193:
--
Sorry this is a misoperation.
this bug shall be commited to
JIN XU created BEANUTILS-539:
Summary: use ConcurrentHashMap insteadof WeakFastHashMap
Key: BEANUTILS-539
URL: https://issues.apache.org/jira/browse/BEANUTILS-539
Project: Commons BeanUtils
Issue
JIN XU created EMAIL-193:
Summary: use ConcurrentHashMap insteadof WeakHashMap
Key: EMAIL-193
URL: https://issues.apache.org/jira/browse/EMAIL-193
Project: Commons Email
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/EMAIL-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JIN XU closed EMAIL-193.
Resolution: Not A Problem
> use ConcurrentHashMap insteadof WeakHashMap
> --
92 matches
Mail list logo
