[GitHub] [commons-math] XenoAmess edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
XenoAmess edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645816424 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-math] XenoAmess edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
XenoAmess edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645816424 > @XenoAmess So could you please help me out in knowing the right person who can review the PR. @bhawna94 Gilles Sadowski seems the most active official

[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
XenoAmess commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645816424 > @XenoAmess So could you please help me out in knowing the right person who can review the PR. Gilles Sadowski seems the most active official committer in this repo.

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645812981 @XenoAmess So could you please help me out in knowing the right person who can review the PR. This is an

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @efge @chentao106 @XenoAmess Could you please review the PR and let me know your thoughts -

[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
XenoAmess commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645806014 @bhawna94 Hi. I'm not any official guy of this repo so calling me is pointless... also, @asfgit is just a robot for sync so calling him is pointless either... btw I fe

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @efge @chentao106 @XenoAmess Could you please review the PR and let me know your thoughts -

[jira] [Commented] (CLI-255) DefaultParser, option with long name and single dash, unlimited arguments

2020-06-17 Thread chenshuming (Jira)
[ https://issues.apache.org/jira/browse/CLI-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138940#comment-17138940 ] chenshuming commented on CLI-255: - Hi, I was using the follow test case in 1.5-SNAPSHOT. And

[GitHub] [commons-csv] coveralls commented on pull request #77: Fix null, emptyString, nullString

2020-06-17 Thread GitBox
coveralls commented on pull request #77: URL: https://github.com/apache/commons-csv/pull/77#issuecomment-645399963 [![Coverage Status](https://coveralls.io/builds/31512182/badge)](https://coveralls.io/builds/31512182) Coverage increased (+0.01%) to 98.519% when pulling **6a51193

[GitHub] [commons-csv] dota17 opened a new pull request #77: Fix null, emptyString, nullString

2020-06-17 Thread GitBox
dota17 opened a new pull request #77: URL: https://github.com/apache/commons-csv/pull/77 * https://issues.apache.org/jira/projects/CSV/issues/CSV-93 * https://issues.apache.org/jira/projects/CSV/issues/CSV-253 When QuoteMode: ALL_NON_NULL (Quotes all non-null fields), we can disti

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @efge @chentao106 Could you please review the PR and let me know your thoughts ---

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @efge Could you please review the PR and let me know your thoughts

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit Could you please review the PR and let me know your thoughts -

[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645163584 @olamy @epugh @jukka @dims @brettporter @asfgit @jodastephen @jfclere Could you please review the PR and let me know your thoughts ---

[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
bhawna94 commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645284882 Exactly @ayushhooda I am using shorthand here for the false condition. @jochenw Both the things are identical **object instanceof Foo == false** and **!(objec

[GitHub] [commons-lang] coveralls commented on pull request #556: Fixed Javadocs for setTestRecursive()

2020-06-17 Thread GitBox
coveralls commented on pull request #556: URL: https://github.com/apache/commons-lang/pull/556#issuecomment-645284073 [![Coverage Status](https://coveralls.io/builds/31507152/badge)](https://coveralls.io/builds/31507152) Coverage remained the same at 95.026% when pulling **96a00

[GitHub] [commons-math] ayushhooda commented on pull request #146: Simplify if condition

2020-06-17 Thread GitBox
ayushhooda commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-645281433 @jochenw It seems to be very much correct. ! Operator is nothing but a shorthand for false condition This

[jira] [Commented] (LANG-1567) Javadoc error in EqualsBuilder.setTestRecursive()

2020-06-17 Thread Miguel Munoz (Jira)
[ https://issues.apache.org/jira/browse/LANG-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138283#comment-17138283 ] Miguel Munoz commented on LANG-1567: Created pull request: [https://github.com/apache/

[GitHub] [commons-lang] SwingGuy1024 opened a new pull request #556: Fixed Javadocs for setTestRecursive()

2020-06-17 Thread GitBox
SwingGuy1024 opened a new pull request #556: URL: https://github.com/apache/commons-lang/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a