Amita Pradhan created COLLECTIONS-767:
-
Summary: A MapBuilder to help decide which type to Map to use
Key: COLLECTIONS-767
URL: https://issues.apache.org/jira/browse/COLLECTIONS-767
Project:
Amita-Pradhan commented on a change in pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#discussion_r499158767
##
File path: src/main/java/org/apache/commons/collections4/MapBuilder.java
##
@@ -0,0 +1,115 @@
+package
Amita-Pradhan commented on a change in pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#discussion_r499158581
##
File path: src/test/java/org/apache/commons/collections4/MapBuilderTest.java
##
@@ -0,0 +1,122 @@
+package
Amita-Pradhan commented on a change in pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#discussion_r499158435
##
File path: src/test/java/org/apache/commons/collections4/MapBuilderTest.java
##
@@ -0,0 +1,122 @@
+package
Amita-Pradhan commented on a change in pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#discussion_r499158421
##
File path: src/main/java/org/apache/commons/collections4/MapBuilder.java
##
@@ -0,0 +1,115 @@
+package
Amita-Pradhan commented on a change in pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#discussion_r499158349
##
File path: src/main/java/org/apache/commons/collections4/MapBuilder.java
##
@@ -0,0 +1,115 @@
+package
Amita-Pradhan commented on a change in pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#discussion_r499158324
##
File path: src/main/java/org/apache/commons/collections4/MapBuilder.java
##
@@ -0,0 +1,115 @@
+package
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charlie closed NET-689.
---
Verified working in 3.7.2-SNAPSHOT 7827f0549526920b91aa2e62d2a1e7682c36e1e7
> Hostname is not set on the SSLSocket causing
garydgregory merged pull request #47:
URL: https://github.com/apache/commons-pool/pull/47
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory merged pull request #48:
URL: https://github.com/apache/commons-pool/pull/48
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory merged pull request #623:
URL: https://github.com/apache/commons-lang/pull/623
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206711#comment-17206711
]
Gary D. Gregory commented on NET-689:
-
>verify
Verify that the behavior in git master is correct.
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206705#comment-17206705
]
Charlie commented on NET-689:
-
I can see that the code has been merged into commons-net master, with more
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206703#comment-17206703
]
Charlie edited comment on NET-689 at 10/3/20, 1:57 PM:
---
Hi [~ggregory]
I don't
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206703#comment-17206703
]
Charlie commented on NET-689:
-
Hi Gary,
I don't understand what you mean?
Different tests?
What do you mean
tobias- commented on pull request #63:
URL: https://github.com/apache/commons-net/pull/63#issuecomment-703107399
@garydgregory Ok, now I understand your comment. You merged the PR in
another system. Either way, my answer stands, It's impossible to add that line
without a valid
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved NET-689.
-
Fix Version/s: 3.7.2
Resolution: Fixed
Hi [~ck1962]
In git master with different tests.
tobias- commented on pull request #63:
URL: https://github.com/apache/commons-net/pull/63#issuecomment-703105797
@garydgregory Uhmm.. I understand that you get shit PR's, but can you allow
me more than 10 minutes to answer your question before closing my PR?
tobias- commented on pull request #63:
URL: https://github.com/apache/commons-net/pull/63#issuecomment-703105613
> Hi @tobias-
> You issue description mentions:
>
> ```
> client.setTrustManager(TrustManagerUtils.getDefaultTrustManager(null))
> ```
>
> but I do not see
garydgregory closed pull request #63:
URL: https://github.com/apache/commons-net/pull/63
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on pull request #63:
URL: https://github.com/apache/commons-net/pull/63#issuecomment-703105508
Thank you for your patch but please still reply to my query above.
Committed with:
```
commit 7827f0549526920b91aa2e62d2a1e7682c36e1e7
Author: Gary Gregory
garydgregory commented on pull request #63:
URL: https://github.com/apache/commons-net/pull/63#issuecomment-703103559
Hi @tobias-
You issue description mentions:
```
client.setTrustManager(TrustManagerUtils.getDefaultTrustManager(null))
```
but I do not see that in this PR.
garydgregory merged pull request #62:
URL: https://github.com/apache/commons-net/pull/62
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/BCEL-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206686#comment-17206686
]
Allon Mureinik commented on BCEL-342:
-
I pushed the following PR to GitHub to address this suggestion:
mureinik opened a new pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68
This PR migrates the project to the modern JUnit Jupiter in order to make it
easier to write tests for it and lower the entry bar for new contributors.
While JUnit 4 and JUnit Jupiter are
Allon Mureinik created BCEL-342:
---
Summary: Upgrade testing framework to JUnit Jupiter
Key: BCEL-342
URL: https://issues.apache.org/jira/browse/BCEL-342
Project: Commons BCEL
Issue Type: Task
tobias- commented on pull request #63:
URL: https://github.com/apache/commons-net/pull/63#issuecomment-703090041
This is for issue https://issues.apache.org/jira/browse/NET-689
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/TEXT-188?focusedWorklogId=494266=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-494266
]
ASF GitHub Bot logged work on TEXT-188:
---
Author: ASF GitHub Bot
kinow commented on a change in pull request #174:
URL: https://github.com/apache/commons-text/pull/174#discussion_r499134695
##
File path:
src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
##
@@ -285,6 +286,11 @@ private static int
[
https://issues.apache.org/jira/browse/TEXT-188?focusedWorklogId=494265=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-494265
]
ASF GitHub Bot logged work on TEXT-188:
---
Author: ASF GitHub Bot
vesterstroem commented on a change in pull request #174:
URL: https://github.com/apache/commons-text/pull/174#discussion_r499133321
##
File path:
src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
##
@@ -285,6 +286,11 @@ private static int
[
https://issues.apache.org/jira/browse/NET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206618#comment-17206618
]
Charlie commented on NET-689:
-
[https://github.com/apache/commons-net/pull/63]
> Hostname is not set on the
tobias- opened a new pull request #63:
URL: https://github.com/apache/commons-net/pull/63
Previously, the ip was used in hostname validation, causing it
to always fail unless the ip was in the certificate making MitM
easy.
By adding the following two lines, the validation of
33 matches
Mail list logo
