[
https://issues.apache.org/jira/browse/LANG-1544?focusedWorklogId=495712=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495712
]
ASF GitHub Bot logged work on LANG-1544:
Author: ASF GitHub Bot
pixelr edited a comment on pull request #583:
URL: https://github.com/apache/commons-lang/pull/583#issuecomment-704019436
> Hi @pixelr
>
> After looking again, I'm not sure this PR makes sense. The test you
patched calls a private method, and this private method is not going to be
[
https://issues.apache.org/jira/browse/LANG-1544?focusedWorklogId=495711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495711
]
ASF GitHub Bot logged work on LANG-1544:
Author: ASF GitHub Bot
pixelr commented on pull request #583:
URL: https://github.com/apache/commons-lang/pull/583#issuecomment-704019436
> Hi @pixelr
>
> After looking again, I'm not sure this PR makes sense. The test you
patched calls a private method, and this private method is not going to be
called
[
https://issues.apache.org/jira/browse/LANG-1544?focusedWorklogId=495710=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495710
]
ASF GitHub Bot logged work on LANG-1544:
Author: ASF GitHub Bot
pixelr commented on pull request #583:
URL: https://github.com/apache/commons-lang/pull/583#issuecomment-704019077
> Is there example user-side codes which can lead to NPE before this pr?
@XenoAmess I took this a first good issue to fix. But, when I tried
reproducing it, I am not
[
https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208481#comment-17208481
]
Prabhakar Kumar Shah commented on LANG-1544:
[~nagy_peter] Hi, could you provide a real code
[
https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208436#comment-17208436
]
Gary D. Gregory commented on BCEL-343:
--
Go for it!
> Improve assertions
> --
>
>
[
https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208341#comment-17208341
]
Allon Mureinik commented on BCEL-343:
-
I'm looking into this.
Not quite sure what the rules about the
Allon Mureinik created BCEL-343:
---
Summary: Improve assertions
Key: BCEL-343
URL: https://issues.apache.org/jira/browse/BCEL-343
Project: Commons BCEL
Issue Type: Task
Components:
[
https://issues.apache.org/jira/browse/BCEL-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik closed BCEL-342.
---
Verified the code was indeed merged to master, closing.
> Upgrade testing framework to JUnit Jupiter
>
[
https://issues.apache.org/jira/browse/BCEL-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved BCEL-342.
--
Fix Version/s: 6.5.1
Resolution: Fixed
[~mureinik]
In git master, please verify the repo
garydgregory commented on pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68#issuecomment-703809623
Another PR after this one is fine. I will merge...
This is an automated message from the Apache Git
garydgregory merged pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
coveralls commented on pull request #188:
URL:
https://github.com/apache/commons-collections/pull/188#issuecomment-703805362
[](https://coveralls.io/builds/33940951)
Coverage increased (+0.001%) to 90.129% when
[
https://issues.apache.org/jira/browse/COLLECTIONS-767?focusedWorklogId=495492=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495492
]
ASF GitHub Bot logged work on COLLECTIONS-767:
--
Author: ASF
mureinik edited a comment on pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68#issuecomment-703773998
@garydgregory I can definitely look into that, but I think it would be
better to do that in a separate PR.
This MR is quite large as is, and the more changes we add
mureinik commented on pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68#issuecomment-703773998
@garydgregory I can definitely look into that, but I think it would be
better to do that in a separate MR.
This MR is quite large as is, and the more changes we add to it,
[
https://issues.apache.org/jira/browse/JCS-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Vandahl resolved JCS-206.
Fix Version/s: jcs-3.0
Resolution: Fixed
Published missing files
> Fix the homepage
>
[
https://issues.apache.org/jira/browse/CONFIGURATION-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208113#comment-17208113
]
Gary D. Gregory commented on CONFIGURATION-793:
---
[~mipper]
Thank you for your
[
https://issues.apache.org/jira/browse/JCS-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Vandahl updated JCS-206:
---
Assignee: Thomas Vandahl
> Fix the homepage
>
>
> Key: JCS-206
>
[
https://issues.apache.org/jira/browse/CONFIGURATION-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208113#comment-17208113
]
Gary D. Gregory edited comment on CONFIGURATION-793 at 10/5/20, 2:37 PM:
garydgregory commented on a change in pull request #68:
URL: https://github.com/apache/commons-dbcp/pull/68#discussion_r499646275
##
File path: src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
##
@@ -94,6 +100,8 @@
private Integer
garydgregory commented on pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68#issuecomment-703671353
@mureinik
That is the info I was looking for, for master ATM, I get 45%.
For JUnit 5, I wonder if using the Assertions APIs with messages as
Supplier would be
coveralls edited a comment on pull request #114:
URL: https://github.com/apache/commons-csv/pull/114#issuecomment-702969045
[](https://coveralls.io/builds/33933379)
Coverage increased (+0.01%) to 98.521% when pulling
[
https://issues.apache.org/jira/browse/CSV-264?focusedWorklogId=495334=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495334
]
ASF GitHub Bot logged work on CSV-264:
--
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/CSV-264?focusedWorklogId=495313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495313
]
ASF GitHub Bot logged work on CSV-264:
--
Author: ASF GitHub Bot
SethiPandi commented on pull request #114:
URL: https://github.com/apache/commons-csv/pull/114#issuecomment-703626038
Sorry about that, I rebased master and applied the changes requested.
I believe this should be good now, though I'll take a peek at the
unsuccessful checks now.
I
[
https://issues.apache.org/jira/browse/CSV-264?focusedWorklogId=495311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495311
]
ASF GitHub Bot logged work on CSV-264:
--
Author: ASF GitHub Bot
coveralls edited a comment on pull request #114:
URL: https://github.com/apache/commons-csv/pull/114#issuecomment-702969045
[](https://coveralls.io/builds/33932397)
Coverage decreased (-0.08%) to 98.422% when pulling
[
https://issues.apache.org/jira/browse/TEXT-188?focusedWorklogId=495232=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495232
]
ASF GitHub Bot logged work on TEXT-188:
---
Author: ASF GitHub Bot
vesterstroem commented on pull request #174:
URL: https://github.com/apache/commons-text/pull/174#issuecomment-703518174
> Merged, with changelog added for 1.9.1. Thanks @vesterstroem
You're welcome :-)
This is an
mureinik commented on pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68#issuecomment-703490743
@garydgregory I observed 46% coverage both on the master branch and on this
branch, although I admit I didn't dig deeper into specific package/class
coverage - which kind of
dependabot[bot] opened a new pull request #135:
URL: https://github.com/apache/commons-vfs/pull/135
Bumps [jcl-over-slf4j](https://github.com/qos-ch/slf4j) from 1.7.26 to
1.7.30.
Commits
https://github.com/qos-ch/slf4j/commit/0b97c416e42a184ff9728877b461c616187c58f7;>0b97c41
dependabot[bot] opened a new pull request #134:
URL: https://github.com/apache/commons-vfs/pull/134
Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.26 to 1.7.30.
Commits
https://github.com/qos-ch/slf4j/commit/0b97c416e42a184ff9728877b461c616187c58f7;>0b97c41
35 matches
Mail list logo
