[GitHub] [commons-vfs] boris-petrov commented on pull request #151: Refactor getOutputStream

boris-petrov commented on pull request #151: URL: https://github.com/apache/commons-vfs/pull/151#issuecomment-747262438 @garydgregory - I rebased and added TODOs instead of changing the methods so that we remember to do it for the next major version.

[GitHub] [commons-vfs] boris-petrov commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

boris-petrov commented on pull request #150: URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-747258709 @garydgregory - done! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-beanutils] arturobernalg opened a new pull request #54: Minor Improvement

arturobernalg opened a new pull request #54: URL: https://github.com/apache/commons-beanutils/pull/54 * Add Final * change While loop This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544828632 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -50,61 +51,29 @@ public

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

darkma773r commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544768403 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -50,61 +51,29 @@ public static

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

darkma773r commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544767499 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -50,61 +51,29 @@ public static

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

darkma773r commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544764724 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/AbstractConvexHyperplaneBoundedRegionTest.java

[jira] [Commented] (GEOMETRY-108) BoundaryList Implementations

[ https://issues.apache.org/jira/browse/GEOMETRY-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250748#comment-17250748 ] Matt Juntunen commented on GEOMETRY-108: I plan on merging this tomorrow unless anyone objects.

[jira] [Issue Comment Deleted] (VALIDATOR-390) Upgrade to Commons Collections 4.x

[ https://issues.apache.org/jira/browse/VALIDATOR-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taufiq Hoven updated VALIDATOR-390: --- Comment: was deleted (was: With the identification of security vulnerabilities in

[jira] [Comment Edited] (VALIDATOR-390) Upgrade to Commons Collections 4.x

[ https://issues.apache.org/jira/browse/VALIDATOR-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250723#comment-17250723 ] Taufiq Hoven edited comment on VALIDATOR-390 at 12/17/20, 1:47 AM: ---

[jira] [Comment Edited] (VALIDATOR-390) Upgrade to Commons Collections 4.x

[ https://issues.apache.org/jira/browse/VALIDATOR-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250723#comment-17250723 ] Taufiq Hoven edited comment on VALIDATOR-390 at 12/17/20, 1:46 AM: ---

[jira] [Commented] (VALIDATOR-390) Upgrade to Commons Collections 4.x

[ https://issues.apache.org/jira/browse/VALIDATOR-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250723#comment-17250723 ] Taufiq Hoven commented on VALIDATOR-390: With the identification of security vulnerabilities

[jira] [Created] (LANG-1627) BooleanUtils.xor not behaving as expected with any odd number of true's

Alberto Scotto created LANG-1627: Summary: BooleanUtils.xor not behaving as expected with any odd number of true's Key: LANG-1627 URL: https://issues.apache.org/jira/browse/LANG-1627 Project: Commons

[GitHub] [commons-vfs] garydgregory edited a comment on pull request #151: Refactor getOutputStream

garydgregory edited a comment on pull request #151: URL: https://github.com/apache/commons-vfs/pull/151#issuecomment-747077862 Hi @boris-petrov As you can now see in the build output, this PR breaks binary compatibility. We can't do that within a major version, in this case, within the

[GitHub] [commons-vfs] garydgregory commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

garydgregory commented on pull request #150: URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-747078789 Hi @boris-petrov Please rebase on git master. TY! This is an automated message from the Apache

[GitHub] [commons-vfs] garydgregory commented on pull request #151: Refactor getOutputStream

garydgregory commented on pull request #151: URL: https://github.com/apache/commons-vfs/pull/151#issuecomment-747077862 Hi @boris-petrov As you can now see in the build output, this PR breaks binary compatibility. We can't do that within a major version, in this case, within the 2.x.y

[GitHub] [commons-vfs] garydgregory merged pull request #145: Modify some calls of method Collection.toArray

garydgregory merged pull request #145: URL: https://github.com/apache/commons-vfs/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-vfs] boris-petrov commented on pull request #151: Refactor getOutputStream

boris-petrov commented on pull request #151: URL: https://github.com/apache/commons-vfs/pull/151#issuecomment-747028763 @garydgregory - done. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-vfs] garydgregory commented on pull request #151: Refactor getOutputStream

garydgregory commented on pull request #151: URL: https://github.com/apache/commons-vfs/pull/151#issuecomment-747011176 Hi @boris-petrov Please rebase on git master to pick up the default Maven build for GitHub This is

[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5

arturobernalg commented on pull request #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-746971803 Hi @garydgregory you're right, I didn't realize that it actually requires version 1.7. How can i start the process to migrate the libs to java 1.8?

[jira] [Work logged] (IO-429) ByteArrayOutputStream can overflow

[ https://issues.apache.org/jira/browse/IO-429?focusedWorklogId=525244=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-525244 ] ASF GitHub Bot logged work on IO-429: - Author: ASF GitHub Bot Created

[GitHub] [commons-io] leskin-in commented on pull request #175: IO-429: Check for long streams in IOUtils.toByteArray

leskin-in commented on pull request #175: URL: https://github.com/apache/commons-io/pull/175#issuecomment-746962320 @garydgregory thank you for your [comment](https://github.com/apache/commons-io/pull/175#issuecomment-745740037). I have

[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544599521 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -88,23 +70,15 @@ public

[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544599428 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -50,35 +50,17 @@ public

[GitHub] [commons-geometry] arturobernalg commented on pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#issuecomment-746957655 Hi @singhbaljit I have made all the changes except the import. IMO i't not a good practice use wildcard. could lead to conflicts or errors

[GitHub] [commons-geometry] singhbaljit commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

singhbaljit commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544480779 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -50,35 +50,17 @@ public

[GitHub] [commons-geometry] singhbaljit commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

singhbaljit commented on a change in pull request #121: URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544480779 ## File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/GeometryTestUtils.java ## @@ -50,35 +50,17 @@ public

[GitHub] [commons-vfs] boris-petrov commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

boris-petrov commented on pull request #150: URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-746511940 @garydgregory - I spent a lot of time trying to figure what's going on. I give up. This test failure is definitely a bug in the `RamFileProvider` but it is difficult to

[GitHub] [commons-vfs] boris-petrov opened a new pull request #151: Refactor getOutputStream

boris-petrov opened a new pull request #151: URL: https://github.com/apache/commons-vfs/pull/151 I'm not sure whether changing the visibility of `AbstractFileObject.getOutputStream` and marking it as `final` is not a breaking change. This change is not *strictly* needed but I did it to

[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #112: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on a change in pull request #112: URL: https://github.com/apache/commons-geometry/pull/112#discussion_r544393727 ## File path: commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Bounds3DTest.java ## @@ -125,29 +125,12

[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #112: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on a change in pull request #112: URL: https://github.com/apache/commons-geometry/pull/112#discussion_r544393727 ## File path: commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Bounds3DTest.java ## @@ -125,29 +125,12

[GitHub] [commons-geometry] arturobernalg commented on a change in pull request #112: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg commented on a change in pull request #112: URL: https://github.com/apache/commons-geometry/pull/112#discussion_r544393727 ## File path: commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Bounds3DTest.java ## @@ -125,29 +125,12

[GitHub] [commons-geometry] arturobernalg opened a new pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg opened a new pull request #121: URL: https://github.com/apache/commons-geometry/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [commons-geometry] arturobernalg closed pull request #112: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

arturobernalg closed pull request #112: URL: https://github.com/apache/commons-geometry/pull/112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-io] michielgkalkman commented on pull request #174: Restructure moveDirectoryToDirectory

michielgkalkman commented on pull request #174: URL: https://github.com/apache/commons-io/pull/174#issuecomment-746200897 No, in the original code, when the destination directory already exists, you do an exists() on this directory in lines 2173 and 2178 before isDirectory() is executed.

[jira] [Work logged] (LANG-1444) NumberUtils.createNumber() does not create BigDecimal for decimal fractions tending to zero

[ https://issues.apache.org/jira/browse/LANG-1444?focusedWorklogId=524993=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524993 ] ASF GitHub Bot logged work on LANG-1444: Author: ASF GitHub Bot

[GitHub] [commons-lang] bndhanush edited a comment on pull request #675: LANG-1444

bndhanush edited a comment on pull request #675: URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745846181 Hi @garydgregory, Thank you for the notice. I have fixed the formatting issue. I see it is ok for the 16-ea build to fail, is that correct understanding?

[jira] [Updated] (POOL-391) GenericKeyedObjectPool is not thread safe when invoke method `borrowObject` and `destroy` simultaneously

[ https://issues.apache.org/jira/browse/POOL-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Codievilky August updated POOL-391: --- Description: The method `brrowObject` is not thread safe with `destroy` or `clear` method.

[jira] [Work logged] (LANG-1444) NumberUtils.createNumber() does not create BigDecimal for decimal fractions tending to zero

[ https://issues.apache.org/jira/browse/LANG-1444?focusedWorklogId=524896=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524896 ] ASF GitHub Bot logged work on LANG-1444: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls commented on pull request #675: LANG-1444

coveralls commented on pull request #675: URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745948308 [](https://coveralls.io/builds/35755438) Coverage increased (+0.0003%) to 95.016% when pulling