garydgregory commented on a change in pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#discussion_r593547225
##
File path:
commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/DefaultFileContentTest.java
##
@@ -167,4 +174,32 @@ public void
testOut
coveralls edited a comment on pull request #211:
URL: https://github.com/apache/commons-io/pull/211#issuecomment-788610576
[](https://coveralls.io/builds/37899272)
Coverage remained the same at 89.275% when pulling
**
garydgregory merged pull request #209:
URL: https://github.com/apache/commons-io/pull/209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory merged pull request #210:
URL: https://github.com/apache/commons-io/pull/210
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory merged pull request #213:
URL: https://github.com/apache/commons-io/pull/213
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-79888
Hi All:
CC: @rgoers
Looking at git master, all the way back to to 1.0, unless I'm mistaken, in
`FileContent` (for the current methods all the way back), I see s
[
https://issues.apache.org/jira/browse/DAEMON-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved DAEMON-430.
Resolution: Fixed
In git master.
> prunsrv stop timeout not honored
>
[
https://issues.apache.org/jira/browse/DAEMON-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300561#comment-17300561
]
Gary D. Gregory commented on DAEMON-432:
Looks like a duplicate of DAEMON-430?
>
[
https://issues.apache.org/jira/browse/DAEMON-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated DAEMON-430:
---
Fix Version/s: (was: 1.2.4)
1.2.5
> prunsrv stop timeout not honored
>
[
https://issues.apache.org/jira/browse/VFS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300556#comment-17300556
]
Gary D. Gregory edited comment on VFS-797 at 3/12/21, 7:01 PM:
---
[
https://issues.apache.org/jira/browse/VFS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300556#comment-17300556
]
Gary D. Gregory commented on VFS-797:
-
I did not say that. You asked "I am not sure in w
[
https://issues.apache.org/jira/browse/VFS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300499#comment-17300499
]
Raghib Ali commented on VFS-797:
you mean to say that in version 2.5.0, we are not adding th
garydgregory merged pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/VFS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300497#comment-17300497
]
Gary D. Gregory commented on VFS-797:
-
If you look at VFS-741 you will see it is marked
[
https://issues.apache.org/jira/browse/VFS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated VFS-797:
Assignee: Gary D. Gregory
> JIRA Fix VFS-741 is causing an error in reading the files from azure host
arturobernalg commented on pull request #82:
URL: https://github.com/apache/commons-beanutils/pull/82#issuecomment-797645657
HI @spyrkob
Could you provide a test to reproduce the problem?
TY
This is an automated messag
arturobernalg commented on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-797641760
> > > What about elsewhere? Like the tests. Should those be updated as well?
> >
> >
> > HI @garydgregory
> > I think it's already cover and not need additio
garydgregory edited a comment on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-797617659
> > What about elsewhere? Like the tests. Should those be updated as well?
>
> HI @garydgregory
>
> I think it's already cover and not need additional
garydgregory commented on pull request #164:
URL: https://github.com/apache/commons-vfs/pull/164#issuecomment-797617659
> > What about elsewhere? Like the tests. Should those be updated as well?
>
> HI @garydgregory
>
> I think it's already cover and not need additional test.Wh
[
https://issues.apache.org/jira/browse/VFS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300417#comment-17300417
]
Raghib Ali commented on VFS-797:
Hi Gary,
Thanks for your response. Please find my answers
MaxKellermann commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797604245
Since the leak bug has always been there, and given the bad existing code
design, I guess adding a `null` check is the best we can do short-term. This
restores the old b
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797588365
@MaxKellermann - the only thing I would suggest is we fix the NPE at least.
It's better to leak objects than to blow up. I've been checking my code... I
have a million pl
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797565697
Yep, I was thinking the same things as you. So yes, there isn't much we can
do without a major version in which I personally would make `FileContent` NOT
extend `Closeabl
[
https://issues.apache.org/jira/browse/BEANUTILS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300370#comment-17300370
]
Bartosz Spyrko-Smietanko commented on BEANUTILS-547:
Possible fix:
spyrkob opened a new pull request #82:
URL: https://github.com/apache/commons-beanutils/pull/82
Issue: https://issues.apache.org/jira/browse/BEANUTILS-547
This is an automated message from the Apache Git Service.
To respond t
Bartosz Spyrko-Smietanko created BEANUTILS-547:
--
Summary: MethodUtils.getMatchingAccessibleMethod with security
manager enabled on Java 11 throws StringIndexOutOfBoundsException
Key: BEANUTILS-547
URL
MaxKellermann commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797545144
> Ah, I see now what the problem is... `getContent` on a `FileObject` is
called from multiple threads (which get the same `DefaultFileContent` object)
and then one of th
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797540807
Perhaps we could not close the streams when the `DefaultFileContent` is
closed but rather when the `FileObject` is closed?
--
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797537806
Ah, I see now what the problem is... `getContent` on a `FileObject` is
called from multiple threads (which get the same `DefaultFileContent` object)
and then one of the t
boris-petrov edited a comment on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797519098
@MaxKellermann - do you see anything obviously wrong with this PR? Any ideas
why the tests might fail (more often)?
--
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797519098
@MaxKellermann - do you see anything obviously wrong with this commit? Any
ideas why the tests might fail (more often)?
-
garydgregory commented on a change in pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#discussion_r593197551
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/FileContentThreadData.java
##
@@ -22,9 +22,6 @@
import org.apache.commo
[
https://issues.apache.org/jira/browse/IO-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Heinrichs updated IO-721:
--
Description:
A simple
{code:java}
FileUtils.copyDirectory(source, dest, glob) {code}
works fine when using
[
https://issues.apache.org/jira/browse/IO-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Heinrichs updated IO-721:
--
Description:
A simple
{code:java}
FileUtils.copyDirectory(source, dest, glob) {code}
works fine when using
Dirk Heinrichs created IO-721:
-
Summary: FileUtils.copyDirectory() tries to set last modified on
source dir after update to 2.8.0
Key: IO-721
URL: https://issues.apache.org/jira/browse/IO-721
Project: Com
[
https://issues.apache.org/jira/browse/DBCP-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300303#comment-17300303
]
Grzegorz Grzybek commented on DBCP-570:
---
I've pushed a test that reproduced the probl
[
https://issues.apache.org/jira/browse/DBCP-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300285#comment-17300285
]
Grzegorz Grzybek edited comment on DBCP-570 at 3/12/21, 12:41 PM:
---
[
https://issues.apache.org/jira/browse/DBCP-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300285#comment-17300285
]
Grzegorz Grzybek commented on DBCP-570:
---
I've just reproduced the problem with podman
[
https://issues.apache.org/jira/browse/DAEMON-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Japie vd Linde updated DAEMON-432:
--
Component/s: prunsrv
> StopTimeout flag not applied when using ProcRun
> --
Japie vd Linde created DAEMON-432:
-
Summary: StopTimeout flag not applied when using ProcRun
Key: DAEMON-432
URL: https://issues.apache.org/jira/browse/DAEMON-432
Project: Commons Daemon
Issu
boris-petrov edited a comment on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797378199
I've been running tests locally until they fail. I also see a few other
tests failing:
```
ProviderWriteTests>AbstractProviderTestCase.runTest:196->testL
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797378199
I've been running tests locally until they fail. I also see a few other
tests failing:
```
ProviderWriteTests>AbstractProviderTestCase.runTest:196->testListChil
boris-petrov commented on pull request #166:
URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797344470
I pushed a few times, 2 of those all tests passed, the last one blew up
again on the same test. I added some logging, this is the result:
```
Copying threw an ex
43 matches
Mail list logo
