[jira] [Work logged] (FILEUPLOAD-323) Implement spotbugs

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-323?focusedWorklogId=591223=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591223 ] ASF GitHub Bot logged work on FILEUPLOAD-323: - Author: ASF GitHub

[GitHub] [commons-fileupload] arturobernalg commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs

2021-04-29 Thread GitBox
arturobernalg commented on pull request #75: URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829561762 Hi @jochenw I know there still a lot a work. But what do you think as a first approximation? TY -- This is an automated message from the Apache Git

[jira] [Work logged] (FILEUPLOAD-323) Implement spotbugs

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-323?focusedWorklogId=591209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591209 ] ASF GitHub Bot logged work on FILEUPLOAD-323: - Author: ASF GitHub

[GitHub] [commons-fileupload] arturobernalg opened a new pull request #75: FILEUPLOAD-323 - Implement spotbugs

2021-04-29 Thread GitBox
arturobernalg opened a new pull request #75: URL: https://github.com/apache/commons-fileupload/pull/75 The idea it's use spotbugs in an intend of find or prevents bugs in Java code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FILEUPLOAD-323) Implement spotbugs

2021-04-29 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-323: - Summary: Implement spotbugs (was: Use spotbugs as in commons-lang now) > Implement

[jira] [Work logged] (FILEUPLOAD-318) Use try with resource

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-318?focusedWorklogId=59=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-59 ] ASF GitHub Bot logged work on FILEUPLOAD-318: - Author: ASF GitHub

[GitHub] [commons-fileupload] arturobernalg commented on pull request #69: FILEUPLOAD-318 - Use try with resource

2021-04-29 Thread GitBox
arturobernalg commented on pull request #69: URL: https://github.com/apache/commons-fileupload/pull/69#issuecomment-829399340 > Using printStacktrace() is definitely not sufficient as a means of error handling. Rethrow the Exception. Hi @jochenw what should i do with this PR?

[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload

2021-04-29 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335523#comment-17335523 ] Alex Herbert commented on NUMBERS-156: -- This seems to combine the ideas of SafeNorm and exact

[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload

2021-04-29 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335484#comment-17335484 ] Alex Herbert commented on NUMBERS-156: -- We should consider pros and cons of removing {{SafeNorm}}.

[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload

2021-04-29 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335453#comment-17335453 ] Gilles Sadowski commented on NUMBERS-156: - bq. {{Euclidean}} This should be done making sure

[jira] [Work logged] (NUMBERS-77) Move utilities from "Commons Geometry"

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-77?focusedWorklogId=590959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590959 ] ASF GitHub Bot logged work on NUMBERS-77: - Author: ASF GitHub Bot

[GitHub] [commons-numbers] asfgit merged pull request #91: NUMBERS-77: additional unit tests for Precision.DoubleEquivalence

2021-04-29 Thread GitBox
asfgit merged pull request #91: URL: https://github.com/apache/commons-numbers/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (RNG-133) LineSampler: Sample uniformly within a line

2021-04-29 Thread Alex Herbert (Jira)
Alex Herbert created RNG-133: Summary: LineSampler: Sample uniformly within a line Key: RNG-133 URL: https://issues.apache.org/jira/browse/RNG-133 Project: Commons RNG Issue Type: New Feature

[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload

2021-04-29 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335424#comment-17335424 ] Matt Juntunen commented on NUMBERS-156: --- [~aherbert], is there any reason why we can't just

[jira] [Resolved] (RNG-131) TriangleSampler: Sample uniformly within a triangle

2021-04-29 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved RNG-131. -- Fix Version/s: 1.4 Resolution: Implemented Added to master in commit 

[GitHub] [commons-rng] asfgit merged pull request #84: RNG-131: TriangleSampler to sample uniformly from a triangle.

2021-04-29 Thread GitBox
asfgit merged pull request #84: URL: https://github.com/apache/commons-rng/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (RNG-131) TriangleSampler: Sample uniformly within a triangle

2021-04-29 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335409#comment-17335409 ] Alex Herbert commented on RNG-131: -- I tried testing on a different machine. Sampling was done from random