[GitHub] [commons-io] jonfreedman commented on pull request #32: Introduce Tailable interface to allow tailing of files accessed using alternative libraries such as jCIFS or commons-vfs

2021-09-04 Thread GitBox
jonfreedman commented on pull request #32: URL: https://github.com/apache/commons-io/pull/32#issuecomment-913097582 I still think it's a valid change, I'll refresh my memory, rebase and update the java doc, I assume you want it to say @since 2.12.0? -- This is an automated message from

[GitHub] [commons-ognl] sullis opened a new pull request #49: setup-java v2 cache feature

2021-09-04 Thread GitBox
sullis opened a new pull request #49: URL: https://github.com/apache/commons-ognl/pull/49 https://github.blog/changelog/2021-08-30-github-actions-setup-java-now-supports-dependency-caching/  -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [commons-io] garydgregory commented on pull request #32: Introduce Tailable interface to allow tailing of files accessed using alternative libraries such as jCIFS or commons-vfs

2021-09-04 Thread GitBox
garydgregory commented on pull request #32: URL: https://github.com/apache/commons-io/pull/32#issuecomment-913006285 We are all volunteers here... I'm taking the time to review what's outstanding this weekend. If you are no longer interested, feel free to close this PR ;-) -- This is an

[GitHub] [commons-io] jonfreedman commented on pull request #32: Introduce Tailable interface to allow tailing of files accessed using alternative libraries such as jCIFS or commons-vfs

2021-09-04 Thread GitBox
jonfreedman commented on pull request #32: URL: https://github.com/apache/commons-io/pull/32#issuecomment-913004541 Is this now a candidate to be merged? It's over 4 years since I wrote this code and I've moved jobs twice since then! -- This is an automated message from the Apache Git S

[GitHub] [commons-io] garydgregory commented on pull request #32: Introduce Tailable interface to allow tailing of files accessed using alternative libraries such as jCIFS or commons-vfs

2021-09-04 Thread GitBox
garydgregory commented on pull request #32: URL: https://github.com/apache/commons-io/pull/32#issuecomment-913004152 May you please rebase on master? New public and protected elements should have a Javadoc @since tag. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [commons-io] garydgregory commented on pull request #76: Refactor io.monitor to support alternativ file entities

2021-09-04 Thread GitBox
garydgregory commented on pull request #76: URL: https://github.com/apache/commons-io/pull/76#issuecomment-913003825 @col-panic May you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Work logged] (LANG-1345) Add methods to enhance non-empty strings

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1345?focusedWorklogId=646615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646615 ] ASF GitHub Bot logged work on LANG-1345: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #653: LANG-1345 - Add methods to enhance non-empty strings

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #653: URL: https://github.com/apache/commons-lang/pull/653#issuecomment-729450719 [![Coverage Status](https://coveralls.io/builds/42657050/badge)](https://coveralls.io/builds/42657050) Coverage increased (+0.0006%) to 94.952% when pullin

[jira] [Work logged] (LANG-1649) Check if method is Overridable

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1649?focusedWorklogId=646614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646614 ] ASF GitHub Bot logged work on LANG-1649: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #731: LANG-1649 - Check if method is Overridable

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #731: URL: https://github.com/apache/commons-lang/pull/731#issuecomment-800829428 [![Coverage Status](https://coveralls.io/builds/42657038/badge)](https://coveralls.io/builds/42657038) Coverage increased (+0.003%) to 94.954% when pulling

[jira] [Work logged] (LANG-1652) Check whether the given class has a public constructor

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1652?focusedWorklogId=646613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646613 ] ASF GitHub Bot logged work on LANG-1652: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #736: LANG-1652 - Check whether the given class has a public constructor

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #736: URL: https://github.com/apache/commons-lang/pull/736#issuecomment-804558119 [![Coverage Status](https://coveralls.io/builds/42656977/badge)](https://coveralls.io/builds/42656977) Coverage increased (+0.0003%) to 94.952% when pullin

[jira] [Work logged] (LANG-1659) Method to check if an object it's an array

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1659?focusedWorklogId=646612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646612 ] ASF GitHub Bot logged work on LANG-1659: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1659) Method to check if an object it's an array

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1659?focusedWorklogId=646611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646611 ] ASF GitHub Bot logged work on LANG-1659: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #754: LANG-1659 - Method to check if an object it's an array

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #754: URL: https://github.com/apache/commons-lang/pull/754#issuecomment-840686273 [![Coverage Status](https://coveralls.io/builds/42656943/badge)](https://coveralls.io/builds/42656943) Coverage increased (+0.0003%) to 94.952% when pullin

[GitHub] [commons-lang] coveralls edited a comment on pull request #754: LANG-1659 - Method to check if an object it's an array

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #754: URL: https://github.com/apache/commons-lang/pull/754#issuecomment-840686273 [![Coverage Status](https://coveralls.io/builds/42656940/badge)](https://coveralls.io/builds/42656940) Coverage increased (+0.0003%) to 94.952% when pullin

[jira] [Work logged] (LANG-1660) Gets a hex String form of an object's identity hash code

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1660?focusedWorklogId=646609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646609 ] ASF GitHub Bot logged work on LANG-1660: Author: ASF GitHub Bot

[jira] [Closed] (LANG-1660) Gets a hex String form of an object's identity hash code

2021-09-04 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/LANG-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed LANG-1660. --- Resolution: Fixed Already implemented > Gets a hex String form of an object's identity hash code > --

[GitHub] [commons-lang] arturobernalg closed pull request #756: LANG-1660 - Gets a hex String form of an object's identity hash code

2021-09-04 Thread GitBox
arturobernalg closed pull request #756: URL: https://github.com/apache/commons-lang/pull/756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [commons-lang] coveralls edited a comment on pull request #755: Fix javadoc

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #755: URL: https://github.com/apache/commons-lang/pull/755#issuecomment-841625203 [![Coverage Status](https://coveralls.io/builds/42656921/badge)](https://coveralls.io/builds/42656921) Coverage remained the same at 94.951% when pulling

[GitHub] [commons-lang] coveralls commented on pull request #800: Remove redundant initializer.

2021-09-04 Thread GitBox
coveralls commented on pull request #800: URL: https://github.com/apache/commons-lang/pull/800#issuecomment-912984407 [![Coverage Status](https://coveralls.io/builds/42656915/badge)](https://coveralls.io/builds/42656915) Coverage decreased (-0.005%) to 94.946% when pulling **236

[jira] [Work logged] (LANG-1659) Method to check if an object it's an array

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1659?focusedWorklogId=646606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646606 ] ASF GitHub Bot logged work on LANG-1659: Author: ASF GitHub Bot

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #754: LANG-1659 - Method to check if an object it's an array

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #754: URL: https://github.com/apache/commons-lang/pull/754#discussion_r702291604 ## File path: src/main/java/org/apache/commons/lang3/ObjectUtils.java ## @@ -951,6 +951,25 @@ their constant using one of the CONST() utility met

[jira] [Work logged] (LANG-1659) Method to check if an object it's an array

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1659?focusedWorklogId=646605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646605 ] ASF GitHub Bot logged work on LANG-1659: Author: ASF GitHub Bot

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #754: LANG-1659 - Method to check if an object it's an array

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #754: URL: https://github.com/apache/commons-lang/pull/754#discussion_r702291220 ## File path: src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java ## @@ -586,6 +586,23 @@ public void testIsEmpty() { assertFals

[jira] [Work logged] (LANG-1659) Method to check if an object it's an array

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1659?focusedWorklogId=646604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646604 ] ASF GitHub Bot logged work on LANG-1659: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1659) Method to check if an object it's an array

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1659?focusedWorklogId=646603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646603 ] ASF GitHub Bot logged work on LANG-1659: Author: ASF GitHub Bot

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #754: LANG-1659 - Method to check if an object it's an array

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #754: URL: https://github.com/apache/commons-lang/pull/754#discussion_r702291187 ## File path: src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java ## @@ -586,6 +586,23 @@ public void testIsEmpty() { assertFals

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #754: LANG-1659 - Method to check if an object it's an array

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #754: URL: https://github.com/apache/commons-lang/pull/754#discussion_r702291124 ## File path: src/main/java/org/apache/commons/lang3/ObjectUtils.java ## @@ -951,6 +951,25 @@ their constant using one of the CONST() utility met

[jira] [Work logged] (IMAGING-159) There should be a Parameters class

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=646602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646602 ] ASF GitHub Bot logged work on IMAGING-159: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] coveralls edited a comment on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

2021-09-04 Thread GitBox
coveralls edited a comment on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637226 [![Coverage Status](https://coveralls.io/builds/42656656/badge)](https://coveralls.io/builds/42656656) Coverage decreased (-0.2%) to 76.512% when pullin

[jira] [Work logged] (IMAGING-310) JpegImageParser: Grayscale JPEG file with app14Segment returns ColorType.UNKNOWN

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-310?focusedWorklogId=646601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646601 ] ASF GitHub Bot logged work on IMAGING-310: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow commented on pull request #163: IMAGING-310 JpegImageParser.getImageInfo() Refactor colorType logic to first look at numberOfComponents

2021-09-04 Thread GitBox
kinow commented on pull request #163: URL: https://github.com/apache/commons-imaging/pull/163#issuecomment-912973601 Thanks for the pull request and sorry for taking so long to review it @jephillips34 . Will try to get on it in the next days :+1: -- This is an automated message from the

[jira] [Work logged] (IMAGING-285) Decoding of Rational Numbers broken when large values present

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-285?focusedWorklogId=646594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646594 ] ASF GitHub Bot logged work on IMAGING-285: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow commented on a change in pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-04 Thread GitBox
kinow commented on a change in pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#discussion_r702278559 ## File path: src/main/java/org/apache/commons/imaging/common/RationalNumber.java ## @@ -20,6 +20,14 @@ /** * Rational number, as used by the TIF

[jira] [Work logged] (IMAGING-285) Decoding of Rational Numbers broken when large values present

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-285?focusedWorklogId=646593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646593 ] ASF GitHub Bot logged work on IMAGING-285: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow commented on a change in pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-04 Thread GitBox
kinow commented on a change in pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#discussion_r702279148 ## File path: src/main/java/org/apache/commons/imaging/common/RationalNumber.java ## @@ -73,8 +124,41 @@ private static long gcd(final long a, final l

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=646587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646587 ] ASF GitHub Bot logged work on IO-726: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] garydgregory commented on pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-04 Thread GitBox
garydgregory commented on pull request #215: URL: https://github.com/apache/commons-io/pull/215#issuecomment-912963285 @shollander May you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

2021-09-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=646586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646586 ] ASF GitHub Bot logged work on IO-726: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] garydgregory commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-04 Thread GitBox
garydgregory commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r702276829 ## File path: src/test/java/org/apache/commons/io/input/MemoryMappedFileInputStreamTest.java ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache So

[GitHub] [commons-io] garydgregory commented on pull request #204: Changed IndexOOB to ArrayIndexOOB

2021-09-04 Thread GitBox
garydgregory commented on pull request #204: URL: https://github.com/apache/commons-io/pull/204#issuecomment-912962589 Closing: No reply since my February 16 comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [commons-io] garydgregory closed pull request #204: Changed IndexOOB to ArrayIndexOOB

2021-09-04 Thread GitBox
garydgregory closed pull request #204: URL: https://github.com/apache/commons-io/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-codec] coveralls commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-04 Thread GitBox
coveralls commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-912931083 [![Coverage Status](https://coveralls.io/builds/42655341/badge)](https://coveralls.io/builds/42655341) Coverage remained the same at 94.682% when pulling **c9d521

[GitHub] [commons-codec] DittoTool commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-04 Thread GitBox
DittoTool commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-912930932 Besides, we also found several TreeMap objects, which are only used for key-value pair retrieval. It would be better to replace it with HashMap. -- This is an automated me

[GitHub] [commons-codec] DittoTool opened a new pull request #92: Avoid inefficient usage of arraylist

2021-09-04 Thread GitBox
DittoTool opened a new pull request #92: URL: https://github.com/apache/commons-codec/pull/92 Hi, We find that there are three ArrayList objects which are not manipulated by random access. Due to the memory reallocation triggered in the successive insertions, the time complexity of add