[jira] [Commented] (NET-408) problem connecting to ProFTPD with FTPES

2022-01-30 Thread Matthias Perktold (Jira)
[ https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484550#comment-17484550 ] Matthias Perktold commented on NET-408: --- Regarding the problems with FileZilla Server 1.2.0, I [asked

[GitHub] [commons-io] arturobernalg closed pull request #322: Avoid use deprecated read basic file attributes method.

2022-01-30 Thread GitBox
arturobernalg closed pull request #322: URL: https://github.com/apache/commons-io/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025384907 Hmm, if it hasn't been set up on ci2/buildbot I'm a bit confused as to how those previous snapshots got there as https://builds.apache.org/job/Commons/job/commons-io/

[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025376139 Someone has to set it up on https://ci2.apache.org/#/ IIRC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025365768 Does something need to be done to trigger a snapshot build off master? I thought they were dailies if there were any new commits, but I don't see new snapshot builds yet

[GitHub] [commons-io] garydgregory commented on pull request #322: Avoid use deprecated read basic file attributes method.

2022-01-30 Thread GitBox
garydgregory commented on pull request #322: URL: https://github.com/apache/commons-io/pull/322#issuecomment-1025285794 The class `PathUtils` defines `readBasicFileAttributes(Path)` and `readBasicFileAttributes(Path. LinkOption...)`, the former being deprecated. When

[GitHub] [commons-io] arturobernalg commented on pull request #322: Avoid use deprecated read basic file attributes method.

2022-01-30 Thread GitBox
arturobernalg commented on pull request #322: URL: https://github.com/apache/commons-io/pull/322#issuecomment-1025236210 > Why? You'd never do this with a vararg method, especially once the deprecated method is deleted in the next major version. Plus, if we do this now, then we'd want to

[GitHub] [commons-io] garydgregory merged pull request #321: Use java8 reference

2022-01-30 Thread GitBox
garydgregory merged pull request #321: URL: https://github.com/apache/commons-io/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] garydgregory commented on pull request #322: Avoid use deprecated read basic file attributes method.

2022-01-30 Thread GitBox
garydgregory commented on pull request #322: URL: https://github.com/apache/commons-io/pull/322#issuecomment-1025233047 Why? You'd never do this with a vararg method, especially once the deprecated method is deleted in the next major version. Plus, if we do this now, then we'd want to

[jira] [Updated] (IMAGING-237) The PNG parser must inform the user if the compression method is not supported

2022-01-30 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-237: --- Assignee: Bruno P. Kinoshita > The PNG parser must inform the user if the

[jira] [Updated] (IMAGING-327) Rename setExif method in TiffImagingParameters

2022-01-30 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-327: --- Fix Version/s: 1.0-alpha3 > Rename setExif method in TiffImagingParameters >

[jira] [Updated] (IMAGING-327) Rename setExif method in TiffImagingParameters

2022-01-30 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-327: --- Affects Version/s: 1.0-alpha2 > Rename setExif method in TiffImagingParameters >

[jira] [Updated] (IMAGING-327) Rename setExif method in TiffImagingParameters

2022-01-30 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-327: --- Assignee: Bruno P. Kinoshita > Rename setExif method in TiffImagingParameters >

[jira] [Updated] (IMAGING-237) The PNG parser must inform the user if the compression method is not supported

2022-01-30 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-237: --- Assignee: (was: Bruno P. Kinoshita) > The PNG parser must inform the user if

[jira] [Resolved] (IMAGING-327) Rename setExif method in TiffImagingParameters

2022-01-30 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved IMAGING-327. Resolution: Fixed > Rename setExif method in TiffImagingParameters >

[GitHub] [commons-imaging] kinow commented on pull request #197: Imaging-327, change getExif method name

2022-01-30 Thread GitBox
kinow commented on pull request #197: URL: https://github.com/apache/commons-imaging/pull/197#issuecomment-1025231835 Merged, thanks @gwlucastrig ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [commons-imaging] kinow closed pull request #197: Imaging-327, change getExif method name

2022-01-30 Thread GitBox
kinow closed pull request #197: URL: https://github.com/apache/commons-imaging/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-imaging] gwlucastrig commented on pull request #197: Imaging-327, change getExif method name

2022-01-30 Thread GitBox
gwlucastrig commented on pull request #197: URL: https://github.com/apache/commons-imaging/pull/197#issuecomment-1025223322 Well, it took three tries, but I got it. Ready to go. No further changes are anticipated. -- This is an automated message from the Apache Git Service. To

[GitHub] [commons-imaging] coveralls commented on pull request #197: Imaging-327, change getExif method name

2022-01-30 Thread GitBox
coveralls commented on pull request #197: URL: https://github.com/apache/commons-imaging/pull/197#issuecomment-1025221610 [![Coverage Status](https://coveralls.io/builds/46066622/badge)](https://coveralls.io/builds/46066622) Coverage remained the same at 76.864% when pulling

[GitHub] [commons-imaging] gwlucastrig opened a new pull request #197: Imaging-327, change getExif method name

2022-01-30 Thread GitBox
gwlucastrig opened a new pull request #197: URL: https://github.com/apache/commons-imaging/pull/197 I am submitting the method-name change as described in Imaging-327. I have made only minimal changes for internal member element names and limited my work to just the

[jira] [Commented] (IMAGING-327) Rename setExif method in TiffImagingParameters

2022-01-30 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484408#comment-17484408 ] Gary Lucas commented on IMAGING-327: The new TiffImagingParameters class offers a welcome

[jira] [Created] (IMAGING-327) Rename setExif method in TiffImagingParameters

2022-01-30 Thread Gary Lucas (Jira)
Gary Lucas created IMAGING-327: -- Summary: Rename setExif method in TiffImagingParameters Key: IMAGING-327 URL: https://issues.apache.org/jira/browse/IMAGING-327 Project: Commons Imaging Issue

[GitHub] [commons-io] garydgregory closed pull request #59: Tailer: speed-up by avoiding BAOS.toByteArray()

2022-01-30 Thread GitBox
garydgregory closed pull request #59: URL: https://github.com/apache/commons-io/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] garydgregory commented on pull request #59: Tailer: speed-up by avoiding BAOS.toByteArray()

2022-01-30 Thread GitBox
garydgregory commented on pull request #59: URL: https://github.com/apache/commons-io/pull/59#issuecomment-1025189373 Closing, no reply since September of last year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [commons-io] garydgregory closed pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract

2022-01-30 Thread GitBox
garydgregory closed pull request #295: URL: https://github.com/apache/commons-io/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] garydgregory commented on a change in pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract

2022-01-30 Thread GitBox
garydgregory commented on a change in pull request #295: URL: https://github.com/apache/commons-io/pull/295#discussion_r795216962 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -81,20 +94,46 @@ private static Writer initWriter(final

[GitHub] [commons-io] garydgregory commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract

2022-01-30 Thread GitBox
garydgregory commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-1025188890 Closing, no reply since November of last year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [commons-io] garydgregory commented on pull request #303: BoundedInputStream extend ProxyInputStream

2022-01-30 Thread GitBox
garydgregory commented on pull request #303: URL: https://github.com/apache/commons-io/pull/303#issuecomment-1025188684 Closing, no reply since November of last year in #301. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-io] garydgregory closed pull request #303: BoundedInputStream extend ProxyInputStream

2022-01-30 Thread GitBox
garydgregory closed pull request #303: URL: https://github.com/apache/commons-io/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] garydgregory closed pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream

2022-01-30 Thread GitBox
garydgregory closed pull request #301: URL: https://github.com/apache/commons-io/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] garydgregory commented on pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream

2022-01-30 Thread GitBox
garydgregory commented on pull request #301: URL: https://github.com/apache/commons-io/pull/301#issuecomment-1025188592 Closing, no reply since November of last year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [commons-io] garydgregory commented on a change in pull request #291: Improve `ReaderInputStream` documentation

2022-01-30 Thread GitBox
garydgregory commented on a change in pull request #291: URL: https://github.com/apache/commons-io/pull/291#discussion_r795216510 ## File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java ## @@ -213,6 +230,16 @@ public void close() throws IOException {

[GitHub] [commons-io] garydgregory commented on pull request #299: IOUtils clean up javadoc

2022-01-30 Thread GitBox
garydgregory commented on pull request #299: URL: https://github.com/apache/commons-io/pull/299#issuecomment-1025187607 HI @wodencafe It's quite hard to review such a giant changeset that claims to only be about Javadoc but also changes the code in `contentEqualsIgnoreEOL`, so let's

[jira] [Work logged] (IO-484) FilenameUtils should handle embedded null bytes

2022-01-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-484?focusedWorklogId=717668=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717668 ] ASF GitHub Bot logged work on IO-484: - Author: ASF GitHub Bot Created

[GitHub] [commons-io] garydgregory merged pull request #310: (doc) [IO-484] Fix incorrect FilenameUtils documentation for null bytes

2022-01-30 Thread GitBox
garydgregory merged pull request #310: URL: https://github.com/apache/commons-io/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] chadlwilson edited a comment on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson edited a comment on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025159115 Okay thanks, will give it a go when the snapshot is rebuilt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [commons-io] chadlwilson closed pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson closed pull request #319: URL: https://github.com/apache/commons-io/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025159115 Okay thanks, will give it a go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025157666 Hello @chadlwilson I adapted the new tests and provided a different fix. Please test git master for your use case. TY! -- This is an automated message from