[jira] [Work logged] (COLLECTIONS-604) More uniform safe-null methods in CollectionUtils

2022-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-604?focusedWorklogId=726155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726155 ] ASF GitHub Bot logged work on COLLECTIONS-604: -- Author: ASF

[GitHub] [commons-collections] Kaammill opened a new pull request #279: COLLECTIONS-604

2022-02-13 Thread GitBox
Kaammill opened a new pull request #279: URL: https://github.com/apache/commons-collections/pull/279 Hi, I was thinking about the more uniform safe-null methods in CollectionUtils from jira task: COLLECTIONS-604. In my opinion it would be nice to have one way of treating null-safe meth

[jira] [Work logged] (LANG-1671) Refactor AtomicSafeInitializerTest to improve test design

2022-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1671?focusedWorklogId=726148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726148 ] ASF GitHub Bot logged work on LANG-1671: Author: ASF GitHub Bot

[GitHub] [commons-lang] JKLedzion commented on pull request #851: LANG-1671: AtomicSafeInitializerTest and LazyInitializerTest modifications using Mockito

2022-02-13 Thread GitBox
JKLedzion commented on pull request #851: URL: https://github.com/apache/commons-lang/pull/851#issuecomment-1038729148 Hi @garydgregory. Good point. I’ve added description to PR also. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
PeterAlfredLee commented on pull request #248: URL: https://github.com/apache/commons-compress/pull/248#issuecomment-1038568796 For the `@NotThreadSafe` annotation : For SevenZ archives, many entries may be compressed in a single 'folder'(see also [7z format specification](https://7z

[jira] [Work logged] (LANG-1671) Refactor AtomicSafeInitializerTest to improve test design

2022-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1671?focusedWorklogId=726078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726078 ] ASF GitHub Bot logged work on LANG-1671: Author: ASF GitHub Bot

[GitHub] [commons-codec] nhojpatrick commented on pull request #39: CODEC-285 upgrade to JUnit v5.6.0

2022-02-13 Thread GitBox
nhojpatrick commented on pull request #39: URL: https://github.com/apache/commons-codec/pull/39#issuecomment-1038454288 @garydgregory It can be useful as your migrating from JUnit v4 to JUnit v5, otherwise is a bing bang. Take advantage of assertAll and assertThrows as that would work in J

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
PeterAlfredLee commented on pull request #248: URL: https://github.com/apache/commons-compress/pull/248#issuecomment-1038562085 This change looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [commons-parent] garydgregory merged pull request #89: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1

2022-02-13 Thread GitBox
garydgregory merged pull request #89: URL: https://github.com/apache/commons-parent/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [commons-lang] garydgregory commented on pull request #851: LANG-1671: AtomicSafeInitializerTest and LazyInitializerTest modifications using Mockito

2022-02-13 Thread GitBox
garydgregory commented on pull request #851: URL: https://github.com/apache/commons-lang/pull/851#issuecomment-1037221768 A PR without a description, even if it is only a URL to a ticket, is harder to follow than it has to be. -- This is an automated message from the Apache Git Service.

[GitHub] [commons-compress] Glavo edited a comment on pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
Glavo edited a comment on pull request #248: URL: https://github.com/apache/commons-compress/pull/248#issuecomment-1038543634 > Said the above, looks like the Compress class itself is marked as not thread-safe as well @Glavo ? > > See the `@NotThreadSafe` annotation. So we could have

[GitHub] [commons-collections] Claude-at-Instaclustr commented on pull request #258: Simplify bloom filters

2022-02-13 Thread GitBox
Claude-at-Instaclustr commented on pull request #258: URL: https://github.com/apache/commons-collections/pull/258#issuecomment-1037441278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [commons-compress] Glavo commented on pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
Glavo commented on pull request #248: URL: https://github.com/apache/commons-compress/pull/248#issuecomment-1038543634 > Said the above, looks like the Compress class itself is marked as not thread-safe as well @Glavo ? > > See the `@NotThreadSafe` annotation. So we could have other

[jira] [Work logged] (IMAGING-319) updateExifMetadataLossless lost the first character of a String

2022-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-319?focusedWorklogId=726031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726031 ] ASF GitHub Bot logged work on IMAGING-319: -- Author: ASF GitHub Bot

[GitHub] [commons-codec] garydgregory edited a comment on pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
garydgregory edited a comment on pull request #104: URL: https://github.com/apache/commons-codec/pull/104#issuecomment-1038469597 My preference is to not clutter each component with this noise, it's redundant. The next version of Maven integrates this wrapper thing so maybe we should just

[GitHub] [commons-bcel] garydgregory merged pull request #114: Bump taglist-maven-plugin from 2.4 to 3.0.0

2022-02-13 Thread GitBox
garydgregory merged pull request #114: URL: https://github.com/apache/commons-bcel/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [commons-compress] garydgregory merged pull request #244: Replace manual comparisons with Comparator.comparingInt()

2022-02-13 Thread GitBox
garydgregory merged pull request #244: URL: https://github.com/apache/commons-compress/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-vfs] garydgregory commented on pull request #238: VFS-814 - FtpFileObject: re-fetch MDTM after refresh

2022-02-13 Thread GitBox
garydgregory commented on pull request #238: URL: https://github.com/apache/commons-vfs/pull/238#issuecomment-1037222065 Merged a while back but I want to say "thank you" here @lukewpc. Keep it up😀👍 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [commons-codec] garydgregory commented on pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
garydgregory commented on pull request #104: URL: https://github.com/apache/commons-codec/pull/104#issuecomment-1038469597 My preference is to not clutter each component with this noise, it's redundant. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [commons-parent] garydgregory merged pull request #90: Bump commons.pmd-impl.version from 6.41.0 to 6.42.0

2022-02-13 Thread GitBox
garydgregory merged pull request #90: URL: https://github.com/apache/commons-parent/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [commons-io] chadlwilson commented on pull request #324: Add tests to demonstrate issue with writing files into symlinked directories

2022-02-13 Thread GitBox
chadlwilson commented on pull request #324: URL: https://github.com/apache/commons-io/pull/324#issuecomment-1037745612 Hi @garydgregory - how do you suggest the PR should be updated? I had added tests to try and ensure we don't keep getting these types of regressions from refactors, but di

[GitHub] [commons-collections] Claudenw commented on a change in pull request #258: Simplify bloom filters

2022-02-13 Thread GitBox
Claudenw commented on a change in pull request #258: URL: https://github.com/apache/commons-collections/pull/258#discussion_r805173454 ## File path: src/test/java/org/apache/commons/collections4/bloomfilter/hasher/AbstractHasherTest.java ## @@ -0,0 +1,67 @@ +/* + * Licensed t

[GitHub] [commons-compress] garydgregory merged pull request #245: Replace wrapper Collections.sort is with an instance method directly.

2022-02-13 Thread GitBox
garydgregory merged pull request #245: URL: https://github.com/apache/commons-compress/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-codec] nhojpatrick commented on pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
nhojpatrick commented on pull request #104: URL: https://github.com/apache/commons-codec/pull/104#issuecomment-1038472244 @garydgregory i agree it could be considered clutter. If all projects are kept active current it's never an issue. From experience I'm coming from working with dead o

[GitHub] [commons-codec] nhojpatrick closed pull request #40: CODEC-286 upgrade to commons-lang v3.9

2022-02-13 Thread GitBox
nhojpatrick closed pull request #40: URL: https://github.com/apache/commons-codec/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-io] chadlwilson closed pull request #324: Add tests to demonstrate issue with writing files into symlinked directories

2022-02-13 Thread GitBox
chadlwilson closed pull request #324: URL: https://github.com/apache/commons-io/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [commons-compress] garydgregory merged pull request #243: Bump mockito.version from 4.2.0 to 4.3.1

2022-02-13 Thread GitBox
garydgregory merged pull request #243: URL: https://github.com/apache/commons-compress/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-parent] garydgregory commented on pull request #89: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1

2022-02-13 Thread GitBox
garydgregory commented on pull request #89: URL: https://github.com/apache/commons-parent/pull/89#issuecomment-1037247029 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Work logged] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)

2022-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=725945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725945 ] ASF GitHub Bot logged work on IO-552: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] garydgregory commented on pull request #297: IO-552: Honor tilde as a valid character for file and directory names

2022-02-13 Thread GitBox
garydgregory commented on pull request #297: URL: https://github.com/apache/commons-io/pull/297#issuecomment-1037374255 I'm still not sure about this one since ~ is a shell convention to expand the home directory as opposed to anything to do with the actual file system. Needs further thoug

[GitHub] [commons-compress] garydgregory merged pull request #246: Replace manual copy of array contents with System.arraycopy().

2022-02-13 Thread GitBox
garydgregory merged pull request #246: URL: https://github.com/apache/commons-compress/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-collections] aherbert commented on pull request #258: Simplify bloom filters

2022-02-13 Thread GitBox
aherbert commented on pull request #258: URL: https://github.com/apache/commons-collections/pull/258#issuecomment-1037596846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-io] garydgregory commented on pull request #324: Add tests to demonstrate issue with writing files into symlinked directories

2022-02-13 Thread GitBox
garydgregory commented on pull request #324: URL: https://github.com/apache/commons-io/pull/324#issuecomment-1037372649 Hello @chadlwilson I've brought in the tests separately and the runtime is better, would you please check your use case, update this PR or create a new one? TY! --

[GitHub] [commons-compress] Glavo edited a comment on pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
Glavo edited a comment on pull request #248: URL: https://github.com/apache/commons-compress/pull/248#issuecomment-1038543634 > Said the above, looks like the Compress class itself is marked as not thread-safe as well @Glavo ? > > See the `@NotThreadSafe` annotation. So we could have

[GitHub] [commons-compress] Glavo commented on pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
Glavo commented on pull request #248: URL: https://github.com/apache/commons-compress/pull/248#issuecomment-1038543634 > Said the above, looks like the Compress class itself is marked as not thread-safe as well @Glavo ? > > See the `@NotThreadSafe` annotation. So we could have other

[GitHub] [commons-codec] nhojpatrick commented on pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
nhojpatrick commented on pull request #104: URL: https://github.com/apache/commons-codec/pull/104#issuecomment-1038472244 @garydgregory i agree it could be considered clutter. If all projects are kept active current it's never an issue. From experience I'm coming from working with dead o

[GitHub] [commons-codec] garydgregory edited a comment on pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
garydgregory edited a comment on pull request #104: URL: https://github.com/apache/commons-codec/pull/104#issuecomment-1038469597 My preference is to not clutter each component with this noise, it's redundant. The next version of Maven integrates this wrapper thing so maybe we should just

[GitHub] [commons-codec] garydgregory commented on pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
garydgregory commented on pull request #104: URL: https://github.com/apache/commons-codec/pull/104#issuecomment-1038469597 My preference is to not clutter each component with this noise, it's redundant. -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (COMPRESS-365) Use java.nio.file.Path instead of java.io.File

2022-02-13 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491718#comment-17491718 ] Gary D. Gregory commented on COMPRESS-365: -- As of today, Expander supports NIO

[jira] [Comment Edited] (COMPRESS-598) NullPointerException in ZipArchiveInputStream.getCompressedCount()

2022-02-13 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453671#comment-17453671 ] Gary D. Gregory edited comment on COMPRESS-598 at 2/13/22, 11:00 PM:

[GitHub] [commons-codec] nhojpatrick opened a new pull request #104: Maven Wrapper v3.1.0 with Maven v3.8.4

2022-02-13 Thread GitBox
nhojpatrick opened a new pull request #104: URL: https://github.com/apache/commons-codec/pull/104 Now the Takari Maven Wrapper has been adopted by Apache Maven, I'm submitted again. This makes cicd simpler so now the cicd process can be used to check the latest maven works. Each proj

[GitHub] [commons-codec] nhojpatrick closed pull request #40: CODEC-286 upgrade to commons-lang v3.9

2022-02-13 Thread GitBox
nhojpatrick closed pull request #40: URL: https://github.com/apache/commons-codec/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-codec] nhojpatrick commented on pull request #39: CODEC-285 upgrade to JUnit v5.6.0

2022-02-13 Thread GitBox
nhojpatrick commented on pull request #39: URL: https://github.com/apache/commons-codec/pull/39#issuecomment-1038454288 @garydgregory It can be useful as your migrating from JUnit v4 to JUnit v5, otherwise is a bing bang. Take advantage of assertAll and assertThrows as that would work in J

[jira] [Comment Edited] (COMPRESS-605) Failed to parse Non-zip64 signed apk with data descriptor

2022-02-13 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491713#comment-17491713 ] Gary D. Gregory edited comment on COMPRESS-605 at 2/13/22, 10:18 PM:

[jira] [Commented] (COMPRESS-605) Failed to parse Non-zip64 signed apk with data descriptor

2022-02-13 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491713#comment-17491713 ] Gary D. Gregory commented on COMPRESS-605: -- [~nicktheuncharted]  I added a ba

[GitHub] [commons-collections] aherbert commented on pull request #258: Simplify bloom filters

2022-02-13 Thread GitBox
aherbert commented on pull request #258: URL: https://github.com/apache/commons-collections/pull/258#issuecomment-1038446799 Hi @Claudenw I have added a new github workflow for coverage reporting to master. If you pick up the changes for your next push then we should see coverage c

[GitHub] [commons-collections] Claude-at-Instaclustr commented on pull request #258: Simplify bloom filters

2022-02-13 Thread GitBox
Claude-at-Instaclustr commented on pull request #258: URL: https://github.com/apache/commons-collections/pull/258#issuecomment-1038389673 I think I have fixed the issues you noted.  However, I am fighting with formatting and getting it all just right.  I should be able to check it i

[jira] [Commented] (JEXL-357) Configure accessible packages/classes/methods/fields

2022-02-13 Thread Dmitri Blinov (Jira)
[ https://issues.apache.org/jira/browse/JEXL-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491610#comment-17491610 ] Dmitri Blinov commented on JEXL-357: The current implementation does not honor classes

[GitHub] [commons-compress] garydgregory merged pull request #246: Replace manual copy of array contents with System.arraycopy().

2022-02-13 Thread GitBox
garydgregory merged pull request #246: URL: https://github.com/apache/commons-compress/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-compress] garydgregory merged pull request #244: Replace manual comparisons with Comparator.comparingInt()

2022-02-13 Thread GitBox
garydgregory merged pull request #244: URL: https://github.com/apache/commons-compress/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-compress] garydgregory merged pull request #245: Replace wrapper Collections.sort is with an instance method directly.

2022-02-13 Thread GitBox
garydgregory merged pull request #245: URL: https://github.com/apache/commons-compress/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-compress] garydgregory merged pull request #243: Bump mockito.version from 4.2.0 to 4.3.1

2022-02-13 Thread GitBox
garydgregory merged pull request #243: URL: https://github.com/apache/commons-compress/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[GitHub] [commons-compress] Glavo opened a new pull request #248: Fix thread safety issues when encoding 7z password

2022-02-13 Thread GitBox
Glavo opened a new pull request #248: URL: https://github.com/apache/commons-compress/pull/248 `CharsetEncoder` is not thread safe. Due to shared `PASSWORD_ENCODER`, problems may occur when encoding 7z file passwords in parallel (e.g. the BOM is not written correctly). It doesn't se

[jira] [Commented] (GEOMETRY-142) Point Set/Map

2022-02-13 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491588#comment-17491588 ] Matt Juntunen commented on GEOMETRY-142: Thanks for the feedback, [~aherbert] a

[jira] [Work logged] (IMAGING-319) updateExifMetadataLossless lost the first character of a String

2022-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-319?focusedWorklogId=725801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725801 ] ASF GitHub Bot logged work on IMAGING-319: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] gwlucastrig opened a new pull request #203: IMAGING-319: Correct length calculation in EXIF rewriter

2022-02-13 Thread GitBox
gwlucastrig opened a new pull request #203: URL: https://github.com/apache/commons-imaging/pull/203 I added comments to the JIRA ticket on this item at [IMAGING-319](https://issues.apache.org/jira/browse/IMAGING-319) Unfortunately, it will be hard for me to create a JUnit test to spe

[GitHub] [commons-geometry] darkma773r opened a new pull request #193: WIP: Point map

2022-02-13 Thread GitBox
darkma773r opened a new pull request #193: URL: https://github.com/apache/commons-geometry/pull/193 Work-in-progress PR for GEOMETRY-142: Point map/set implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Comment Edited] (GEOMETRY-142) Point Set/Map

2022-02-13 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491526#comment-17491526 ] Bruno P. Kinoshita edited comment on GEOMETRY-142 at 2/13/22, 8:42 AM: --

[jira] [Commented] (GEOMETRY-142) Point Set/Map

2022-02-13 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491526#comment-17491526 ] Bruno P. Kinoshita commented on GEOMETRY-142: - Said that, I looked at the c