[jira] [Resolved] (VFS-799) Minor improvements

2022-04-20 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/VFS-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved VFS-799. --- Resolution: Fixed In Master. > Minor improvements > -- > > Key:

[GitHub] [commons-vfs] MaxKellermann commented on pull request #20: AbstractFileObject: call doGetType() without holding the lock

2022-04-20 Thread GitBox
MaxKellermann commented on PR #20: URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-1104656002 Pong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Work logged] (LANG-1662) Create methods on ReflectionToStringBuilder to reflect only select fields

2022-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1662?focusedWorklogId=759660=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759660 ] ASF GitHub Bot logged work on LANG-1662: Author: ASF GitHub Bot

[GitHub] [commons-lang] GutoVeronezi commented on pull request #849: [LANG-1662] Create methods on ReflectionToStringBuilder to reflect only select fields

2022-04-20 Thread GitBox
GutoVeronezi commented on PR #849: URL: https://github.com/apache/commons-lang/pull/849#issuecomment-1104565683 Hi, @kinow, Thanks for the review. I fixed the bug with the exception and added more unit tests. I couldn't think in many other situations to validate; therefore, if

[jira] [Commented] (VFS-778) SftpFileSystem returning null channel

2022-04-20 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525346#comment-17525346 ] Gary D. Gregory commented on VFS-778: - Ping? > SftpFileSystem returning null channel >

[jira] [Commented] (VFS-799) Minor improvements

2022-04-20 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525345#comment-17525345 ] Gary D. Gregory commented on VFS-799: - [~arturobernalg]  Ok to close this ticket? > Minor improvements

[jira] [Closed] (VFS-802) Unused return value

2022-04-20 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed VFS-802. --- Resolution: Won't Fix > Unused return value > --- > > Key: VFS-802 >

[GitHub] [commons-vfs] garydgregory commented on pull request #225: Bump sshd-core from 0.8.0 to 2.8.0

2022-04-20 Thread GitBox
garydgregory commented on PR #225: URL: https://github.com/apache/commons-vfs/pull/225#issuecomment-1104538612 We need help here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-vfs] garydgregory commented on pull request #225: Bump sshd-core from 0.8.0 to 2.8.0

2022-04-20 Thread GitBox
garydgregory commented on PR #225: URL: https://github.com/apache/commons-vfs/pull/225#issuecomment-1104538613 We need help here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-vfs] garydgregory commented on pull request #88: Fix for failed test cases when running with root

2022-04-20 Thread GitBox
garydgregory commented on PR #88: URL: https://github.com/apache/commons-vfs/pull/88#issuecomment-1104538455 Ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-vfs] garydgregory commented on pull request #88: Fix for failed test cases when running with root

2022-04-20 Thread GitBox
garydgregory commented on PR #88: URL: https://github.com/apache/commons-vfs/pull/88#issuecomment-1104538454 Ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-vfs] garydgregory commented on pull request #20: AbstractFileObject: call doGetType() without holding the lock

2022-04-20 Thread GitBox
garydgregory commented on PR #20: URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-1104537857 Ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-vfs] garydgregory merged pull request #258: Simplify/remove redundant operations.

2022-04-20 Thread GitBox
garydgregory merged PR #258: URL: https://github.com/apache/commons-vfs/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (VFS-770) FileSystemManager.createFileSystem(FileObject) fails on Gzip files.

2022-04-20 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-770. - Fix Version/s: 2.10.0 Resolution: Fixed A fix is in git master. Please verify and close.  

[GitHub] [commons-vfs] garydgregory closed pull request #92: [VFS-770] Gz createFileSystem fails

2022-04-20 Thread GitBox
garydgregory closed pull request #92: [VFS-770] Gz createFileSystem fails URL: https://github.com/apache/commons-vfs/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-vfs] garydgregory commented on pull request #92: [VFS-770] Gz createFileSystem fails

2022-04-20 Thread GitBox
garydgregory commented on PR #92: URL: https://github.com/apache/commons-vfs/pull/92#issuecomment-1104518267 Implemented differently in git master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [commons-vfs] garydgregory commented on pull request #92: [VFS-770] Gz createFileSystem fails

2022-04-20 Thread GitBox
garydgregory commented on PR #92: URL: https://github.com/apache/commons-vfs/pull/92#issuecomment-1104518094 https://issues.apache.org/jira/browse/VFS-770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-vfs] garydgregory commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

2022-04-20 Thread GitBox
garydgregory commented on PR #150: URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-1104473323 @boris-petrov #151 is in, but the builds still fail here. Any ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-vfs] boris-petrov commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

2022-04-20 Thread GitBox
boris-petrov commented on PR #150: URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-1104401055 @garydgregory done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-vfs] arturobernalg commented on pull request #258: Simplify/remove redundant operations.

2022-04-20 Thread GitBox
arturobernalg commented on PR #258: URL: https://github.com/apache/commons-vfs/pull/258#issuecomment-1104383896 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #258: Simplify/remove redundant operations.

2022-04-20 Thread GitBox
garydgregory commented on code in PR #258: URL: https://github.com/apache/commons-vfs/pull/258#discussion_r854483654 ## commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http/HttpFileSystemConfigBuilder.java: ## @@ -297,7 +297,7 @@ public void setFollowRedirect(final

[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #258: Simplify/remove redundant operations.

2022-04-20 Thread GitBox
garydgregory commented on code in PR #258: URL: https://github.com/apache/commons-vfs/pull/258#discussion_r854400751 ## commons-vfs2/src/main/java/org/apache/commons/vfs2/FileSystemConfigBuilder.java: ## @@ -193,7 +193,7 @@ protected Character getCharacter(final

[GitHub] [commons-vfs] garydgregory closed pull request #53: [VFS-398] FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name

2022-04-20 Thread GitBox
garydgregory closed pull request #53: [VFS-398] FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name URL: https://github.com/apache/commons-vfs/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-vfs] garydgregory commented on pull request #53: [VFS-398] FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name

2022-04-20 Thread GitBox
garydgregory commented on PR #53: URL: https://github.com/apache/commons-vfs/pull/53#issuecomment-1104060840 No feedback, closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-vfs] garydgregory commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

2022-04-20 Thread GitBox
garydgregory commented on PR #150: URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-1104060162 Hi @boris-petrov May you rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-vfs] garydgregory closed pull request #151: Refactor AbstractFileObject#getOutputStream()

2022-04-20 Thread GitBox
garydgregory closed pull request #151: Refactor AbstractFileObject#getOutputStream() URL: https://github.com/apache/commons-vfs/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-vfs] garydgregory commented on pull request #151: Refactor AbstractFileObject#getOutputStream()

2022-04-20 Thread GitBox
garydgregory commented on PR #151: URL: https://github.com/apache/commons-vfs/pull/151#issuecomment-1104059369 Hi @boris-petrov I patched this PR locally and committed a slightly different version to avoid possible if unlikely NPEs. -- This is an automated message from the Apache Git

[GitHub] [commons-vfs] garydgregory merged pull request #253: Simplify conditions and avoid extra checks

2022-04-20 Thread GitBox
garydgregory merged PR #253: URL: https://github.com/apache/commons-vfs/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (VFS-818) SftpFileObject.isReadable may return false for user root

2022-04-20 Thread Jira
[ https://issues.apache.org/jira/browse/VFS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524780#comment-17524780 ] Christian Nüssgens commented on VFS-818: I think we should only change the behaviour of